github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-01 02:26:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

bot review

Browse Source
This commit is contained in:
J. Nick Koston
2026-03-02 07:34:47 -10:00
parent cff32556a2
commit 15a792ecce
1 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/test_micros_to_millis.py
+14 -8
View File
@@ -83,19 +83,22 @@ def test_32bit_boundary_values(us: int) -> None:
@pytest.mark.parametrize("hi", HI_VALUES, ids=lambda v: f"hi={v}")
@pytest.mark.parametrize("lo_offset", LO_VALUES, ids=lambda v: f"lo={v}")
def test_32bit_hi_lo_combinations(hi: int, lo_offset: int) -> None:
us = (hi << 32) | lo_offset
assert micros_to_millis(us) == reference_32(us)
# Construct x so that after the >>3 shift, the internal hi/lo match the params
x = (hi << 32) | lo_offset
for mod8 in range(8):
us = (x << 3) + mod8
assert micros_to_millis(us) == reference_32(us)
@pytest.mark.parametrize("hi", [1, 50, 100, 500, 1000, 5000], ids=lambda v: f"hi={v}")
def test_32bit_carry_boundary(hi: int) -> None:
"""Test around the adj overflow boundary (hi * R + lo > UINT32_MAX)."""
base = hi << 35
hi_r = hi * R
if hi_r < UINT32_MAX:
threshold_lo = UINT32_MAX - hi_r
for lo in [threshold_lo - 1, threshold_lo, threshold_lo + 1]:
us = base | (lo << 3)
x = (hi << 32) | lo
us = x << 3
assert micros_to_millis(us) == reference_32(us)
@@ -125,19 +128,22 @@ def test_64bit_boundary_values(us: int) -> None:
@pytest.mark.parametrize("hi", HI_VALUES, ids=lambda v: f"hi={v}")
@pytest.mark.parametrize("lo_offset", LO_VALUES, ids=lambda v: f"lo={v}")
def test_64bit_hi_lo_combinations(hi: int, lo_offset: int) -> None:
us = (hi << 32) | lo_offset
assert micros_to_millis_64(us) == reference_64(us)
# Construct x so that after the >>3 shift, the internal hi/lo match the params
x = (hi << 32) | lo_offset
for mod8 in range(8):
us = (x << 3) + mod8
assert micros_to_millis_64(us) == reference_64(us)
@pytest.mark.parametrize("hi", [1, 50, 100, 500, 1000, 5000], ids=lambda v: f"hi={v}")
def test_64bit_carry_boundary(hi: int) -> None:
"""Test around the adj overflow boundary for 64-bit result."""
base = hi << 35
hi_r = hi * R
if hi_r < UINT32_MAX:
threshold_lo = UINT32_MAX - hi_r
for lo in [threshold_lo - 1, threshold_lo, threshold_lo + 1]:
us = base | (lo << 3)
x = (hi << 32) | lo
us = x << 3
assert micros_to_millis_64(us) == reference_64(us)