github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-02 02:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix clang-tidy errors from CI

Browse Source 
- Match Arduino core's declaration of _irom0_text_start/_end as
  void functions (mmu_iram.h declares them this way)
- Use C-style casts with NOLINT for int-to-ptr conversions in
  custom_crash_callback (clang-tidy performance-no-int-to-ptr)
This commit is contained in:
J. Nick Koston
2026-04-05 13:28:29 -10:00
parent 1ecd45d14d
commit 0614849896
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/esp8266/crash_handler.cpp
+7 -6
View File
@@ -27,9 +27,10 @@ static constexpr uint32_t IRAM_END = 0x40108000; // 32KB
// Linker symbols for the actual firmware IROM section.
// Using these instead of a conservative upper bound (0x40400000) prevents
// false positives from stale stack values beyond the actual flash mapping.
// Declared as void functions to match the Arduino core's mmu_iram.h declarations.
extern "C" {
extern uint8_t _irom0_text_start; // NOLINT(bugprone-reserved-identifier,readability-identifier-naming)
extern uint8_t _irom0_text_end; // NOLINT(bugprone-reserved-identifier,readability-identifier-naming)
extern void _irom0_text_start(void); // NOLINT(bugprone-reserved-identifier,readability-identifier-naming)
extern void _irom0_text_end(void); // NOLINT(bugprone-reserved-identifier,readability-identifier-naming)
}
// Check if a value looks like a code address in IRAM or flash-mapped IROM.
@@ -37,8 +38,8 @@ extern uint8_t _irom0_text_end; // NOLINT(bugprone-reserved-identifier,readab
// Linker symbols are link-time constants — safe to reference from any context.
static inline bool is_code_addr(uint32_t val) {
uint32_t addr = (val & XTENSA_ADDR_MASK) | XTENSA_CODE_BASE;
return (addr >= IRAM_START && addr < IRAM_END) || (addr >= reinterpret_cast<uint32_t>(&_irom0_text_start) &&
addr < reinterpret_cast<uint32_t>(&_irom0_text_end));
return (addr >= IRAM_START && addr < IRAM_END) ||
(addr >= (uint32_t) _irom0_text_start && addr < (uint32_t) _irom0_text_end);
}
// Recover the actual code address from a windowed-ABI return address on the stack.
@@ -205,8 +206,8 @@ extern "C" void IRAM_ATTR custom_crash_callback(struct rst_info *rst_info, uint3
RtcCrashData data; // NOLINT(cppcoreguidelines-pro-type-member-init)
uint8_t count = 0;
auto *scan = reinterpret_cast<uint32_t *>(stack);
auto *end = reinterpret_cast<uint32_t *>(stack_end);
auto *scan = (uint32_t *) stack; // NOLINT(performance-no-int-to-ptr)
auto *end = (uint32_t *) stack_end; // NOLINT(performance-no-int-to-ptr)
uint32_t epc1 = rst_info->epc1;
for (; scan < end && count < MAX_BACKTRACE; scan++) {