github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-15 02:32:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Split the field type guards into one static_assert per field

Browse Source 
clang-tidy flags the chained is_same_v checks as a redundant expression.
This commit is contained in:
J. Nick Koston
2026-10-02 21:42:31 -05:00
parent 3ac5918ec8
commit 053cb337aa
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/binary_sensor/filter.h
+5 -3
View File
@@ -88,9 +88,11 @@ struct AutorepeatFilterTiming {
uint32_t time_on;
};
// Read straight from flash on ESP8266, so every field must stay a word.
static_assert(std::is_same_v<decltype(AutorepeatFilterTiming::delay), uint32_t> &&
std::is_same_v<decltype(AutorepeatFilterTiming::time_off), uint32_t> &&
std::is_same_v<decltype(AutorepeatFilterTiming::time_on), uint32_t>,
static_assert(std::is_same_v<decltype(AutorepeatFilterTiming::delay), uint32_t>,
"AutorepeatFilterTiming fields must stay uint32_t");
static_assert(std::is_same_v<decltype(AutorepeatFilterTiming::time_off), uint32_t>,
"AutorepeatFilterTiming fields must stay uint32_t");
static_assert(std::is_same_v<decltype(AutorepeatFilterTiming::time_on), uint32_t>,
"AutorepeatFilterTiming fields must stay uint32_t");
/// Timings live in a PROGMEM table emitted by codegen, ended by an entry whose delay is