github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-13 16:18:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

[esp32_ble_tracker] Address review: clarify gate comments

Browse Source 
- 'all clients are idle' was accurate pre-patch; now this branch can run
  while CONNECTED/ESTABLISHED clients exist. Clarify which states actually
  block, and note that the inner coex revert has its own gate.
- Generalize the coex-revert rationale: 'lock's GATT Write Response' was
  Yale-specific; the bug is generic to any peer GATT response that needs
  to reach us while WiFi competes for the shared radio.
This commit is contained in:
Paul Lazarre
2026-04-26 19:32:45 -05:00
committed by plazarre
parent debddac0fe
commit 02674199da
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp
+6 -4
View File
@@ -191,13 +191,15 @@ void ESP32BLETracker::loop() {
*/
// Start scan: reached when scanner_state_ becomes IDLE (via set_scanner_state_()) and
// all clients are idle (their state changes increment version when they finish)
// no clients are in the transient CONNECTING / DISCOVERED / DISCONNECTING states
// (their state changes increment version when they finish). CONNECTED / ESTABLISHED
// clients do NOT block this branch — the coex revert below has its own active-count gate.
if (this->scanner_state_ == ScannerState::IDLE && !counts.connecting && !counts.disconnecting && !counts.discovered) {
#ifdef USE_ESP32_BLE_SOFTWARE_COEXISTENCE
// Only revert to BALANCE when no connections are active. Established connections
// continue to need PREFER_BT so the lock's GATT Write Response can reach us while
// WiFi traffic (advertisement upload, log streaming) competes for the shared radio.
// Reverting too early causes Bluedroid to time out at ~20s and synthesize status=133.
// continue to need PREFER_BT so peer GATT responses can reach us while WiFi traffic
// (advertisement upload, log streaming) competes for the shared radio. Reverting too
// early causes Bluedroid to time out at ~20s and synthesize status=133.
if (!counts.active) {
this->update_coex_preference_(false);
}