github/zigbee-OTA
2
0
Fork 0
mirror of https://github.com/Koenkk/zigbee-OTA.git synced 2026-06-24 11:14:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix url encoding (#679)

Browse Source
This commit is contained in:
Koen Kanters
2025-02-07 20:55:13 +01:00
committed by GitHub
parent ebe2aa59d0
commit 50db043486
5 changed files with 39 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/ghw_reprocess_all_images.test.ts
View File

@@ -366,13 +366,12 @@ describe('Github Workflow: Re-Process All Images', () => {
const fileName = oldMetas.url.split('/').pop()!;
const newName = fileName.replace('.ota', `(%1).ota`);
const baseUrl = oldMetas.url.replace(fileName, '');
oldMetas.url = baseUrl + escape(newName);
oldMetas.url = baseUrl + encodeURIComponent(newName);
setManifest(common.BASE_INDEX_MANIFEST_FILENAME, [oldMetas]);
const imagePath = useImage(IMAGE_V14_1, BASE_IMAGES_TEST_DIR_PATH);
const baseName = path.basename(imagePath.filename);
const renamedPath = imagePath.filename.replace(baseName, newName);
renameSync(imagePath.filename, renamedPath);
console.log(newName, oldMetas.url, renamedPath);
// @ts-expect-error mocked as needed
await reProcessAllImages(github, core, context, true, true);
@@ -384,7 +383,7 @@ describe('Github Workflow: Re-Process All Images', () => {
const outManifestMetas = withExtraMetas(
IMAGE_V14_1_METAS,
// @ts-expect-error override
{fileName: newName, url: `${baseUrl}${newName}`},
{fileName: newName, url: `${baseUrl}${encodeURIComponent(newName)}`},
);
delete outManifestMetas.originalUrl;
expect(writeManifestSpy).toHaveBeenNthCalledWith(2, common.BASE_INDEX_MANIFEST_FILENAME, [outManifestMetas]);
@@ -752,7 +751,7 @@ describe('Github Workflow: Re-Process All Images', () => {
const fileName = oldMetas.url.split('/').pop()!;
const newName = fileName.replace('.ota', `(%1).ota`);
const baseUrl = oldMetas.url.replace(fileName, '');
oldMetas.url = baseUrl + escape(newName);
oldMetas.url = baseUrl + encodeURIComponent(newName);
// @ts-expect-error old metas
setManifest(common.BASE_INDEX_MANIFEST_FILENAME, [oldMetas]);
// link back to existing image from fetch