github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-23 21:14:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

[api] Remove virtual destructor from ProtoMessage

Browse Source 
API protobuf messages are never deleted through base class pointers —
they are always stack-allocated and passed by reference. The virtual
destructor occupies 2 vtable slots (complete + deleting destructor)
on 32-bit platforms using the Itanium ABI, costing 8 bytes per vtable.

With 122 message classes, removing the virtual destructor saves
~976 bytes of flash. Each vtable shrinks from 24 bytes to 16 bytes.
This commit is contained in:
J. Nick Koston
2026-02-28 16:29:19 -10:00
parent 3f97b3b706
commit f3c175ab39
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
script/api_protobuf/api_protobuf.py
+1 -2
View File
@@ -2473,8 +2473,7 @@ def build_base_class(
out = f"class {base_class_name} : public {parent_class} {{\n"
out += " public:\n"
# Add destructor with override
public_content.insert(0, f"~{base_class_name}() override = default;")
# No virtual destructor - messages are never deleted polymorphically
# Base classes don't implement encode/decode/calculate_size
# Derived classes handle these with their specific field numbers