From e93e064304c2110c3e7f51f172e45301815209f9 Mon Sep 17 00:00:00 2001
From: "J. Nick Koston" <nick@home-assistant.io>
Date: Tue, 17 Mar 2026 18:27:53 -1000
Subject: [PATCH] [http_request] Inline apply_manifest_result_main_loop_ into
 defer lambda
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

One less method — the logic lives directly in the lambda body.
No flash change (compiler was already inlining the call).
---
 .../update/http_request_update.cpp            | 66 +++++++++----------
 .../http_request/update/http_request_update.h |  1 -
 2 files changed, 32 insertions(+), 35 deletions(-)

diff --git a/esphome/components/http_request/update/http_request_update.cpp b/esphome/components/http_request/update/http_request_update.cpp
index 2f14efc3d0..981f1adac1 100644
--- a/esphome/components/http_request/update/http_request_update.cpp
+++ b/esphome/components/http_request/update/http_request_update.cpp
@@ -191,44 +191,42 @@ defer:
   // same thread as readers (API, MQTT, web server). This is a single defer for
   // both success and error paths to avoid multiple std::function instantiations.
   // Lambda captures only 2 pointers (8 bytes) — fits in std::function SBO on all platforms.
-  this_update->defer([this_update, info]() { this_update->apply_manifest_result_main_loop_(info); });
+  this_update->defer([this_update, info]() {
+    if (info->error_str != nullptr) {
+      this_update->status_set_error(info->error_str);
+      delete info;
+      return;
+    }
+
+    // Determine new state on main loop (avoids extra lambda captures from task)
+    bool trigger_update_available = false;
+    update::UpdateState new_state;
+    if (info->latest_version.empty() || info->latest_version == info->current_version) {
+      new_state = update::UPDATE_STATE_NO_UPDATE;
+    } else {
+      new_state = update::UPDATE_STATE_AVAILABLE;
+      if (this_update->state_ != update::UPDATE_STATE_AVAILABLE) {
+        trigger_update_available = true;
+      }
+    }
+
+    this_update->update_info_ = std::move(*info);
+    this_update->update_info_.has_progress = false;
+    this_update->update_info_.progress = 0.0f;
+    this_update->state_ = new_state;
+    delete info;
+
+    this_update->status_clear_error();
+    this_update->publish_state();
+
+    if (trigger_update_available) {
+      this_update->get_update_available_trigger()->trigger(this_update->update_info_);
+    }
+  });
 
   UPDATE_RETURN;
 }
 
-void HttpRequestUpdate::apply_manifest_result_main_loop_(update::UpdateInfo *info) {
-  if (info->error_str != nullptr) {
-    this->status_set_error(info->error_str);
-    delete info;
-    return;
-  }
-
-  // Determine new state on main loop (avoids extra lambda captures from task)
-  bool trigger_update_available = false;
-  update::UpdateState new_state;
-  if (info->latest_version.empty() || info->latest_version == info->current_version) {
-    new_state = update::UPDATE_STATE_NO_UPDATE;
-  } else {
-    new_state = update::UPDATE_STATE_AVAILABLE;
-    if (this->state_ != update::UPDATE_STATE_AVAILABLE) {
-      trigger_update_available = true;
-    }
-  }
-
-  this->update_info_ = std::move(*info);
-  this->update_info_.has_progress = false;
-  this->update_info_.progress = 0.0f;
-  this->state_ = new_state;
-  delete info;
-
-  this->status_clear_error();
-  this->publish_state();
-
-  if (trigger_update_available) {
-    this->get_update_available_trigger()->trigger(this->update_info_);
-  }
-}
-
 void HttpRequestUpdate::perform(bool force) {
   if (this->state_ != update::UPDATE_STATE_AVAILABLE && !force) {
     return;
diff --git a/esphome/components/http_request/update/http_request_update.h b/esphome/components/http_request/update/http_request_update.h
index 87116e8282..b8350346f9 100644
--- a/esphome/components/http_request/update/http_request_update.h
+++ b/esphome/components/http_request/update/http_request_update.h
@@ -37,7 +37,6 @@ class HttpRequestUpdate final : public update::UpdateEntity, public PollingCompo
   std::string source_url_;
 
   static void update_task(void *params);
-  void apply_manifest_result_main_loop_(update::UpdateInfo *info);
 #ifdef USE_ESP32
   TaskHandle_t update_task_handle_{nullptr};
 #endif