github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-23 06:36:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[core] Make FINAL_VALIDATE_SCHEMA functions return None (#18457)

Browse Source
This commit is contained in:
Jesse Hills
2026-08-18 08:26:24 +12:00
committed by GitHub
parent e32329cc11
commit e45b4e4938
48 changed files with 79 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/component_tests/esp32_hosted/test_init.py
+1 -1
View File
@@ -19,7 +19,7 @@ def test_final_validate_accepts_supported_idf(
PlatformFramework.ESP32_IDF,
platform_data={KEY_IDF_VERSION: cv.Version.parse(idf)},
)
assert _final_validate({}) == {}
_final_validate({})
@pytest.mark.parametrize("idf", ["5.0.0", "5.2.2"])
tests/component_tests/image/test_init.py
+9 -8
View File
@@ -371,27 +371,28 @@ def test_migrate_returns_none_for_invalid_legacy_shapes(
def test_validate_image_final_defaults_to_little_endian() -> None:
out = validate_image_final({CONF_FILE: "x.png"})
assert out[CONF_BYTE_ORDER] == "LITTLE_ENDIAN"
config = {CONF_FILE: "x.png"}
validate_image_final(config)
assert config[CONF_BYTE_ORDER] == "LITTLE_ENDIAN"
def test_validate_image_final_keeps_little_endian(
caplog: pytest.LogCaptureFixture,
) -> None:
config = {CONF_FILE: "x.png", CONF_BYTE_ORDER: "LITTLE_ENDIAN"}
with caplog.at_level(logging.WARNING):
out = validate_image_final(
{CONF_FILE: "x.png", CONF_BYTE_ORDER: "LITTLE_ENDIAN"}
)
assert out[CONF_BYTE_ORDER] == "LITTLE_ENDIAN"
validate_image_final(config)
assert config[CONF_BYTE_ORDER] == "LITTLE_ENDIAN"
assert "big-endian" not in caplog.text
def test_validate_image_final_warns_on_big_endian(
caplog: pytest.LogCaptureFixture,
) -> None:
config = {CONF_FILE: "x.png", CONF_BYTE_ORDER: "BIG_ENDIAN"}
with caplog.at_level(logging.WARNING):
out = validate_image_final({CONF_FILE: "x.png", CONF_BYTE_ORDER: "BIG_ENDIAN"})
assert out[CONF_BYTE_ORDER] == "BIG_ENDIAN"
validate_image_final(config)
assert config[CONF_BYTE_ORDER] == "BIG_ENDIAN"
assert "big-endian" in caplog.text
tests/component_tests/provisioning/test_provisioning.py
+3 -3
View File
@@ -37,7 +37,7 @@ def test_provisioning_accepts_a_registered_source(
set_core_config(PlatformFramework.ESP32_IDF)
register_source("network")
# Should not raise.
assert FINAL_VALIDATE_SCHEMA({}) == {}
FINAL_VALIDATE_SCHEMA({})
def test_provisioning_warns_on_hardcoded_credentials(
@@ -49,7 +49,7 @@ def test_provisioning_warns_on_hardcoded_credentials(
register_source("network")
report_hardcoded_credentials("wifi")
with caplog.at_level(logging.WARNING):
assert FINAL_VALIDATE_SCHEMA({}) == {}
FINAL_VALIDATE_SCHEMA({})
assert "wifi" in caplog.text
assert "credentials" in caplog.text
@@ -62,7 +62,7 @@ def test_provisioning_no_warning_without_hardcoded_credentials(
set_core_config(PlatformFramework.ESP32_IDF)
register_source("network")
with caplog.at_level(logging.WARNING):
assert FINAL_VALIDATE_SCHEMA({}) == {}
FINAL_VALIDATE_SCHEMA({})
assert "credentials" not in caplog.text