From dc11bb8709d80e90e6d80563f186bc37ca90cb91 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 4 Feb 2026 10:29:59 +0100 Subject: [PATCH] cleanup duplicate code --- esphome/components/cover/automation.h | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/esphome/components/cover/automation.h b/esphome/components/cover/automation.h index 8dee297634..ad8a4a7022 100644 --- a/esphome/components/cover/automation.h +++ b/esphome/components/cover/automation.h @@ -90,25 +90,18 @@ template class CoverPublishAction : public Action { Cover *cover_; }; -template class CoverIsOpenCondition : public Condition { +template class CoverPositionCondition : public Condition { public: - CoverIsOpenCondition(Cover *cover) : cover_(cover) {} + CoverPositionCondition(Cover *cover) : cover_(cover) {} - bool check(const Ts &...x) override { return this->cover_->position == COVER_OPEN; } + bool check(const Ts &...x) override { return this->cover_->position == POS; } protected: Cover *cover_; }; -template class CoverIsClosedCondition : public Condition { - public: - CoverIsClosedCondition(Cover *cover) : cover_(cover) {} - - bool check(const Ts &...x) override { return this->cover_->position == COVER_CLOSED; } - - protected: - Cover *cover_; -}; +template using CoverIsOpenCondition = CoverPositionCondition; +template using CoverIsClosedCondition = CoverPositionCondition; template class CoverPositionTrigger : public Trigger<> { public: