From cf704b6b91c11ef0b661194705597e4fa628bd34 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Mon, 6 Apr 2026 20:54:01 -1000 Subject: [PATCH] Address review: remove unused global, fix assertion messages --- .../integration/fixtures/scheduler_interval_reschedule.yaml | 4 ---- tests/integration/test_scheduler_interval_reschedule.py | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/integration/fixtures/scheduler_interval_reschedule.yaml b/tests/integration/fixtures/scheduler_interval_reschedule.yaml index d690eb4b2d..91a8f38849 100644 --- a/tests/integration/fixtures/scheduler_interval_reschedule.yaml +++ b/tests/integration/fixtures/scheduler_interval_reschedule.yaml @@ -17,10 +17,6 @@ globals: - id: slow_count type: int initial_value: "0" - # Track ordering: set when medium fires before fast has fired 5 times - - id: order_ok - type: bool - initial_value: "true" # Track interval that cancels itself - id: self_cancel_count type: int diff --git a/tests/integration/test_scheduler_interval_reschedule.py b/tests/integration/test_scheduler_interval_reschedule.py index dec4ed0b09..701cbfa65c 100644 --- a/tests/integration/test_scheduler_interval_reschedule.py +++ b/tests/integration/test_scheduler_interval_reschedule.py @@ -88,7 +88,7 @@ async def test_scheduler_interval_reschedule( # Fast runs at 50ms, medium at 100ms, so fast should be ~2x medium # Allow some slack for scheduling jitter assert fast_at_medium_5 >= 7, ( - f"Fast interval should have fired ~10 times when medium hit 5, " + f"Fast interval should have fired at least 7 times when medium hit 5, " f"but only fired {fast_at_medium_5} times" ) @@ -102,11 +102,11 @@ async def test_scheduler_interval_reschedule( fast_at_slow_3, medium_at_slow_3 = result # At 600ms: fast ~12, medium ~6, slow 3 assert fast_at_slow_3 >= 8, ( - f"Fast should have fired ~12 times when slow hit 3, " + f"Fast should have fired at least 8 times when slow hit 3, " f"but only fired {fast_at_slow_3}" ) assert medium_at_slow_3 >= 4, ( - f"Medium should have fired ~6 times when slow hit 3, " + f"Medium should have fired at least 4 times when slow hit 3, " f"but only fired {medium_at_slow_3}" )