From c74889de67e2cd18317b3dcb86a95fdefb32dd77 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sat, 4 Apr 2026 12:10:42 -1000 Subject: [PATCH] Fix clang-tidy: rename wake_loop_impl_ to wake_loop_impl (no trailing underscore on free functions) --- esphome/components/socket/lwip_raw_tcp_impl.cpp | 2 +- esphome/core/wake.cpp | 2 +- esphome/core/wake.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/esphome/components/socket/lwip_raw_tcp_impl.cpp b/esphome/components/socket/lwip_raw_tcp_impl.cpp index 35224442ee..0ec16b0251 100644 --- a/esphome/components/socket/lwip_raw_tcp_impl.cpp +++ b/esphome/components/socket/lwip_raw_tcp_impl.cpp @@ -44,7 +44,7 @@ void socket_delay(uint32_t ms) { void IRAM_ATTR socket_wake() { s_socket_woke = true; // Inline impl — this is IRAM_ATTR so the inlined code stays in IRAM - esphome::wake_loop_impl_(); + esphome::wake_loop_impl(); } #elif defined(USE_RP2040) // RP2040 (non-FreeRTOS) socket wake using hardware WFE/SEV instructions. diff --git a/esphome/core/wake.cpp b/esphome/core/wake.cpp index d09918af4c..ecc7adcb4d 100644 --- a/esphome/core/wake.cpp +++ b/esphome/core/wake.cpp @@ -27,7 +27,7 @@ volatile bool g_main_loop_woke = false; #endif #ifdef USE_ESP8266 -void IRAM_ATTR wake_loop_any_context() { wake_loop_impl_(); } +void IRAM_ATTR wake_loop_any_context() { wake_loop_impl(); } #endif // === RP2040 — wakeable_delay (needs file-scope state for alarm callback) === diff --git a/esphome/core/wake.h b/esphome/core/wake.h index 13052160d2..7f4fcd60da 100644 --- a/esphome/core/wake.h +++ b/esphome/core/wake.h @@ -54,7 +54,7 @@ inline void wakeable_delay(uint32_t ms) { #elif defined(USE_ESP8266) /// Inline implementation — IRAM callers inline this directly. -inline void ESPHOME_ALWAYS_INLINE wake_loop_impl_() { +inline void ESPHOME_ALWAYS_INLINE wake_loop_impl() { g_main_loop_woke = true; esp_schedule(); } @@ -63,7 +63,7 @@ inline void ESPHOME_ALWAYS_INLINE wake_loop_impl_() { void wake_loop_any_context(); /// Non-ISR: always inline. -inline void wake_loop_threadsafe() { wake_loop_impl_(); } +inline void wake_loop_threadsafe() { wake_loop_impl(); } namespace internal { inline void wakeable_delay(uint32_t ms) {