From b9d80a5ef357314c96548df3dd389c8da57e74da Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sat, 27 Dec 2025 11:27:28 -1000 Subject: [PATCH] [esp32_improv] Use stack buffer for URL formatting to avoid heap allocation --- esphome/components/esp32_improv/esp32_improv_component.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/esphome/components/esp32_improv/esp32_improv_component.cpp b/esphome/components/esp32_improv/esp32_improv_component.cpp index c05057919f0..05a30e2941a 100644 --- a/esphome/components/esp32_improv/esp32_improv_component.cpp +++ b/esphome/components/esp32_improv/esp32_improv_component.cpp @@ -405,7 +405,7 @@ void ESP32ImprovComponent::check_wifi_connection_() { if (ip.is_ip4()) { // "http://" (7) + IPv4 max (15) + ":" (1) + port max (5) + null = 29 char url_buffer[32]; - memcpy(url_buffer, "http://", 7); // NOLINT - str_to null-terminates + memcpy(url_buffer, "http://", 7); // NOLINT(bugprone-not-null-terminated-result) - str_to null-terminates ip.str_to(url_buffer + 7); size_t len = strlen(url_buffer); snprintf(url_buffer + len, sizeof(url_buffer) - len, ":%d", USE_WEBSERVER_PORT);