Apply simplify pass: shared idedata warning, platform-keyed backend table, one owner for the cache prefix and trigger files

tests/script/test_determine_jobs.py

@@ -3111,33 +3111,36 @@ def test_memory_impact_elf_layouts_are_found(tmp_path: Path) -> None:
         assert find_elf_path(build_path) == elf, f"{platform} ELF not found"
 
 
-def test_esp8266_native_components_full_list_on_infra_change() -> None:
-    """Native-ESP8266 infrastructure changes run the full test list."""
-    for changed in (
-        ["esphome/arduino8266/framework.py"],
-        ["esphome/build_gen/arduino8266.py"],
-        ["esphome/components/esp8266/build_surgery.py"],
+@pytest.mark.parametrize(
+    "changed",
+    [
+        "esphome/arduino8266/framework.py",
+        "esphome/build_gen/arduino8266.py",
+        "esphome/components/esp8266/build_surgery.py",
         # Shared modules the native build depends on
-        ["esphome/build_helpers/idedata.py"],
-        ["esphome/platformio/library.py"],
+        "esphome/build_helpers/idedata.py",
+        "esphome/platformio/library.py",
         # Top-level esphome/*.py modules the backend imports directly
-        ["esphome/framework_helpers.py"],
-        ["esphome/writer.py"],
+        "esphome/framework_helpers.py",
+        "esphome/writer.py",
         # esp8266/__init__.py imports copy_ccache_script from it
-        ["esphome/platformio/toolchain.py"],
+        "esphome/platformio/toolchain.py",
         # The composite cache action must not ship unexercised
-        [".github/actions/cache-arduino8266/action.yml"],
+        ".github/actions/cache-arduino8266/action.yml",
+    ],
+)
+def test_esp8266_native_components_full_list_on_infra_change(changed: str) -> None:
+    """Native-ESP8266 infrastructure changes run the full test list."""
+    with (
+        patch.object(determine_jobs, "changed_files", return_value=[changed]),
+        patch.object(
+            determine_jobs,
+            "get_components_with_dependencies",
+            return_value=["wifi"],
+        ),
     ):
-        with (
-            patch.object(determine_jobs, "changed_files", return_value=changed),
-            patch.object(
-                determine_jobs,
-                "get_components_with_dependencies",
-                return_value=["wifi"],
-            ),
-        ):
-            result = determine_jobs.esp8266_native_components_to_test()
-            assert result == sorted(determine_jobs.ESP8266_NATIVE_TEST_COMPONENTS)
+        result = determine_jobs.esp8266_native_components_to_test()
+        assert result == sorted(determine_jobs.ESP8266_NATIVE_TEST_COMPONENTS)
 
 
 @pytest.mark.parametrize(

tests/unit_tests/test_arduino8266_toolchain.py

@@ -147,8 +147,6 @@ def test_run_compile_noop_skips_the_build_spawn(tmp_path: Path) -> None:
 def test_run_compile_regenerates_stale_compdb(tmp_path: Path) -> None:
     """An interrupted run can leave build.ninja newer than the compile DB;
     mere existence must not skip regeneration."""
-    import os
-
     build_dir = toolchain.get_build_dir()
     build_dir.mkdir(parents=True, exist_ok=True)
     (build_dir / "build.ninja").write_text("")
@@ -246,7 +244,7 @@ def test_run_compile_warns_when_idedata_fails(
         patch.object(toolchain, "get_idedata", return_value=None),
     ):
         assert toolchain.run_compile({CONF_ESPHOME: {}}, verbose=False) == 0
-    assert "Could not generate idedata" in caplog.text
+    assert "No idedata was generated for this build" in caplog.text
 
 
 def test_write_compile_commands(tmp_path: Path) -> None:
@@ -422,6 +420,8 @@ def test_run_compile_skips_compdb_when_ninja_unchanged(tmp_path: Path) -> None:
     """An unchanged build.ninja means the compile DB is already current."""
     build_dir = toolchain.get_build_dir()
     build_dir.mkdir(parents=True, exist_ok=True)
+    # write_project (stubbed below) always leaves a build.ninja behind
+    (build_dir / "build.ninja").write_text("# manifest")
 
     def run(regenerate_expected: bool) -> None:
         with (