mirror of
https://github.com/esphome/esphome.git
synced 2026-09-15 17:18:40 +00:00
Merge remote-tracking branch 'upstream/lint-no-powf-core' into integration
This commit is contained in:
@@ -841,6 +841,54 @@ def lint_no_scanf(fname, match):
|
||||
)
|
||||
|
||||
|
||||
# Base entity platforms - these are linked into most builds and should not
|
||||
# pull in powf/__ieee754_powf (~2.3KB flash).
|
||||
BASE_ENTITY_PLATFORMS = [
|
||||
"alarm_control_panel",
|
||||
"binary_sensor",
|
||||
"button",
|
||||
"climate",
|
||||
"cover",
|
||||
"datetime",
|
||||
"event",
|
||||
"fan",
|
||||
"light",
|
||||
"lock",
|
||||
"media_player",
|
||||
"number",
|
||||
"select",
|
||||
"sensor",
|
||||
"switch",
|
||||
"text",
|
||||
"text_sensor",
|
||||
"update",
|
||||
"valve",
|
||||
"water_heater",
|
||||
]
|
||||
|
||||
# Directories protected from powf: core + all base entity platforms
|
||||
POWF_PROTECTED_DIRS = ["esphome/core"] + [
|
||||
f"esphome/components/{p}" for p in BASE_ENTITY_PLATFORMS
|
||||
]
|
||||
|
||||
|
||||
@lint_re_check(
|
||||
r"[^\w]powf\s*\(" + CPP_RE_EOL,
|
||||
include=[
|
||||
f"{d}/*.{ext}" for d in POWF_PROTECTED_DIRS for ext in ["h", "cpp", "tcc"]
|
||||
],
|
||||
)
|
||||
def lint_no_powf_in_core(fname, match):
|
||||
return (
|
||||
f"{highlight('powf()')} pulls in __ieee754_powf (~2.3KB flash) and is not allowed in "
|
||||
f"core or base entity platform code. These files are linked into every build.\n"
|
||||
f"Please use alternatives:\n"
|
||||
f" - {highlight('pow10_int(exp)')} for integer powers of 10 (from helpers.h)\n"
|
||||
f" - Precomputed lookup tables for gamma/non-integer exponents\n"
|
||||
f"(If powf is strictly necessary, add `// NOLINT` to the line)"
|
||||
)
|
||||
|
||||
|
||||
LOG_MULTILINE_RE = re.compile(r"ESP_LOG\w+\s*\(.*?;", re.DOTALL)
|
||||
LOG_BAD_CONTINUATION_RE = re.compile(r'\\n(?:[^ \\"\r\n\t]|"\s*\n\s*"[^ \\])')
|
||||
LOG_PERCENT_S_CONTINUATION_RE = re.compile(r'\\n(?:%s|"\s*\n\s*"%s)')
|
||||
|
||||
Reference in New Issue
Block a user