From a3febe4a9eebbe8a9481c63956e3f76c570e4f9d Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Fri, 3 Apr 2026 23:20:05 -1000 Subject: [PATCH] fix bloat --- esphome/components/api/api_connection.h | 4 +++- esphome/components/api/api_pb2_service.cpp | 5 ----- esphome/components/api/api_pb2_service.h | 2 -- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/esphome/components/api/api_connection.h b/esphome/components/api/api_connection.h index 6fbf24c215e..61168e43c8a 100644 --- a/esphome/components/api/api_connection.h +++ b/esphome/components/api/api_connection.h @@ -409,7 +409,9 @@ class APIConnection final : public APIServerConnectionBase { uint32_t remaining_size) { #ifdef HAS_PROTO_MESSAGE_DUMP if (conn->flags_.log_only_mode) { - conn->log_send_message_(msg); + auto *proto_msg = static_cast(msg); + DumpBuffer dump_buf; + conn->log_send_message_(proto_msg->message_name(), proto_msg->dump_to(dump_buf)); return 1; } #endif diff --git a/esphome/components/api/api_pb2_service.cpp b/esphome/components/api/api_pb2_service.cpp index 20b201fec11..b41233eddd1 100644 --- a/esphome/components/api/api_pb2_service.cpp +++ b/esphome/components/api/api_pb2_service.cpp @@ -12,11 +12,6 @@ static const char *const TAG = "api.service"; void APIServerConnectionBase::log_send_message_(const LogString *name, const char *dump) { ESP_LOGVV(TAG, "send_message %s: %s", LOG_STR_ARG(name), dump); } -void APIServerConnectionBase::log_send_message_(const void *msg) { - auto *proto_msg = static_cast(msg); - DumpBuffer dump_buf; - this->log_send_message_(proto_msg->message_name(), proto_msg->dump_to(dump_buf)); -} void APIServerConnectionBase::log_receive_message_(const LogString *name, const ProtoMessage &msg) { DumpBuffer dump_buf; ESP_LOGVV(TAG, "%s: %s", LOG_STR_ARG(name), msg.dump_to(dump_buf)); diff --git a/esphome/components/api/api_pb2_service.h b/esphome/components/api/api_pb2_service.h index 1ae085fb5e1..6ff988902f3 100644 --- a/esphome/components/api/api_pb2_service.h +++ b/esphome/components/api/api_pb2_service.h @@ -13,8 +13,6 @@ class APIServerConnectionBase { #ifdef HAS_PROTO_MESSAGE_DUMP protected: void log_send_message_(const LogString *name, const char *dump); - // Log a message being sent from a void pointer (for use in encode_to_buffer paths) - void log_send_message_(const void *msg); void log_receive_message_(const LogString *name, const ProtoMessage &msg); void log_receive_message_(const LogString *name);