From f982dc94267b4bc5aa16208da8b0f52b2136d86a Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sun, 22 Mar 2026 21:39:53 -1000 Subject: [PATCH 1/4] Add test for _generate_component_source_table with empty pool --- tests/unit_tests/test_cpp_helpers.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/unit_tests/test_cpp_helpers.py b/tests/unit_tests/test_cpp_helpers.py index efb3ca5e07..3579ce098b 100644 --- a/tests/unit_tests/test_cpp_helpers.py +++ b/tests/unit_tests/test_cpp_helpers.py @@ -103,6 +103,18 @@ def test_generate_source_table_code_empty(): assert _generate_source_table_code("TBL", "lookup", {}) == "" +@pytest.mark.asyncio +async def test_generate_component_source_table_empty_pool(monkeypatch): + """Test that _generate_component_source_table does nothing with an empty pool.""" + from esphome.cpp_helpers import _generate_component_source_table + + monkeypatch.setattr(ch, "CORE", Mock(data={})) + add_global_mock = Mock() + monkeypatch.setattr(ch, "add_global", add_global_mock) + await _generate_component_source_table() + add_global_mock.assert_not_called() + + def test_register_component_source_overflow_warns(monkeypatch, caplog): # Pre-fill pool to max pool = ComponentSourcePool( From c8d97830f20f80828794aaeef69b1e67fb1f4521 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sun, 22 Mar 2026 21:42:56 -1000 Subject: [PATCH 2/4] Add non-empty test for _generate_source_table_code --- tests/unit_tests/test_cpp_helpers.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/unit_tests/test_cpp_helpers.py b/tests/unit_tests/test_cpp_helpers.py index 3579ce098b..31fb19e384 100644 --- a/tests/unit_tests/test_cpp_helpers.py +++ b/tests/unit_tests/test_cpp_helpers.py @@ -103,6 +103,19 @@ def test_generate_source_table_code_empty(): assert _generate_source_table_code("TBL", "lookup", {}) == "" +def test_generate_source_table_code_non_empty(): + from esphome.cpp_helpers import _generate_source_table_code + + code = _generate_source_table_code("TBL", "lookup", {"wifi": 1, "api": 2}) + assert "PROGMEM" in code + assert "wifi" in code + assert "api" in code + assert "lookup" in code + assert "index == 0" in code + assert "progmem_read_ptr" in code + assert "index > 2" in code + + @pytest.mark.asyncio async def test_generate_component_source_table_empty_pool(monkeypatch): """Test that _generate_component_source_table does nothing with an empty pool.""" From cba87a22fb030504e6d20cf4cf6d394b8f545095 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sun, 22 Mar 2026 21:43:36 -1000 Subject: [PATCH 3/4] Add type annotations to new tests --- tests/unit_tests/test_cpp_helpers.py | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/unit_tests/test_cpp_helpers.py b/tests/unit_tests/test_cpp_helpers.py index 31fb19e384..52424a7cb2 100644 --- a/tests/unit_tests/test_cpp_helpers.py +++ b/tests/unit_tests/test_cpp_helpers.py @@ -82,12 +82,14 @@ async def test_register_component__with_setup_priority(monkeypatch): assert core_mock.component_ids == [] -def test_register_component_source_empty_name(monkeypatch): +def test_register_component_source_empty_name(monkeypatch: pytest.MonkeyPatch) -> None: monkeypatch.setattr(ch, "CORE", Mock(data={})) assert register_component_source("") == 0 -def test_register_component_source_deduplicates(monkeypatch): +def test_register_component_source_deduplicates( + monkeypatch: pytest.MonkeyPatch, +) -> None: monkeypatch.setattr(ch, "CORE", Mock(data={})) idx1 = register_component_source("wifi") idx2 = register_component_source("api") @@ -97,13 +99,13 @@ def test_register_component_source_deduplicates(monkeypatch): assert idx3 == 1 # deduplicated -def test_generate_source_table_code_empty(): +def test_generate_source_table_code_empty() -> None: from esphome.cpp_helpers import _generate_source_table_code assert _generate_source_table_code("TBL", "lookup", {}) == "" -def test_generate_source_table_code_non_empty(): +def test_generate_source_table_code_non_empty() -> None: from esphome.cpp_helpers import _generate_source_table_code code = _generate_source_table_code("TBL", "lookup", {"wifi": 1, "api": 2}) @@ -117,7 +119,9 @@ def test_generate_source_table_code_non_empty(): @pytest.mark.asyncio -async def test_generate_component_source_table_empty_pool(monkeypatch): +async def test_generate_component_source_table_empty_pool( + monkeypatch: pytest.MonkeyPatch, +) -> None: """Test that _generate_component_source_table does nothing with an empty pool.""" from esphome.cpp_helpers import _generate_component_source_table @@ -128,7 +132,9 @@ async def test_generate_component_source_table_empty_pool(monkeypatch): add_global_mock.assert_not_called() -def test_register_component_source_overflow_warns(monkeypatch, caplog): +def test_register_component_source_overflow_warns( + monkeypatch: pytest.MonkeyPatch, caplog: pytest.LogCaptureFixture +) -> None: # Pre-fill pool to max pool = ComponentSourcePool( sources={f"comp_{i}": i + 1 for i in range(0xFF)}, From d9adb078aa2fa4ba1db4912672d7904ea1038818 Mon Sep 17 00:00:00 2001 From: Tobias Stanzel Date: Sun, 29 Mar 2026 19:41:00 +0200 Subject: [PATCH 4/4] [tm1637] Add buffer manipulation methods (#13686) Co-authored-by: Jonathan Swoboda <154711427+swoboda1337@users.noreply.github.com> --- esphome/components/tm1637/tm1637.cpp | 6 ++++++ esphome/components/tm1637/tm1637.h | 3 +++ tests/components/tm1637/common.yaml | 2 ++ 3 files changed, 11 insertions(+) diff --git a/esphome/components/tm1637/tm1637.cpp b/esphome/components/tm1637/tm1637.cpp index f9c876f40c..da9adb59a4 100644 --- a/esphome/components/tm1637/tm1637.cpp +++ b/esphome/components/tm1637/tm1637.cpp @@ -348,6 +348,12 @@ uint8_t TM1637Display::print(uint8_t start_pos, const char *str) { return pos - start_pos; } uint8_t TM1637Display::print(const char *str) { return this->print(0, str); } + +void TM1637Display::set_buffer(const uint8_t *data, uint8_t length) { + uint8_t len = std::min(length, (uint8_t) sizeof(this->buffer_)); + memcpy(this->buffer_, data, len); +} + uint8_t TM1637Display::printf(uint8_t pos, const char *format, ...) { va_list arg; va_start(arg, format); diff --git a/esphome/components/tm1637/tm1637.h b/esphome/components/tm1637/tm1637.h index b9e96119e9..c1fbabb21b 100644 --- a/esphome/components/tm1637/tm1637.h +++ b/esphome/components/tm1637/tm1637.h @@ -47,6 +47,9 @@ class TM1637Display : public PollingComponent { /// Print `str` at position 0. uint8_t print(const char *str); + /// Set raw buffer bytes from data array up to length bytes. + void set_buffer(const uint8_t *data, uint8_t length); + void set_intensity(uint8_t intensity) { this->intensity_ = intensity; } void set_inverted(bool inverted) { this->inverted_ = inverted; } void set_length(uint8_t length) { this->length_ = length; } diff --git a/tests/components/tm1637/common.yaml b/tests/components/tm1637/common.yaml index 8d01e29877..b6debc055d 100644 --- a/tests/components/tm1637/common.yaml +++ b/tests/components/tm1637/common.yaml @@ -5,3 +5,5 @@ display: intensity: 3 lambda: |- it.print("1234"); + static const uint8_t buf[] = {0x3f, 0x06, 0x5b, 0x4f | 0x80}; + it.set_buffer(buf, sizeof(buf));