[scheduler] Replace unique_ptr with raw pointers, add leak detection

The scheduler was already managing SchedulerItem lifecycle explicitly
through its object pool (recycle_item_main_loop_ / get_item_from_pool_locked_).
The unique_ptr wrapper added overhead (11 destructor call sites on the hot path)
without providing safety — if a lifecycle path was missed, the unique_ptr would
silently delete the item and cause needless heap allocations instead of pool reuse.

Replace unique_ptr<SchedulerItem, SchedulerItemDeleter> with raw SchedulerItem*
throughout. Every item is now explicitly recycled to the pool or deleted via
delete_item_(). This eliminates all 11 unique_ptr destructor calls from the hot
path and saves ~256 bytes of firmware.

Add debug leak detection under ESPHOME_DEBUG_SCHEDULER: a live-item counter
verified at the end of every call() cycle asserts that all allocated items are
accounted for in items_, to_add_, defer_queue_, or the pool. This turns silent
heap churn from missed lifecycle management into an immediate assert failure
caught by integration tests.

Also moves the retry-cancelled check before item allocation in set_timer_common_
to avoid needless alloc+delete on the cold retry path, and fixes a thread-safety
issue where recycle_item_main_loop_ (main-loop-only) was called from
set_timer_common_ which can run on non-main-loop threads.

Enable debug_scheduler: true in all 18 scheduler integration test fixtures.
This commit is contained in:
J. Nick Koston
2026-03-08 00:08:22 -10:00
parent 0c4a44566f
commit 982998c8fb
18 changed files with 180 additions and 117 deletions
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-bulk-cleanup
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-defer-cancel
host:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-defer-cancel-regular
host:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-defer-fifo-simple
host:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-defer-stress-test
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-heap-stress-test
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-internal-id-test
on_boot:
priority: -100
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-null-name
host:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-numeric-id-test
on_boot:
priority: -100
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: sched-rapid-cancel-test
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: sched-recursive-timeout
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-removed-item-race
host:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-retry-test
on_boot:
priority: -100
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: sched-simul-callbacks-test
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: scheduler-string-lifetime-test
external_components:
@@ -1,4 +1,5 @@
esphome:
debug_scheduler: true # Enable scheduler leak detection
name: sched-string-name-stress
external_components: