github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-22 22:26:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mitsubishi_cn105] Add vertical vane control action (#16737)

Browse Source 
Co-authored-by: J. Nick Koston <nick@koston.org>
This commit is contained in:
Boris Krivonog
2026-08-11 18:39:05 -05:00
committed by GitHub
co-authored by J. Nick Koston
parent 3540012529
commit 9556c2bc4c
9 changed files with 190 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/mitsubishi_cn105/common.h
+1
View File
@@ -8,6 +8,7 @@
#include <vector>
#include "esphome/components/uart/uart_component.h"
#include "esphome/components/mitsubishi_cn105/mitsubishi_cn105.h"
#include "esphome/components/mitsubishi_cn105/automation.h"
#include "esphome/components/mitsubishi_cn105/mitsubishi_cn105_component.h"
#include "esphome/components/mitsubishi_cn105/mitsubishi_cn105_climate.h"
tests/components/mitsubishi_cn105/common.yaml
+8
View File
@@ -29,3 +29,11 @@ esphome:
temperature: 22.0
- mitsubishi_cn105.clear_remote_temperature:
id: ac
- mitsubishi_cn105.vane.control:
id: ac
vertical:
direction: SWING
- mitsubishi_cn105.vane.control:
id: ac
vertical:
direction: !lambda return esphome::mitsubishi_cn105::VERTICAL_VANE_MODE_SWING;
tests/components/mitsubishi_cn105/mitsubishi_cn105_component_tests.cpp
+29 -4
View File
@@ -24,25 +24,50 @@ TEST(MitsubishiCN105ComponentTests, PublishesVaneStateForEveryValidSnapshot) {
EXPECT_EQ(callback_direction, std::optional{VERTICAL_VANE_MODE_POSITION_4});
}
TEST(MitsubishiCN105ComponentTests, DoesNotPublishUnknownVaneState) {
TEST(MitsubishiCN105ComponentTests, PublishesUnknownVaneState) {
TestableMitsubishiCN105Component hub;
size_t status_callback_count = 0;
size_t vane_callback_count = 0;
std::optional<VerticalVaneMode> callback_direction;
hub.add_on_status_callback([&]() { status_callback_count++; });
hub.add_on_vane_state_callback([&](const VaneState &) { vane_callback_count++; });
hub.add_on_vane_state_callback([&](const VaneState &state) {
vane_callback_count++;
callback_direction = state.vertical.direction;
});
hub.mutable_status().room_temperature = 20.0f;
hub.mutable_status().vane_mode = MitsubishiCN105::VaneMode::UNKNOWN;
hub.publish_status();
EXPECT_EQ(status_callback_count, 1);
EXPECT_EQ(vane_callback_count, 0);
EXPECT_EQ(vane_callback_count, 1);
EXPECT_EQ(callback_direction, std::optional{VERTICAL_VANE_MODE_UNKNOWN});
hub.mutable_status().vane_mode = MitsubishiCN105::VaneMode::POSITION_4;
hub.publish_status();
EXPECT_EQ(status_callback_count, 2);
EXPECT_EQ(vane_callback_count, 1);
EXPECT_EQ(vane_callback_count, 2);
EXPECT_EQ(callback_direction, std::optional{VERTICAL_VANE_MODE_POSITION_4});
}
TEST(MitsubishiCN105ComponentTests, VaneCallAppliesVerticalDirection) {
TestableMitsubishiCN105Component hub;
auto call = hub.make_vane_call();
call.vertical.set_direction(VERTICAL_VANE_MODE_POSITION_5);
call.perform();
EXPECT_EQ(hub.status().vane_mode, MitsubishiCN105::VaneMode::POSITION_5);
}
TEST(MitsubishiCN105ComponentTests, VaneControlActionAppliesConfiguredFields) {
TestableMitsubishiCN105Component hub;
VaneControlAction<> action(&hub, [](VaneCall &call) { call.vertical.set_direction(VERTICAL_VANE_MODE_SWING); });
action.play();
EXPECT_EQ(hub.status().vane_mode, MitsubishiCN105::VaneMode::SWING);
}
} // namespace esphome::mitsubishi_cn105::testing