diff --git a/esphome/components/alarm_control_panel/alarm_control_panel.cpp b/esphome/components/alarm_control_panel/alarm_control_panel.cpp index ab0a780cefb..fb61776532f 100644 --- a/esphome/components/alarm_control_panel/alarm_control_panel.cpp +++ b/esphome/components/alarm_control_panel/alarm_control_panel.cpp @@ -51,22 +51,6 @@ void AlarmControlPanel::publish_state(AlarmControlPanelState state) { } } -void AlarmControlPanel::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} - -void AlarmControlPanel::add_on_cleared_callback(std::function &&callback) { - this->cleared_callback_.add(std::move(callback)); -} - -void AlarmControlPanel::add_on_chime_callback(std::function &&callback) { - this->chime_callback_.add(std::move(callback)); -} - -void AlarmControlPanel::add_on_ready_callback(std::function &&callback) { - this->ready_callback_.add(std::move(callback)); -} - void AlarmControlPanel::arm_with_code_(AlarmControlPanelCall &(AlarmControlPanelCall::*arm_method)(), const char *code) { auto call = this->make_call(); diff --git a/esphome/components/alarm_control_panel/alarm_control_panel.h b/esphome/components/alarm_control_panel/alarm_control_panel.h index e8dc197e26f..cf99d359e75 100644 --- a/esphome/components/alarm_control_panel/alarm_control_panel.h +++ b/esphome/components/alarm_control_panel/alarm_control_panel.h @@ -37,25 +37,24 @@ class AlarmControlPanel : public EntityBase { * * @param callback The callback function */ - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } - /** Add a callback for when the state of the alarm_control_panel clears from triggered - * - * @param callback The callback function - */ - void add_on_cleared_callback(std::function &&callback); + /** Add a callback for when the state of the alarm_control_panel clears from triggered. */ + template void add_on_cleared_callback(F &&callback) { + this->cleared_callback_.add(std::forward(callback)); + } - /** Add a callback for when a chime zone goes from closed to open - * - * @param callback The callback function - */ - void add_on_chime_callback(std::function &&callback); + /** Add a callback for when a chime zone goes from closed to open. */ + template void add_on_chime_callback(F &&callback) { + this->chime_callback_.add(std::forward(callback)); + } - /** Add a callback for when a ready state changes - * - * @param callback The callback function - */ - void add_on_ready_callback(std::function &&callback); + /** Add a callback for when a ready state changes. */ + template void add_on_ready_callback(F &&callback) { + this->ready_callback_.add(std::forward(callback)); + } /** A numeric representation of the supported features as per HomeAssistant * diff --git a/esphome/components/button/button.cpp b/esphome/components/button/button.cpp index 8c06cfe59b8..b1c491805e0 100644 --- a/esphome/components/button/button.cpp +++ b/esphome/components/button/button.cpp @@ -20,6 +20,5 @@ void Button::press() { this->press_action(); this->press_callback_.call(); } -void Button::add_on_press_callback(std::function &&callback) { this->press_callback_.add(std::move(callback)); } } // namespace esphome::button diff --git a/esphome/components/button/button.h b/esphome/components/button/button.h index 0f7576a419f..96e9107532b 100644 --- a/esphome/components/button/button.h +++ b/esphome/components/button/button.h @@ -34,7 +34,9 @@ class Button : public EntityBase { * * @param callback The void() callback. */ - void add_on_press_callback(std::function &&callback); + template void add_on_press_callback(F &&callback) { + this->press_callback_.add(std::forward(callback)); + } protected: /** You should implement this virtual method if you want to create your own button. diff --git a/esphome/components/canbus/canbus.h b/esphome/components/canbus/canbus.h index f7b84111bd5..420125e1d34 100644 --- a/esphome/components/canbus/canbus.h +++ b/esphome/components/canbus/canbus.h @@ -91,10 +91,7 @@ class Canbus : public Component { * - rtr If this is a remote transmission request * - data The message data */ - void add_callback( - std::function &data)> callback) { - this->callback_manager_.add(std::move(callback)); - } + template void add_callback(F &&callback) { this->callback_manager_.add(std::forward(callback)); } protected: template friend class CanbusSendAction; diff --git a/esphome/components/climate/climate.cpp b/esphome/components/climate/climate.cpp index 43d25effa33..3f44b986dc0 100644 --- a/esphome/components/climate/climate.cpp +++ b/esphome/components/climate/climate.cpp @@ -356,14 +356,6 @@ ClimateCall &ClimateCall::set_swing_mode(optional swing_mode) return *this; } -void Climate::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} - -void Climate::add_on_control_callback(std::function &&callback) { - this->control_callback_.add(std::move(callback)); -} - // Random 32bit value; If this changes existing restore preferences are invalidated static const uint32_t RESTORE_STATE_VERSION = 0x848EA6ADUL; diff --git a/esphome/components/climate/climate.h b/esphome/components/climate/climate.h index aa9ca91bc2c..e2cb743c0a6 100644 --- a/esphome/components/climate/climate.h +++ b/esphome/components/climate/climate.h @@ -192,7 +192,9 @@ class Climate : public EntityBase { * * @param callback The callback to call. */ - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } /** * Add a callback for the climate device configuration; each time the configuration parameters of a climate device @@ -200,7 +202,9 @@ class Climate : public EntityBase { * * @param callback The callback to call. */ - void add_on_control_callback(std::function &&callback); + template void add_on_control_callback(F &&callback) { + this->control_callback_.add(std::forward(callback)); + } /** Make a climate device control call, this is used to control the climate device, see the ClimateCall description * for more info. diff --git a/esphome/components/cover/cover.cpp b/esphome/components/cover/cover.cpp index 0589aa23796..bb5965d861b 100644 --- a/esphome/components/cover/cover.cpp +++ b/esphome/components/cover/cover.cpp @@ -139,7 +139,6 @@ bool CoverCall::get_stop() const { return this->stop_; } CoverCall Cover::make_call() { return {this}; } -void Cover::add_on_state_callback(std::function &&f) { this->state_callback_.add(std::move(f)); } void Cover::publish_state(bool save) { this->position = clamp(this->position, 0.0f, 1.0f); this->tilt = clamp(this->tilt, 0.0f, 1.0f); diff --git a/esphome/components/cover/cover.h b/esphome/components/cover/cover.h index 8cf9aa092aa..9a75e684871 100644 --- a/esphome/components/cover/cover.h +++ b/esphome/components/cover/cover.h @@ -125,7 +125,7 @@ class Cover : public EntityBase { /// Construct a new cover call used to control the cover. CoverCall make_call(); - void add_on_state_callback(std::function &&f); + template void add_on_state_callback(F &&f) { this->state_callback_.add(std::forward(f)); } /** Publish the current state of the cover. * diff --git a/esphome/components/datetime/datetime_base.h b/esphome/components/datetime/datetime_base.h index 1b0b3d54639..98f23aa7137 100644 --- a/esphome/components/datetime/datetime_base.h +++ b/esphome/components/datetime/datetime_base.h @@ -14,7 +14,9 @@ class DateTimeBase : public EntityBase { public: virtual ESPTime state_as_esptime() const = 0; - void add_on_state_callback(std::function &&callback) { this->state_callback_.add(std::move(callback)); } + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } #ifdef USE_TIME void set_rtc(time::RealTimeClock *rtc) { this->rtc_ = rtc; } diff --git a/esphome/components/dfplayer/dfplayer.h b/esphome/components/dfplayer/dfplayer.h index 03d2230ca68..2c4ee03470d 100644 --- a/esphome/components/dfplayer/dfplayer.h +++ b/esphome/components/dfplayer/dfplayer.h @@ -51,8 +51,8 @@ class DFPlayer : public uart::UARTDevice, public Component { bool is_playing() { return is_playing_; } void dump_config() override; - void add_on_finished_playback_callback(std::function callback) { - this->on_finished_playback_callback_.add(std::move(callback)); + template void add_on_finished_playback_callback(F &&callback) { + this->on_finished_playback_callback_.add(std::forward(callback)); } protected: diff --git a/esphome/components/display_menu_base/menu_item.h b/esphome/components/display_menu_base/menu_item.h index 36de1460310..57d7350b9e7 100644 --- a/esphome/components/display_menu_base/menu_item.h +++ b/esphome/components/display_menu_base/menu_item.h @@ -44,9 +44,9 @@ class MenuItem { MenuItemMenu *get_parent() { return this->parent_; } MenuItemType get_type() const { return this->item_type_; } template void set_text(V val) { this->text_ = val; } - void add_on_enter_callback(std::function &&cb) { this->on_enter_callbacks_.add(std::move(cb)); } - void add_on_leave_callback(std::function &&cb) { this->on_leave_callbacks_.add(std::move(cb)); } - void add_on_value_callback(std::function &&cb) { this->on_value_callbacks_.add(std::move(cb)); } + template void add_on_enter_callback(F &&cb) { this->on_enter_callbacks_.add(std::forward(cb)); } + template void add_on_leave_callback(F &&cb) { this->on_leave_callbacks_.add(std::forward(cb)); } + template void add_on_value_callback(F &&cb) { this->on_value_callbacks_.add(std::forward(cb)); } std::string get_text() const { return const_cast(this)->text_.value(this); } virtual bool get_immediate_edit() const { return false; } @@ -170,8 +170,8 @@ class MenuItemCommand : public MenuItem { class MenuItemCustom : public MenuItemEditable { public: explicit MenuItemCustom() : MenuItemEditable(MENU_ITEM_CUSTOM) {} - void add_on_next_callback(std::function &&cb) { this->on_next_callbacks_.add(std::move(cb)); } - void add_on_prev_callback(std::function &&cb) { this->on_prev_callbacks_.add(std::move(cb)); } + template void add_on_next_callback(F &&cb) { this->on_next_callbacks_.add(std::forward(cb)); } + template void add_on_prev_callback(F &&cb) { this->on_prev_callbacks_.add(std::forward(cb)); } bool has_value() const override { return this->value_getter_.has_value(); } std::string get_value_text() const override; diff --git a/esphome/components/esp32_improv/esp32_improv_component.h b/esphome/components/esp32_improv/esp32_improv_component.h index 8f4cfd79581..41799f23251 100644 --- a/esphome/components/esp32_improv/esp32_improv_component.h +++ b/esphome/components/esp32_improv/esp32_improv_component.h @@ -48,8 +48,8 @@ class ESP32ImprovComponent : public Component, public improv_base::ImprovBase { bool should_start() const { return this->should_start_; } #ifdef USE_ESP32_IMPROV_STATE_CALLBACK - void add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); } #endif #ifdef USE_BINARY_SENSOR diff --git a/esphome/components/event/event.cpp b/esphome/components/event/event.cpp index 667d4218f3c..ec63fd9c3eb 100644 --- a/esphome/components/event/event.cpp +++ b/esphome/components/event/event.cpp @@ -45,9 +45,5 @@ void Event::set_event_types(const std::vector &event_types) { this->last_event_type_ = nullptr; // Reset when types change } -void Event::add_on_event_callback(std::function &&callback) { - this->event_callback_.add(std::move(callback)); -} - } // namespace event } // namespace esphome diff --git a/esphome/components/event/event.h b/esphome/components/event/event.h index 5b6a94b47c0..ebbee0bfe23 100644 --- a/esphome/components/event/event.h +++ b/esphome/components/event/event.h @@ -66,7 +66,9 @@ class Event : public EntityBase { /// Check if an event has been triggered. bool has_event() const { return this->last_event_type_ != nullptr; } - void add_on_event_callback(std::function &&callback); + template void add_on_event_callback(F &&callback) { + this->event_callback_.add(std::forward(callback)); + } protected: LazyCallbackManager event_callback_; diff --git a/esphome/components/ezo/ezo.h b/esphome/components/ezo/ezo.h index f1a2802cbd7..d80869fbd9a 100644 --- a/esphome/components/ezo/ezo.h +++ b/esphome/components/ezo/ezo.h @@ -44,8 +44,8 @@ class EZOSensor : public sensor::Sensor, public PollingComponent, public i2c::I2 // Device Information void get_device_information(); - void add_device_infomation_callback(std::function &&callback) { - this->device_infomation_callback_.add(std::move(callback)); + template void add_device_infomation_callback(F &&callback) { + this->device_infomation_callback_.add(std::forward(callback)); } // Sleep @@ -56,15 +56,13 @@ class EZOSensor : public sensor::Sensor, public PollingComponent, public i2c::I2 // Slope void get_slope(); - void add_slope_callback(std::function &&callback) { - this->slope_callback_.add(std::move(callback)); - } + template void add_slope_callback(F &&callback) { this->slope_callback_.add(std::forward(callback)); } // T void get_t(); void set_t(float value); void set_tempcomp_value(float temp); // For backwards compatibility - void add_t_callback(std::function &&callback) { this->t_callback_.add(std::move(callback)); } + template void add_t_callback(F &&callback) { this->t_callback_.add(std::forward(callback)); } // Calibration void get_calibration(); @@ -73,20 +71,18 @@ class EZOSensor : public sensor::Sensor, public PollingComponent, public i2c::I2 void set_calibration_point_high(float value); void set_calibration_generic(float value); void clear_calibration(); - void add_calibration_callback(std::function &&callback) { - this->calibration_callback_.add(std::move(callback)); + template void add_calibration_callback(F &&callback) { + this->calibration_callback_.add(std::forward(callback)); } // LED void get_led_state(); void set_led_state(bool on); - void add_led_state_callback(std::function &&callback) { this->led_callback_.add(std::move(callback)); } + template void add_led_state_callback(F &&callback) { this->led_callback_.add(std::forward(callback)); } // Custom void send_custom(const std::string &to_send); - void add_custom_callback(std::function &&callback) { - this->custom_callback_.add(std::move(callback)); - } + template void add_custom_callback(F &&callback) { this->custom_callback_.add(std::forward(callback)); } protected: std::deque> commands_; diff --git a/esphome/components/factory_reset/factory_reset.h b/esphome/components/factory_reset/factory_reset.h index 990bb2edb66..34f89d73b60 100644 --- a/esphome/components/factory_reset/factory_reset.h +++ b/esphome/components/factory_reset/factory_reset.h @@ -17,8 +17,8 @@ class FactoryResetComponent : public Component { void dump_config() override; void setup() override; - void add_increment_callback(std::function &&callback) { - this->increment_callback_.add(std::move(callback)); + template void add_increment_callback(F &&callback) { + this->increment_callback_.add(std::forward(callback)); } protected: diff --git a/esphome/components/fan/fan.cpp b/esphome/components/fan/fan.cpp index c1e0a3dc2e1..97336e17b58 100644 --- a/esphome/components/fan/fan.cpp +++ b/esphome/components/fan/fan.cpp @@ -193,7 +193,6 @@ void Fan::apply_preset_mode_(const FanCall &call) { } } -void Fan::add_on_state_callback(std::function &&callback) { this->state_callback_.add(std::move(callback)); } void Fan::publish_state() { auto traits = this->get_traits(); diff --git a/esphome/components/fan/fan.h b/esphome/components/fan/fan.h index 2caf3a712a2..e7b3681e32e 100644 --- a/esphome/components/fan/fan.h +++ b/esphome/components/fan/fan.h @@ -122,7 +122,9 @@ class Fan : public EntityBase { FanCall make_call(); /// Register a callback that will be called each time the state changes. - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } void publish_state(); diff --git a/esphome/components/fingerprint_grow/fingerprint_grow.h b/esphome/components/fingerprint_grow/fingerprint_grow.h index db9d5ce564f..63839534f64 100644 --- a/esphome/components/fingerprint_grow/fingerprint_grow.h +++ b/esphome/components/fingerprint_grow/fingerprint_grow.h @@ -127,30 +127,30 @@ class FingerprintGrowComponent : public PollingComponent, public uart::UARTDevic void set_enrolling_binary_sensor(binary_sensor::BinarySensor *enrolling_binary_sensor) { this->enrolling_binary_sensor_ = enrolling_binary_sensor; } - void add_on_finger_scan_start_callback(std::function callback) { - this->finger_scan_start_callback_.add(std::move(callback)); + template void add_on_finger_scan_start_callback(F &&callback) { + this->finger_scan_start_callback_.add(std::forward(callback)); } - void add_on_finger_scan_matched_callback(std::function callback) { - this->finger_scan_matched_callback_.add(std::move(callback)); + template void add_on_finger_scan_matched_callback(F &&callback) { + this->finger_scan_matched_callback_.add(std::forward(callback)); } - void add_on_finger_scan_unmatched_callback(std::function callback) { - this->finger_scan_unmatched_callback_.add(std::move(callback)); + template void add_on_finger_scan_unmatched_callback(F &&callback) { + this->finger_scan_unmatched_callback_.add(std::forward(callback)); } - void add_on_finger_scan_misplaced_callback(std::function callback) { - this->finger_scan_misplaced_callback_.add(std::move(callback)); + template void add_on_finger_scan_misplaced_callback(F &&callback) { + this->finger_scan_misplaced_callback_.add(std::forward(callback)); } - void add_on_finger_scan_invalid_callback(std::function callback) { - this->finger_scan_invalid_callback_.add(std::move(callback)); + template void add_on_finger_scan_invalid_callback(F &&callback) { + this->finger_scan_invalid_callback_.add(std::forward(callback)); } - void add_on_enrollment_scan_callback(std::function callback) { - this->enrollment_scan_callback_.add(std::move(callback)); + template void add_on_enrollment_scan_callback(F &&callback) { + this->enrollment_scan_callback_.add(std::forward(callback)); } - void add_on_enrollment_done_callback(std::function callback) { - this->enrollment_done_callback_.add(std::move(callback)); + template void add_on_enrollment_done_callback(F &&callback) { + this->enrollment_done_callback_.add(std::forward(callback)); } - void add_on_enrollment_failed_callback(std::function callback) { - this->enrollment_failed_callback_.add(std::move(callback)); + template void add_on_enrollment_failed_callback(F &&callback) { + this->enrollment_failed_callback_.add(std::forward(callback)); } void enroll_fingerprint(uint16_t finger_id, uint8_t num_buffers); diff --git a/esphome/components/graphical_display_menu/graphical_display_menu.h b/esphome/components/graphical_display_menu/graphical_display_menu.h index 96f2bd79fd5..007889557dd 100644 --- a/esphome/components/graphical_display_menu/graphical_display_menu.h +++ b/esphome/components/graphical_display_menu/graphical_display_menu.h @@ -44,7 +44,7 @@ class GraphicalDisplayMenu : public display_menu_base::DisplayMenuComponent { void set_foreground_color(Color foreground_color); void set_background_color(Color background_color); - void add_on_redraw_callback(std::function &&cb) { this->on_redraw_callbacks_.add(std::move(cb)); } + template void add_on_redraw_callback(F &&cb) { this->on_redraw_callbacks_.add(std::forward(cb)); } void draw(display::Display *display, const display::Rect *bounds); diff --git a/esphome/components/haier/haier_base.cpp b/esphome/components/haier/haier_base.cpp index 1882aa439ef..35eaf36d329 100644 --- a/esphome/components/haier/haier_base.cpp +++ b/esphome/components/haier/haier_base.cpp @@ -197,10 +197,6 @@ void HaierClimateBase::send_custom_command(const haier_protocol::HaierMessage &m this->action_request_ = PendingAction({ActionRequest::SEND_CUSTOM_COMMAND, message}); } -void HaierClimateBase::add_status_message_callback(std::function &&callback) { - this->status_message_callback_.add(std::move(callback)); -} - haier_protocol::HandlerError HaierClimateBase::answer_preprocess_( haier_protocol::FrameType request_message_type, haier_protocol::FrameType expected_request_message_type, haier_protocol::FrameType answer_message_type, haier_protocol::FrameType expected_answer_message_type, diff --git a/esphome/components/haier/haier_base.h b/esphome/components/haier/haier_base.h index e24217bfd9d..87aa1d65eff 100644 --- a/esphome/components/haier/haier_base.h +++ b/esphome/components/haier/haier_base.h @@ -74,7 +74,9 @@ class HaierClimateBase : public esphome::Component, void set_answer_timeout(uint32_t timeout); void set_send_wifi(bool send_wifi); void send_custom_command(const haier_protocol::HaierMessage &message); - void add_status_message_callback(std::function &&callback); + template void add_status_message_callback(F &&callback) { + this->status_message_callback_.add(std::forward(callback)); + } protected: enum class ProtocolPhases { diff --git a/esphome/components/haier/hon_climate.cpp b/esphome/components/haier/hon_climate.cpp index b8889ef2bdc..b7888f7976e 100644 --- a/esphome/components/haier/hon_climate.cpp +++ b/esphome/components/haier/hon_climate.cpp @@ -114,14 +114,6 @@ void HonClimate::start_steri_cleaning() { } } -void HonClimate::add_alarm_start_callback(std::function &&callback) { - this->alarm_start_callback_.add(std::move(callback)); -} - -void HonClimate::add_alarm_end_callback(std::function &&callback) { - this->alarm_end_callback_.add(std::move(callback)); -} - haier_protocol::HandlerError HonClimate::get_device_version_answer_handler_(haier_protocol::FrameType request_type, haier_protocol::FrameType message_type, const uint8_t *data, size_t data_size) { diff --git a/esphome/components/haier/hon_climate.h b/esphome/components/haier/hon_climate.h index 9bddac3f923..7c48a3748b8 100644 --- a/esphome/components/haier/hon_climate.h +++ b/esphome/components/haier/hon_climate.h @@ -124,8 +124,12 @@ class HonClimate : public HaierClimateBase { void set_extra_sensors_packet_bytes_size(size_t size) { this->extra_sensors_packet_bytes_ = size; }; void set_status_message_header_size(size_t size) { this->status_message_header_size_ = size; }; void set_control_method(HonControlMethod method) { this->control_method_ = method; }; - void add_alarm_start_callback(std::function &&callback); - void add_alarm_end_callback(std::function &&callback); + template void add_alarm_start_callback(F &&callback) { + this->alarm_start_callback_.add(std::forward(callback)); + } + template void add_alarm_end_callback(F &&callback) { + this->alarm_end_callback_.add(std::forward(callback)); + } float get_active_alarm_count() const { return this->active_alarm_count_; } protected: diff --git a/esphome/components/hlk_fm22x/hlk_fm22x.h b/esphome/components/hlk_fm22x/hlk_fm22x.h index 0ea4636281c..d897d51881b 100644 --- a/esphome/components/hlk_fm22x/hlk_fm22x.h +++ b/esphome/components/hlk_fm22x/hlk_fm22x.h @@ -91,24 +91,23 @@ class HlkFm22xComponent : public PollingComponent, public uart::UARTDevice { void set_version_text_sensor(text_sensor::TextSensor *version_text_sensor) { this->version_text_sensor_ = version_text_sensor; } - void add_on_face_scan_matched_callback(std::function callback) { - this->face_scan_matched_callback_.add(std::move(callback)); + template void add_on_face_scan_matched_callback(F &&callback) { + this->face_scan_matched_callback_.add(std::forward(callback)); } - void add_on_face_scan_unmatched_callback(std::function callback) { - this->face_scan_unmatched_callback_.add(std::move(callback)); + template void add_on_face_scan_unmatched_callback(F &&callback) { + this->face_scan_unmatched_callback_.add(std::forward(callback)); } - void add_on_face_scan_invalid_callback(std::function callback) { - this->face_scan_invalid_callback_.add(std::move(callback)); + template void add_on_face_scan_invalid_callback(F &&callback) { + this->face_scan_invalid_callback_.add(std::forward(callback)); } - void add_on_face_info_callback( - std::function callback) { - this->face_info_callback_.add(std::move(callback)); + template void add_on_face_info_callback(F &&callback) { + this->face_info_callback_.add(std::forward(callback)); } - void add_on_enrollment_done_callback(std::function callback) { - this->enrollment_done_callback_.add(std::move(callback)); + template void add_on_enrollment_done_callback(F &&callback) { + this->enrollment_done_callback_.add(std::forward(callback)); } - void add_on_enrollment_failed_callback(std::function callback) { - this->enrollment_failed_callback_.add(std::move(callback)); + template void add_on_enrollment_failed_callback(F &&callback) { + this->enrollment_failed_callback_.add(std::forward(callback)); } void enroll_face(const std::string &name, HlkFm22xFaceDirection direction); diff --git a/esphome/components/key_collector/key_collector.h b/esphome/components/key_collector/key_collector.h index 8e30c333df7..014e2034bd3 100644 --- a/esphome/components/key_collector/key_collector.h +++ b/esphome/components/key_collector/key_collector.h @@ -21,14 +21,14 @@ class KeyCollector : public Component { void set_back_keys(std::string back_keys) { this->back_keys_ = std::move(back_keys); }; void set_clear_keys(std::string clear_keys) { this->clear_keys_ = std::move(clear_keys); }; void set_allowed_keys(std::string allowed_keys) { this->allowed_keys_ = std::move(allowed_keys); }; - void add_on_progress_callback(std::function &&callback) { - this->progress_callbacks_.add(std::move(callback)); + template void add_on_progress_callback(F &&callback) { + this->progress_callbacks_.add(std::forward(callback)); } - void add_on_result_callback(std::function &&callback) { - this->result_callbacks_.add(std::move(callback)); + template void add_on_result_callback(F &&callback) { + this->result_callbacks_.add(std::forward(callback)); } - void add_on_timeout_callback(std::function &&callback) { - this->timeout_callbacks_.add(std::move(callback)); + template void add_on_timeout_callback(F &&callback) { + this->timeout_callbacks_.add(std::forward(callback)); } void set_timeout(int timeout) { this->timeout_ = timeout; }; void set_enabled(bool enabled); diff --git a/esphome/components/key_provider/key_provider.cpp b/esphome/components/key_provider/key_provider.cpp index 5a0e24b13fa..64b0729d4d1 100644 --- a/esphome/components/key_provider/key_provider.cpp +++ b/esphome/components/key_provider/key_provider.cpp @@ -3,10 +3,6 @@ namespace esphome { namespace key_provider { -void KeyProvider::add_on_key_callback(std::function &&callback) { - this->key_callback_.add(std::move(callback)); -} - void KeyProvider::send_key_(uint8_t key) { this->key_callback_.call(key); } } // namespace key_provider diff --git a/esphome/components/key_provider/key_provider.h b/esphome/components/key_provider/key_provider.h index 272d3eecadc..97403427512 100644 --- a/esphome/components/key_provider/key_provider.h +++ b/esphome/components/key_provider/key_provider.h @@ -9,7 +9,7 @@ namespace key_provider { /// interface for components that provide keypresses class KeyProvider { public: - void add_on_key_callback(std::function &&callback); + template void add_on_key_callback(F &&callback) { this->key_callback_.add(std::forward(callback)); } protected: void send_key_(uint8_t key); diff --git a/esphome/components/ld2450/ld2450.cpp b/esphome/components/ld2450/ld2450.cpp index f9701cbdf66..0a1147c9240 100644 --- a/esphome/components/ld2450/ld2450.cpp +++ b/esphome/components/ld2450/ld2450.cpp @@ -407,10 +407,6 @@ void LD2450Component::restart_and_read_all_info() { this->set_timeout(1500, [this]() { this->read_all_info(); }); } -void LD2450Component::add_on_data_callback(std::function &&callback) { - this->data_callback_.add(std::move(callback)); -} - // Send command with values to LD2450 void LD2450Component::send_command_(uint8_t command, const uint8_t *command_value, uint8_t command_value_len) { ESP_LOGV(TAG, "Sending COMMAND %02X", command); diff --git a/esphome/components/ld2450/ld2450.h b/esphome/components/ld2450/ld2450.h index 9409dfc21df..e774dd9c756 100644 --- a/esphome/components/ld2450/ld2450.h +++ b/esphome/components/ld2450/ld2450.h @@ -145,7 +145,7 @@ class LD2450Component : public Component, public uart::UARTDevice { int32_t zone3_y1, int32_t zone3_x2, int32_t zone3_y2); /// Add a callback that will be called after each successfully processed periodic data frame. - void add_on_data_callback(std::function &&callback); + template void add_on_data_callback(F &&callback) { this->data_callback_.add(std::forward(callback)); } protected: void send_command_(uint8_t command_str, const uint8_t *command_value, uint8_t command_value_len); diff --git a/esphome/components/lock/lock.cpp b/esphome/components/lock/lock.cpp index 939c84720bf..4aa636e998c 100644 --- a/esphome/components/lock/lock.cpp +++ b/esphome/components/lock/lock.cpp @@ -48,8 +48,6 @@ void Lock::publish_state(LockState state) { #endif } -void Lock::add_on_state_callback(std::function &&callback) { this->state_callback_.add(std::move(callback)); } - void LockCall::perform() { ESP_LOGD(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); this->validate_(); diff --git a/esphome/components/lock/lock.h b/esphome/components/lock/lock.h index bebd296eacb..707431d5433 100644 --- a/esphome/components/lock/lock.h +++ b/esphome/components/lock/lock.h @@ -150,7 +150,9 @@ class Lock : public EntityBase { * * @param callback The void(bool) callback. */ - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } protected: friend LockCall; diff --git a/esphome/components/ltr501/ltr501.h b/esphome/components/ltr501/ltr501.h index d9a53c9bd46..2bd838a0fe2 100644 --- a/esphome/components/ltr501/ltr501.h +++ b/esphome/components/ltr501/ltr501.h @@ -160,12 +160,12 @@ class LTRAlsPs501Component : public PollingComponent, public i2c::I2CDevice { CallbackManager on_ps_high_trigger_callback_; CallbackManager on_ps_low_trigger_callback_; - void add_on_ps_high_trigger_callback_(std::function callback) { - this->on_ps_high_trigger_callback_.add(std::move(callback)); + template void add_on_ps_high_trigger_callback_(F &&callback) { + this->on_ps_high_trigger_callback_.add(std::forward(callback)); } - void add_on_ps_low_trigger_callback_(std::function callback) { - this->on_ps_low_trigger_callback_.add(std::move(callback)); + template void add_on_ps_low_trigger_callback_(F &&callback) { + this->on_ps_low_trigger_callback_.add(std::forward(callback)); } }; diff --git a/esphome/components/ltr_als_ps/ltr_als_ps.h b/esphome/components/ltr_als_ps/ltr_als_ps.h index 3ab2cea074f..2e24a14283d 100644 --- a/esphome/components/ltr_als_ps/ltr_als_ps.h +++ b/esphome/components/ltr_als_ps/ltr_als_ps.h @@ -160,12 +160,12 @@ class LTRAlsPsComponent : public PollingComponent, public i2c::I2CDevice { CallbackManager on_ps_high_trigger_callback_; CallbackManager on_ps_low_trigger_callback_; - void add_on_ps_high_trigger_callback_(std::function callback) { - this->on_ps_high_trigger_callback_.add(std::move(callback)); + template void add_on_ps_high_trigger_callback_(F &&callback) { + this->on_ps_high_trigger_callback_.add(std::forward(callback)); } - void add_on_ps_low_trigger_callback_(std::function callback) { - this->on_ps_low_trigger_callback_.add(std::move(callback)); + template void add_on_ps_low_trigger_callback_(F &&callback) { + this->on_ps_low_trigger_callback_.add(std::forward(callback)); } }; diff --git a/esphome/components/lvgl/lvgl_esphome.h b/esphome/components/lvgl/lvgl_esphome.h index 9c82f3646bc..aa8dd2fba52 100644 --- a/esphome/components/lvgl/lvgl_esphome.h +++ b/esphome/components/lvgl/lvgl_esphome.h @@ -158,9 +158,7 @@ class LvglComponent : public PollingComponent { void setup() override; void update() override; void loop() override; - void add_on_idle_callback(std::function &&callback) { - this->idle_callbacks_.add(std::move(callback)); - } + template void add_on_idle_callback(F &&callback) { this->idle_callbacks_.add(std::forward(callback)); } static void monitor_cb(lv_disp_drv_t *disp_drv, uint32_t time, uint32_t px); static void render_start_cb(lv_disp_drv_t *disp_drv); diff --git a/esphome/components/media_player/media_player.cpp b/esphome/components/media_player/media_player.cpp index a53d598b0fe..70086089ff2 100644 --- a/esphome/components/media_player/media_player.cpp +++ b/esphome/components/media_player/media_player.cpp @@ -198,10 +198,6 @@ MediaPlayerCall &MediaPlayerCall::set_announcement(bool announce) { return *this; } -void MediaPlayer::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} - void MediaPlayer::publish_state() { this->state_callback_.call(); #if defined(USE_MEDIA_PLAYER) && defined(USE_CONTROLLER_REGISTRY) diff --git a/esphome/components/media_player/media_player.h b/esphome/components/media_player/media_player.h index 35097477181..26eca469e7f 100644 --- a/esphome/components/media_player/media_player.h +++ b/esphome/components/media_player/media_player.h @@ -155,7 +155,9 @@ class MediaPlayer : public EntityBase { void publish_state(); - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } virtual bool is_muted() const { return false; } diff --git a/esphome/components/microphone/microphone.cpp b/esphome/components/microphone/microphone.cpp deleted file mode 100644 index 0fbb393fd20..00000000000 --- a/esphome/components/microphone/microphone.cpp +++ /dev/null @@ -1,19 +0,0 @@ -#include "microphone.h" - -namespace esphome { -namespace microphone { - -void Microphone::add_data_callback(std::function &)> &&data_callback) { - std::function &)> mute_handled_callback = - [this, data_callback](const std::vector &data) { - if (this->mute_state_) { - data_callback(std::vector(data.size(), 0)); - } else { - data_callback(data); - }; - }; - this->data_callbacks_.add(std::move(mute_handled_callback)); -} - -} // namespace microphone -} // namespace esphome diff --git a/esphome/components/microphone/microphone.h b/esphome/components/microphone/microphone.h index fcf98224581..50ce1a72818 100644 --- a/esphome/components/microphone/microphone.h +++ b/esphome/components/microphone/microphone.h @@ -4,7 +4,6 @@ #include #include -#include #include #include "esphome/core/helpers.h" @@ -22,7 +21,15 @@ class Microphone { public: virtual void start() = 0; virtual void stop() = 0; - void add_data_callback(std::function &)> &&data_callback); + template void add_data_callback(F &&data_callback) { + this->data_callbacks_.add([this, data_callback](const std::vector &data) { + if (this->mute_state_) { + data_callback(std::vector(data.size(), 0)); + } else { + data_callback(data); + } + }); + } bool is_running() const { return this->state_ == STATE_RUNNING; } bool is_stopped() const { return this->state_ == STATE_STOPPED; } diff --git a/esphome/components/microphone/microphone_source.cpp b/esphome/components/microphone/microphone_source.cpp index 00efcf22a14..fb4ebc4a042 100644 --- a/esphome/components/microphone/microphone_source.cpp +++ b/esphome/components/microphone/microphone_source.cpp @@ -6,24 +6,6 @@ namespace microphone { static const int32_t Q25_MAX_VALUE = (1 << 25) - 1; static const int32_t Q25_MIN_VALUE = ~Q25_MAX_VALUE; -void MicrophoneSource::add_data_callback(std::function &)> &&data_callback) { - std::function &)> filtered_callback = - [this, data_callback](const std::vector &data) { - if (this->enabled_ || this->passive_) { - if (this->processed_samples_.use_count() == 0) { - // Create vector if its unused - this->processed_samples_ = std::make_shared>(); - } - - // Take temporary ownership of samples vector to avoid deallaction before the callback finishes - std::shared_ptr> output_samples = this->processed_samples_; - this->process_audio_(data, *output_samples); - data_callback(*output_samples); - } - }; - this->mic_->add_data_callback(std::move(filtered_callback)); -} - audio::AudioStreamInfo MicrophoneSource::get_audio_stream_info() { return audio::AudioStreamInfo(this->bits_per_sample_, this->channels_.count(), this->mic_->get_audio_stream_info().get_sample_rate()); diff --git a/esphome/components/microphone/microphone_source.h b/esphome/components/microphone/microphone_source.h index 1e81a284b67..5c8053e502e 100644 --- a/esphome/components/microphone/microphone_source.h +++ b/esphome/components/microphone/microphone_source.h @@ -7,7 +7,6 @@ #include #include #include -#include #include namespace esphome { @@ -47,7 +46,21 @@ class MicrophoneSource { /// @param channel 0-indexed channel number to enable void add_channel(uint8_t channel) { this->channels_.set(channel); } - void add_data_callback(std::function &)> &&data_callback); + template void add_data_callback(F &&data_callback) { + this->mic_->add_data_callback([this, data_callback](const std::vector &data) { + if (this->enabled_ || this->passive_) { + if (this->processed_samples_.use_count() == 0) { + // Create vector if its unused + this->processed_samples_ = std::make_shared>(); + } + + // Take temporary ownership of samples vector to avoid deallocation before the callback finishes + std::shared_ptr> output_samples = this->processed_samples_; + this->process_audio_(data, *output_samples); + data_callback(*output_samples); + } + }); + } void set_gain_factor(int32_t gain_factor) { this->gain_factor_ = clamp(gain_factor, 1, MAX_GAIN_FACTOR); } int32_t get_gain_factor() { return this->gain_factor_; } diff --git a/esphome/components/modbus_controller/modbus_controller.cpp b/esphome/components/modbus_controller/modbus_controller.cpp index f77f51a20df..ea6ba9d0859 100644 --- a/esphome/components/modbus_controller/modbus_controller.cpp +++ b/esphome/components/modbus_controller/modbus_controller.cpp @@ -837,17 +837,5 @@ int64_t payload_to_number(const std::vector &data, SensorValueType sens return value; } -void ModbusController::add_on_command_sent_callback(std::function &&callback) { - this->command_sent_callback_.add(std::move(callback)); -} - -void ModbusController::add_on_online_callback(std::function &&callback) { - this->online_callback_.add(std::move(callback)); -} - -void ModbusController::add_on_offline_callback(std::function &&callback) { - this->offline_callback_.add(std::move(callback)); -} - } // namespace modbus_controller } // namespace esphome diff --git a/esphome/components/modbus_controller/modbus_controller.h b/esphome/components/modbus_controller/modbus_controller.h index bd3d4d705ec..78c3b959654 100644 --- a/esphome/components/modbus_controller/modbus_controller.h +++ b/esphome/components/modbus_controller/modbus_controller.h @@ -508,11 +508,17 @@ class ModbusController : public PollingComponent, public modbus::ModbusDevice { /// get if the module is offline, didn't respond the last command bool get_module_offline() { return module_offline_; } /// Set callback for commands - void add_on_command_sent_callback(std::function &&callback); + template void add_on_command_sent_callback(F &&callback) { + this->command_sent_callback_.add(std::forward(callback)); + } /// Set callback for online changes - void add_on_online_callback(std::function &&callback); + template void add_on_online_callback(F &&callback) { + this->online_callback_.add(std::forward(callback)); + } /// Set callback for offline changes - void add_on_offline_callback(std::function &&callback); + template void add_on_offline_callback(F &&callback) { + this->offline_callback_.add(std::forward(callback)); + } /// called by esphome generated code to set the max_cmd_retries. void set_max_cmd_retries(uint8_t max_cmd_retries) { this->max_cmd_retries_ = max_cmd_retries; } /// get how many times a command will be (re)sent if no response is received diff --git a/esphome/components/nextion/nextion.cpp b/esphome/components/nextion/nextion.cpp index 01ceb3d765e..85da6af48aa 100644 --- a/esphome/components/nextion/nextion.cpp +++ b/esphome/components/nextion/nextion.cpp @@ -214,30 +214,6 @@ void Nextion::update() { } } -void Nextion::add_sleep_state_callback(std::function &&callback) { - this->sleep_callback_.add(std::move(callback)); -} - -void Nextion::add_wake_state_callback(std::function &&callback) { - this->wake_callback_.add(std::move(callback)); -} - -void Nextion::add_setup_state_callback(std::function &&callback) { - this->setup_callback_.add(std::move(callback)); -} - -void Nextion::add_new_page_callback(std::function &&callback) { - this->page_callback_.add(std::move(callback)); -} - -void Nextion::add_touch_event_callback(std::function &&callback) { - this->touch_callback_.add(std::move(callback)); -} - -void Nextion::add_buffer_overflow_event_callback(std::function &&callback) { - this->buffer_overflow_callback_.add(std::move(callback)); -} - void Nextion::update_all_components() { if ((!this->is_setup() && !this->connection_state_.ignore_is_setup_) || this->is_sleeping()) return; diff --git a/esphome/components/nextion/nextion.h b/esphome/components/nextion/nextion.h index 7999e3c4e3e..2842e57ce83 100644 --- a/esphome/components/nextion/nextion.h +++ b/esphome/components/nextion/nextion.h @@ -1138,37 +1138,47 @@ class Nextion : public NextionBase, public PollingComponent, public uart::UARTDe * * @param callback The void() callback. */ - void add_sleep_state_callback(std::function &&callback); + template void add_sleep_state_callback(F &&callback) { + this->sleep_callback_.add(std::forward(callback)); + } /** Add a callback to be notified of wake state changes. * * @param callback The void() callback. */ - void add_wake_state_callback(std::function &&callback); + template void add_wake_state_callback(F &&callback) { + this->wake_callback_.add(std::forward(callback)); + } /** Add a callback to be notified when the nextion completes its initialize setup. * * @param callback The void() callback. */ - void add_setup_state_callback(std::function &&callback); + template void add_setup_state_callback(F &&callback) { + this->setup_callback_.add(std::forward(callback)); + } /** Add a callback to be notified when the nextion changes pages. * * @param callback The void(std::string) callback. */ - void add_new_page_callback(std::function &&callback); + template void add_new_page_callback(F &&callback) { this->page_callback_.add(std::forward(callback)); } /** Add a callback to be notified when Nextion has a touch event. * * @param callback The void() callback. */ - void add_touch_event_callback(std::function &&callback); + template void add_touch_event_callback(F &&callback) { + this->touch_callback_.add(std::forward(callback)); + } /** Add a callback to be notified when the nextion reports a buffer overflow. * * @param callback The void() callback. */ - void add_buffer_overflow_event_callback(std::function &&callback); + template void add_buffer_overflow_event_callback(F &&callback) { + this->buffer_overflow_callback_.add(std::forward(callback)); + } void update_all_components(); diff --git a/esphome/components/number/number.cpp b/esphome/components/number/number.cpp index c0653c3b304..fb5d6e9f28c 100644 --- a/esphome/components/number/number.cpp +++ b/esphome/components/number/number.cpp @@ -29,8 +29,4 @@ void Number::publish_state(float state) { #endif } -void Number::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} - } // namespace esphome::number diff --git a/esphome/components/number/number.h b/esphome/components/number/number.h index 0425714702f..579d488cf06 100644 --- a/esphome/components/number/number.h +++ b/esphome/components/number/number.h @@ -34,7 +34,9 @@ class Number : public EntityBase { NumberCall make_call() { return NumberCall(this); } - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } NumberTraits traits; diff --git a/esphome/components/online_image/online_image.cpp b/esphome/components/online_image/online_image.cpp index 22bf6a3056f..24926aa4dcd 100644 --- a/esphome/components/online_image/online_image.cpp +++ b/esphome/components/online_image/online_image.cpp @@ -228,14 +228,6 @@ void OnlineImage::end_connection_() { this->disable_loop(); } -void OnlineImage::add_on_finished_callback(std::function &&callback) { - this->download_finished_callback_.add(std::move(callback)); -} - -void OnlineImage::add_on_error_callback(std::function &&callback) { - this->download_error_callback_.add(std::move(callback)); -} - void OnlineImage::release() { // Clear cache headers this->etag_ = ""; diff --git a/esphome/components/online_image/online_image.h b/esphome/components/online_image/online_image.h index 12c25645260..3a348cbb07a 100644 --- a/esphome/components/online_image/online_image.h +++ b/esphome/components/online_image/online_image.h @@ -65,8 +65,12 @@ class OnlineImage : public PollingComponent, */ void release(); - void add_on_finished_callback(std::function &&callback); - void add_on_error_callback(std::function &&callback); + template void add_on_finished_callback(F &&callback) { + this->download_finished_callback_.add(std::forward(callback)); + } + template void add_on_error_callback(F &&callback) { + this->download_error_callback_.add(std::forward(callback)); + } protected: bool validate_url_(const std::string &url); diff --git a/esphome/components/opentherm/hub.h b/esphome/components/opentherm/hub.h index ee0cfd104d1..960e23d6dd3 100644 --- a/esphome/components/opentherm/hub.h +++ b/esphome/components/opentherm/hub.h @@ -160,11 +160,11 @@ class OpenthermHub : public Component { void set_dhw_block(bool value) { this->dhw_block = value; } void set_sync_mode(bool sync_mode) { this->sync_mode_ = sync_mode; } - void add_on_before_send_callback(std::function &&callback) { - this->before_send_callback_.add(std::move(callback)); + template void add_on_before_send_callback(F &&callback) { + this->before_send_callback_.add(std::forward(callback)); } - void add_on_before_process_response_callback(std::function &&callback) { - this->before_process_response_callback_.add(std::move(callback)); + template void add_on_before_process_response_callback(F &&callback) { + this->before_process_response_callback_.add(std::forward(callback)); } float get_setup_priority() const override { return setup_priority::HARDWARE; } diff --git a/esphome/components/pid/pid_climate.h b/esphome/components/pid/pid_climate.h index 3708c29ff1b..479a0e48ee4 100644 --- a/esphome/components/pid/pid_climate.h +++ b/esphome/components/pid/pid_climate.h @@ -72,8 +72,8 @@ class PIDClimate : public climate::Climate, public Component { // float get_deadband() const { return controller_.deadband; } // float get_proportional_deadband_multiplier() const { return controller_.proportional_deadband_multiplier; } - void add_on_pid_computed_callback(std::function &&callback) { - pid_computed_callback_.add(std::move(callback)); + template void add_on_pid_computed_callback(F &&callback) { + this->pid_computed_callback_.add(std::forward(callback)); } void set_default_target_temperature(float default_target_temperature) { default_target_temperature_ = default_target_temperature; diff --git a/esphome/components/pn532/pn532.h b/esphome/components/pn532/pn532.h index e57ecd81046..1f6a6b3bc3f 100644 --- a/esphome/components/pn532/pn532.h +++ b/esphome/components/pn532/pn532.h @@ -43,8 +43,8 @@ class PN532 : public PollingComponent { void register_ontag_trigger(nfc::NfcOnTagTrigger *trig) { this->triggers_ontag_.push_back(trig); } void register_ontagremoved_trigger(nfc::NfcOnTagTrigger *trig) { this->triggers_ontagremoved_.push_back(trig); } - void add_on_finished_write_callback(std::function callback) { - this->on_finished_write_callback_.add(std::move(callback)); + template void add_on_finished_write_callback(F &&callback) { + this->on_finished_write_callback_.add(std::forward(callback)); } bool is_writing() { return this->next_task_ != READ; }; diff --git a/esphome/components/pn7150/pn7150.h b/esphome/components/pn7150/pn7150.h index c5dd2838325..a468d80943e 100644 --- a/esphome/components/pn7150/pn7150.h +++ b/esphome/components/pn7150/pn7150.h @@ -167,12 +167,12 @@ class PN7150 : public nfc::Nfcc, public Component { void register_ontag_trigger(nfc::NfcOnTagTrigger *trig) { this->triggers_ontag_.push_back(trig); } void register_ontagremoved_trigger(nfc::NfcOnTagTrigger *trig) { this->triggers_ontagremoved_.push_back(trig); } - void add_on_emulated_tag_scan_callback(std::function callback) { - this->on_emulated_tag_scan_callback_.add(std::move(callback)); + template void add_on_emulated_tag_scan_callback(F &&callback) { + this->on_emulated_tag_scan_callback_.add(std::forward(callback)); } - void add_on_finished_write_callback(std::function callback) { - this->on_finished_write_callback_.add(std::move(callback)); + template void add_on_finished_write_callback(F &&callback) { + this->on_finished_write_callback_.add(std::forward(callback)); } bool is_writing() { return this->next_task_ != EP_READ; }; diff --git a/esphome/components/pn7160/pn7160.h b/esphome/components/pn7160/pn7160.h index 77ab49399c5..44f7eb07965 100644 --- a/esphome/components/pn7160/pn7160.h +++ b/esphome/components/pn7160/pn7160.h @@ -184,12 +184,12 @@ class PN7160 : public nfc::Nfcc, public Component { void register_ontag_trigger(nfc::NfcOnTagTrigger *trig) { this->triggers_ontag_.push_back(trig); } void register_ontagremoved_trigger(nfc::NfcOnTagTrigger *trig) { this->triggers_ontagremoved_.push_back(trig); } - void add_on_emulated_tag_scan_callback(std::function callback) { - this->on_emulated_tag_scan_callback_.add(std::move(callback)); + template void add_on_emulated_tag_scan_callback(F &&callback) { + this->on_emulated_tag_scan_callback_.add(std::forward(callback)); } - void add_on_finished_write_callback(std::function callback) { - this->on_finished_write_callback_.add(std::move(callback)); + template void add_on_finished_write_callback(F &&callback) { + this->on_finished_write_callback_.add(std::forward(callback)); } bool is_writing() { return this->next_task_ != EP_READ; }; diff --git a/esphome/components/rf_bridge/rf_bridge.h b/esphome/components/rf_bridge/rf_bridge.h index c93b636c38c..e5780c9ebe5 100644 --- a/esphome/components/rf_bridge/rf_bridge.h +++ b/esphome/components/rf_bridge/rf_bridge.h @@ -49,11 +49,11 @@ class RFBridgeComponent : public uart::UARTDevice, public Component { public: void loop() override; void dump_config() override; - void add_on_code_received_callback(std::function callback) { - this->data_callback_.add(std::move(callback)); + template void add_on_code_received_callback(F &&callback) { + this->data_callback_.add(std::forward(callback)); } - void add_on_advanced_code_received_callback(std::function callback) { - this->advanced_data_callback_.add(std::move(callback)); + template void add_on_advanced_code_received_callback(F &&callback) { + this->advanced_data_callback_.add(std::forward(callback)); } void send_code(RFBridgeData data); void send_advanced_code(const RFBridgeAdvancedData &data); diff --git a/esphome/components/rotary_encoder/rotary_encoder.h b/esphome/components/rotary_encoder/rotary_encoder.h index 865554cd4d5..4b776fe55e9 100644 --- a/esphome/components/rotary_encoder/rotary_encoder.h +++ b/esphome/components/rotary_encoder/rotary_encoder.h @@ -82,15 +82,15 @@ class RotaryEncoderSensor : public sensor::Sensor, public Component { void dump_config() override; void loop() override; - void add_on_clockwise_callback(std::function callback) { - this->on_clockwise_callback_.add(std::move(callback)); + template void add_on_clockwise_callback(F &&callback) { + this->on_clockwise_callback_.add(std::forward(callback)); } - void add_on_anticlockwise_callback(std::function callback) { - this->on_anticlockwise_callback_.add(std::move(callback)); + template void add_on_anticlockwise_callback(F &&callback) { + this->on_anticlockwise_callback_.add(std::forward(callback)); } - void register_listener(std::function listener) { this->listeners_.add(std::move(listener)); } + template void register_listener(F &&listener) { this->listeners_.add(std::forward(listener)); } protected: InternalGPIOPin *pin_a_; diff --git a/esphome/components/rtttl/rtttl.h b/esphome/components/rtttl/rtttl.h index e37cccae9ef..bff43d2edd8 100644 --- a/esphome/components/rtttl/rtttl.h +++ b/esphome/components/rtttl/rtttl.h @@ -45,8 +45,8 @@ class Rtttl : public Component { bool is_playing() { return this->state_ != State::STOPPED; } - void add_on_finished_playback_callback(std::function callback) { - this->on_finished_playback_callback_.add(std::move(callback)); + template void add_on_finished_playback_callback(F &&callback) { + this->on_finished_playback_callback_.add(std::forward(callback)); } protected: diff --git a/esphome/components/safe_mode/safe_mode.h b/esphome/components/safe_mode/safe_mode.h index 1b28ea28f20..2733054962e 100644 --- a/esphome/components/safe_mode/safe_mode.h +++ b/esphome/components/safe_mode/safe_mode.h @@ -34,8 +34,8 @@ class SafeModeComponent final : public Component { void mark_successful(); #ifdef USE_SAFE_MODE_CALLBACK - void add_on_safe_mode_callback(std::function &&callback) { - this->safe_mode_callback_.add(std::move(callback)); + template void add_on_safe_mode_callback(F &&callback) { + this->safe_mode_callback_.add(std::forward(callback)); } #endif diff --git a/esphome/components/sdl/sdl_esphome.h b/esphome/components/sdl/sdl_esphome.h index bf5fde14282..c025e8ff6e9 100644 --- a/esphome/components/sdl/sdl_esphome.h +++ b/esphome/components/sdl/sdl_esphome.h @@ -37,11 +37,11 @@ class Sdl : public display::Display { int get_height() override { return this->height_; } float get_setup_priority() const override { return setup_priority::HARDWARE; } void dump_config() override { LOG_DISPLAY("", "SDL", this); } - void add_key_listener(int32_t keycode, std::function &&callback) { + template void add_key_listener(int32_t keycode, F &&callback) { if (!this->key_callbacks_.count(keycode)) { this->key_callbacks_[keycode] = CallbackManager(); } - this->key_callbacks_[keycode].add(std::move(callback)); + this->key_callbacks_[keycode].add(std::forward(callback)); } int mouse_x{}; diff --git a/esphome/components/select/select.cpp b/esphome/components/select/select.cpp index 91e27b30dee..df90c657e2b 100644 --- a/esphome/components/select/select.cpp +++ b/esphome/components/select/select.cpp @@ -42,10 +42,6 @@ StringRef Select::current_option() const { return this->has_state() ? StringRef(this->option_at(this->active_index_)) : StringRef(); } -void Select::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} - bool Select::has_option(const std::string &option) const { return this->index_of(option.c_str()).has_value(); } bool Select::has_option(const char *option) const { return this->index_of(option).has_value(); } diff --git a/esphome/components/select/select.h b/esphome/components/select/select.h index c91acd1e19e..465283d92a2 100644 --- a/esphome/components/select/select.h +++ b/esphome/components/select/select.h @@ -76,7 +76,9 @@ class Select : public EntityBase { /// Return the option value at the provided index offset (as const char* from flash). const char *option_at(size_t index) const; - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } protected: friend class SelectCall; diff --git a/esphome/components/sensor/sensor.cpp b/esphome/components/sensor/sensor.cpp index a7af6403efc..b4e59dfeb57 100644 --- a/esphome/components/sensor/sensor.cpp +++ b/esphome/components/sensor/sensor.cpp @@ -79,11 +79,6 @@ void Sensor::publish_state(float state) { #endif } -void Sensor::add_on_state_callback(std::function &&callback) { this->callback_.add(std::move(callback)); } -void Sensor::add_on_raw_state_callback(std::function &&callback) { - this->raw_callback_.add(std::move(callback)); -} - #ifdef USE_SENSOR_FILTER void Sensor::add_filter(Filter *filter) { // inefficient, but only happens once on every sensor setup and nobody's going to have massive amounts of diff --git a/esphome/components/sensor/sensor.h b/esphome/components/sensor/sensor.h index 197896f6f68..b3bd9620364 100644 --- a/esphome/components/sensor/sensor.h +++ b/esphome/components/sensor/sensor.h @@ -111,9 +111,11 @@ class Sensor : public EntityBase { // ========== INTERNAL METHODS ========== // (In most use cases you won't need these) /// Add a callback that will be called every time a filtered value arrives. - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { this->callback_.add(std::forward(callback)); } /// Add a callback that will be called every time the sensor sends a raw value. - void add_on_raw_state_callback(std::function &&callback); + template void add_on_raw_state_callback(F &&callback) { + this->raw_callback_.add(std::forward(callback)); + } /** This member variable stores the last state that has passed through all filters. * diff --git a/esphome/components/sim800l/sim800l.h b/esphome/components/sim800l/sim800l.h index e9e2f66d789..d79279ea720 100644 --- a/esphome/components/sim800l/sim800l.h +++ b/esphome/components/sim800l/sim800l.h @@ -61,20 +61,20 @@ class Sim800LComponent : public uart::UARTDevice, public PollingComponent { #ifdef USE_SENSOR void set_rssi_sensor(sensor::Sensor *rssi_sensor) { rssi_sensor_ = rssi_sensor; } #endif - void add_on_sms_received_callback(std::function callback) { - this->sms_received_callback_.add(std::move(callback)); + template void add_on_sms_received_callback(F &&callback) { + this->sms_received_callback_.add(std::forward(callback)); } - void add_on_incoming_call_callback(std::function callback) { - this->incoming_call_callback_.add(std::move(callback)); + template void add_on_incoming_call_callback(F &&callback) { + this->incoming_call_callback_.add(std::forward(callback)); } - void add_on_call_connected_callback(std::function callback) { - this->call_connected_callback_.add(std::move(callback)); + template void add_on_call_connected_callback(F &&callback) { + this->call_connected_callback_.add(std::forward(callback)); } - void add_on_call_disconnected_callback(std::function callback) { - this->call_disconnected_callback_.add(std::move(callback)); + template void add_on_call_disconnected_callback(F &&callback) { + this->call_disconnected_callback_.add(std::forward(callback)); } - void add_on_ussd_received_callback(std::function callback) { - this->ussd_received_callback_.add(std::move(callback)); + template void add_on_ussd_received_callback(F &&callback) { + this->ussd_received_callback_.add(std::forward(callback)); } void send_sms(const std::string &recipient, const std::string &message); void send_ussd(const std::string &ussd_code); diff --git a/esphome/components/sml/sml.cpp b/esphome/components/sml/sml.cpp index c1ffdc0e689..c8d5fcc2694 100644 --- a/esphome/components/sml/sml.cpp +++ b/esphome/components/sml/sml.cpp @@ -61,10 +61,6 @@ void Sml::loop() { } } -void Sml::add_on_data_callback(std::function, bool)> &&callback) { - this->data_callbacks_.add(std::move(callback)); -} - void Sml::process_sml_file_(const BytesView &sml_data) { SmlFile sml_file(sml_data); std::vector obis_info = sml_file.get_obis_info(); diff --git a/esphome/components/sml/sml.h b/esphome/components/sml/sml.h index 15ca43944cb..29a2f48bbec 100644 --- a/esphome/components/sml/sml.h +++ b/esphome/components/sml/sml.h @@ -24,7 +24,7 @@ class Sml : public Component, public uart::UARTDevice { void loop() override; void dump_config() override; std::vector sml_listeners_{}; - void add_on_data_callback(std::function, bool)> &&callback); + template void add_on_data_callback(F &&callback) { this->data_callbacks_.add(std::forward(callback)); } protected: void process_sml_file_(const BytesView &sml_data); diff --git a/esphome/components/speaker/speaker.h b/esphome/components/speaker/speaker.h index 373d2e3a746..5b89d00c69f 100644 --- a/esphome/components/speaker/speaker.h +++ b/esphome/components/speaker/speaker.h @@ -106,8 +106,8 @@ class Speaker { /// Parameters: /// - Frames played /// - System time in microseconds when the frames were written to the DAC - void add_audio_output_callback(std::function &&callback) { - this->audio_output_callback_.add(std::move(callback)); + template void add_audio_output_callback(F &&callback) { + this->audio_output_callback_.add(std::forward(callback)); } protected: diff --git a/esphome/components/switch/switch.cpp b/esphome/components/switch/switch.cpp index 9e9af213680..df762addbb1 100644 --- a/esphome/components/switch/switch.cpp +++ b/esphome/components/switch/switch.cpp @@ -69,9 +69,6 @@ void Switch::publish_state(bool state) { } bool Switch::assumed_state() { return false; } -void Switch::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} void Switch::set_inverted(bool inverted) { this->inverted_ = inverted; } bool Switch::is_inverted() const { return this->inverted_; } diff --git a/esphome/components/switch/switch.h b/esphome/components/switch/switch.h index c4f8525793a..b7761cba0a1 100644 --- a/esphome/components/switch/switch.h +++ b/esphome/components/switch/switch.h @@ -93,7 +93,9 @@ class Switch : public EntityBase { * * @param callback The void(bool) callback. */ - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } /** Returns the initial state of the switch, as persisted previously, or empty if never persisted. diff --git a/esphome/components/text/text.cpp b/esphome/components/text/text.cpp index d8ab6b1b92c..12abc5d9390 100644 --- a/esphome/components/text/text.cpp +++ b/esphome/components/text/text.cpp @@ -29,8 +29,4 @@ void Text::publish_state(const char *state, size_t len) { #endif } -void Text::add_on_state_callback(std::function &&callback) { - this->state_callback_.add(std::move(callback)); -} - } // namespace esphome::text diff --git a/esphome/components/text/text.h b/esphome/components/text/text.h index 7d255e56880..eb6a68f9980 100644 --- a/esphome/components/text/text.h +++ b/esphome/components/text/text.h @@ -30,7 +30,9 @@ class Text : public EntityBase { /// Instantiate a TextCall object to modify this text component's state. TextCall make_call() { return TextCall(this); } - void add_on_state_callback(std::function &&callback); + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } protected: friend class TextCall; diff --git a/esphome/components/text_sensor/text_sensor.cpp b/esphome/components/text_sensor/text_sensor.cpp index 91561c5f420..aa49a85d265 100644 --- a/esphome/components/text_sensor/text_sensor.cpp +++ b/esphome/components/text_sensor/text_sensor.cpp @@ -83,13 +83,6 @@ void TextSensor::clear_filters() { } #endif // USE_TEXT_SENSOR_FILTER -void TextSensor::add_on_state_callback(std::function callback) { - this->callback_.add(std::move(callback)); -} -void TextSensor::add_on_raw_state_callback(std::function callback) { - this->raw_callback_.add(std::move(callback)); -} - const std::string &TextSensor::get_state() const { return this->state; } const std::string &TextSensor::get_raw_state() const { #ifdef USE_TEXT_SENSOR_FILTER diff --git a/esphome/components/text_sensor/text_sensor.h b/esphome/components/text_sensor/text_sensor.h index d26cfade966..8941790e7cc 100644 --- a/esphome/components/text_sensor/text_sensor.h +++ b/esphome/components/text_sensor/text_sensor.h @@ -62,9 +62,11 @@ class TextSensor : public EntityBase { void clear_filters(); #endif - void add_on_state_callback(std::function callback); + template void add_on_state_callback(F &&callback) { this->callback_.add(std::forward(callback)); } /// Add a callback that will be called every time the sensor sends a raw value. - void add_on_raw_state_callback(std::function callback); + template void add_on_raw_state_callback(F &&callback) { + this->raw_callback_.add(std::forward(callback)); + } // ========== INTERNAL METHODS ========== // (In most use cases you won't need these) diff --git a/esphome/components/time/real_time_clock.h b/esphome/components/time/real_time_clock.h index f9de5f5614c..06ee2ea5af4 100644 --- a/esphome/components/time/real_time_clock.h +++ b/esphome/components/time/real_time_clock.h @@ -55,9 +55,9 @@ class RealTimeClock : public PollingComponent { /// Get the current time as the UTC epoch since January 1st 1970. time_t timestamp_now() { return ::time(nullptr); } - void add_on_time_sync_callback(std::function &&callback) { - this->time_sync_callback_.add(std::move(callback)); - }; + template void add_on_time_sync_callback(F &&callback) { + this->time_sync_callback_.add(std::forward(callback)); + } void dump_config() override; diff --git a/esphome/components/tuya/tuya.h b/esphome/components/tuya/tuya.h index 76431ddfe45..7e6b50f0847 100644 --- a/esphome/components/tuya/tuya.h +++ b/esphome/components/tuya/tuya.h @@ -112,8 +112,8 @@ class Tuya : public Component, public uart::UARTDevice { void add_ignore_mcu_update_on_datapoints(uint8_t ignore_mcu_update_on_datapoints) { this->ignore_mcu_update_on_datapoints_.push_back(ignore_mcu_update_on_datapoints); } - void add_on_initialized_callback(std::function callback) { - this->initialized_callback_.add(std::move(callback)); + template void add_on_initialized_callback(F &&callback) { + this->initialized_callback_.add(std::forward(callback)); } protected: diff --git a/esphome/components/uart/uart_component.h b/esphome/components/uart/uart_component.h index 853de719fef..ee2b006039c 100644 --- a/esphome/components/uart/uart_component.h +++ b/esphome/components/uart/uart_component.h @@ -190,9 +190,7 @@ class UARTComponent { #endif // USE_ESP8266 || USE_ESP32 #ifdef USE_UART_DEBUGGER - void add_debug_callback(std::function &&callback) { - this->debug_callback_.add(std::move(callback)); - } + template void add_debug_callback(F &&callback) { this->debug_callback_.add(std::forward(callback)); } #endif protected: diff --git a/esphome/components/udp/udp_component.h b/esphome/components/udp/udp_component.h index 7fd63080655..fb0edf2ebd7 100644 --- a/esphome/components/udp/udp_component.h +++ b/esphome/components/udp/udp_component.h @@ -28,9 +28,7 @@ class UDPComponent : public Component { void set_broadcast_port(uint16_t port) { this->broadcast_port_ = port; } void set_should_broadcast() { this->should_broadcast_ = true; } void set_should_listen() { this->should_listen_ = true; } - void add_listener(std::function)> &&listener) { - this->packet_listeners_.add(std::move(listener)); - } + template void add_listener(F &&listener) { this->packet_listeners_.add(std::forward(listener)); } void setup() override; void loop() override; void dump_config() override; diff --git a/esphome/components/update/update_entity.h b/esphome/components/update/update_entity.h index 82eaacaf76d..f7d0032f217 100644 --- a/esphome/components/update/update_entity.h +++ b/esphome/components/update/update_entity.h @@ -40,7 +40,9 @@ class UpdateEntity : public EntityBase { const UpdateInfo &update_info = update_info_; const UpdateState &state = state_; - void add_on_state_callback(std::function &&callback) { this->state_callback_.add(std::move(callback)); } + template void add_on_state_callback(F &&callback) { + this->state_callback_.add(std::forward(callback)); + } Trigger *get_update_available_trigger() { if (!update_available_trigger_) { update_available_trigger_ = std::make_unique>(); diff --git a/esphome/components/valve/valve.cpp b/esphome/components/valve/valve.cpp index 493ffd8da26..636da1f3c34 100644 --- a/esphome/components/valve/valve.cpp +++ b/esphome/components/valve/valve.cpp @@ -125,7 +125,6 @@ bool ValveCall::get_stop() const { return this->stop_; } ValveCall Valve::make_call() { return {this}; } -void Valve::add_on_state_callback(std::function &&f) { this->state_callback_.add(std::move(f)); } void Valve::publish_state(bool save) { this->position = clamp(this->position, 0.0f, 1.0f); diff --git a/esphome/components/valve/valve.h b/esphome/components/valve/valve.h index aab819a7788..b4141f5ff59 100644 --- a/esphome/components/valve/valve.h +++ b/esphome/components/valve/valve.h @@ -117,7 +117,7 @@ class Valve : public EntityBase { /// Construct a new valve call used to control the valve. ValveCall make_call(); - void add_on_state_callback(std::function &&f); + template void add_on_state_callback(F &&f) { this->state_callback_.add(std::forward(f)); } /** Publish the current state of the valve. * diff --git a/esphome/components/zephyr/cdc_acm.h b/esphome/components/zephyr/cdc_acm.h index 2e9da85a111..4dc14397d83 100644 --- a/esphome/components/zephyr/cdc_acm.h +++ b/esphome/components/zephyr/cdc_acm.h @@ -11,9 +11,7 @@ class CdcAcm : public Component { public: CdcAcm(); void setup() override; - void add_on_rate_callback(std::function &&callback) { - this->rate_callbacks_.add(std::move(callback)); - } + template void add_on_rate_callback(F &&callback) { this->rate_callbacks_.add(std::forward(callback)); } protected: static void cdc_dte_rate_callback_(const device *device, uint32_t rate); diff --git a/esphome/components/zigbee/zigbee_zephyr.h b/esphome/components/zigbee/zigbee_zephyr.h index dcc2b40a166..3fa5818ec57 100644 --- a/esphome/components/zigbee/zigbee_zephyr.h +++ b/esphome/components/zigbee/zigbee_zephyr.h @@ -74,7 +74,7 @@ class ZigbeeComponent : public Component { // endpoints are enumerated from 1 this->callbacks_[endpoint - 1] = std::move(cb); } - void add_join_callback(std::function &&cb) { this->join_cb_.add(std::move(cb)); } + template void add_join_callback(F &&cb) { this->join_cb_.add(std::forward(cb)); } void zboss_signal_handler_esphome(zb_bufid_t bufid); void factory_reset(); Trigger<> *get_join_trigger() { return &this->join_trigger_; }; diff --git a/esphome/core/entity_base.h b/esphome/core/entity_base.h index 4c6e5f6596b..8c1f1a213e5 100644 --- a/esphome/core/entity_base.h +++ b/esphome/core/entity_base.h @@ -307,15 +307,11 @@ template class StatefulEntityBase : public EntityBase { virtual T get_state_default(T default_value) const { return this->state_.value_or(default_value); } void invalidate_state() { this->set_new_state({}); } - void add_full_state_callback(std::function previous, optional current)> &&callback) { - if (this->full_state_callbacks_ == nullptr) - this->full_state_callbacks_ = new CallbackManager previous, optional current)>(); // NOLINT - this->full_state_callbacks_->add(std::move(callback)); + template void add_full_state_callback(F &&callback) { + this->full_state_callbacks_.add(std::forward(callback)); } - void add_on_state_callback(std::function &&callback) { - if (this->state_callbacks_ == nullptr) - this->state_callbacks_ = new CallbackManager(); // NOLINT - this->state_callbacks_->add(std::move(callback)); + template void add_on_state_callback(F &&callback) { + this->state_callbacks_.add(std::forward(callback)); } void set_trigger_on_initial_state(bool trigger_on_initial_state) { @@ -333,21 +329,19 @@ template class StatefulEntityBase : public EntityBase { virtual bool set_new_state(const optional &new_state) { if (this->state_ != new_state) { // call the full state callbacks with the previous and new state - if (this->full_state_callbacks_ != nullptr) - this->full_state_callbacks_->call(this->state_, new_state); + this->full_state_callbacks_.call(this->state_, new_state); // trigger legacy callbacks only if the new state is valid and either the trigger on initial state is enabled or // the previous state was valid auto had_state = this->has_state(); this->state_ = new_state; - if (this->state_callbacks_ != nullptr && new_state.has_value() && (this->trigger_on_initial_state_ || had_state)) - this->state_callbacks_->call(new_state.value()); + if (new_state.has_value() && (this->trigger_on_initial_state_ || had_state)) + this->state_callbacks_.call(new_state.value()); return true; } return false; } bool trigger_on_initial_state_{true}; - // callbacks with full state and previous state - CallbackManager previous, optional current)> *full_state_callbacks_{}; - CallbackManager *state_callbacks_{}; + LazyCallbackManager previous, optional current)> full_state_callbacks_; + LazyCallbackManager state_callbacks_; }; } // namespace esphome diff --git a/esphome/core/helpers.h b/esphome/core/helpers.h index d220626bcf3..a703b5a5f37 100644 --- a/esphome/core/helpers.h +++ b/esphome/core/helpers.h @@ -1729,6 +1729,51 @@ constexpr float fahrenheit_to_celsius(float value) { return (value - 32.0f) / 1. /// @name Utilities /// @{ +/// Lightweight type-erased callback (8 bytes on 32-bit) that avoids std::function overhead. +/// No null check, no exceptions, no heap allocation for small trivially-copyable callables. +/// +/// With C++20 if constexpr, automatically detects [this] lambdas (sizeof <= sizeof(void*), +/// trivially copyable) and stores them inline. Larger callables are heap-allocated. +template struct Callback; + +template struct Callback { + // The inline storage path stores callable bytes in ctx_ via memcpy. + // sizeof equality with uintptr_t ensures void* can round-trip arbitrary bit patterns, + // which combined with flat address spaces on all ESPHome targets means no trap representations. + static_assert(sizeof(void *) == sizeof(std::uintptr_t), "void* must be the same size as uintptr_t"); + + void (*fn_)(void *, Ts...){nullptr}; + void *ctx_{nullptr}; + + /// Invoke the callback. Only valid on Callbacks created via create(), never on default-constructed instances. + void call(Ts... args) const { this->fn_(this->ctx_, args...); } + + /// Create from any callable. Small trivially-copyable callables (like [this] lambdas) + /// are stored inline in the ctx pointer without heap allocation. + template static Callback create(F &&callable) { + using DecayF = std::decay_t; + if constexpr (sizeof(DecayF) <= sizeof(void *) && std::is_trivially_copyable_v) { + // Small trivial callable (e.g. [this]() { this->method(); }) - store inline in ctx. + // Safe under C++20 (P0593R6): byte copy into aligned storage implicitly + // creates objects of implicit-lifetime types (trivially copyable qualifies). + Callback cb; // fn and ctx are zero-initialized by default + __builtin_memcpy(&cb.ctx_, &callable, sizeof(DecayF)); + cb.fn_ = [](void *c, Ts... args) { + alignas(DecayF) char buf[sizeof(DecayF)]; + __builtin_memcpy(buf, &c, sizeof(DecayF)); + (*std::launder(reinterpret_cast(buf)))(args...); + }; + return cb; + } else { + // Large or non-trivial callable - heap allocate. + // Intentionally never freed: callbacks in ESPHome are registered during setup() + // and live for device lifetime. Same lifetime as the previous std::function approach. + auto *stored = new DecayF(std::forward(callable)); + return {[](void *c, Ts... args) { (*static_cast(c))(args...); }, static_cast(stored)}; + } + } +}; + template class CallbackManager; /** Helper class to allow having multiple subscribers to a callback. @@ -1737,13 +1782,14 @@ template class CallbackManager; */ template class CallbackManager { public: - /// Add a callback to the list. - void add(std::function &&callback) { this->callbacks_.push_back(std::move(callback)); } + /// Add any callable. Small trivially-copyable callables (like [this] lambdas) + /// are stored inline without heap allocation or std::function. + template void add(F &&callback) { this->add_(Callback::create(std::forward(callback))); } - /// Call all callbacks in this manager. + /// Call all callbacks in this manager. No null check on invoke. void call(Ts... args) { for (auto &cb : this->callbacks_) - cb(args...); + cb.call(args...); } size_t size() const { return this->callbacks_.size(); } @@ -1751,7 +1797,10 @@ template class CallbackManager { void operator()(Ts... args) { call(args...); } protected: - std::vector> callbacks_; + template friend class LazyCallbackManager; + /// Non-template core to avoid code duplication per lambda type. + void add_(Callback cb) { this->callbacks_.push_back(cb); } + std::vector> callbacks_; }; template class LazyCallbackManager; @@ -1784,13 +1833,8 @@ template class LazyCallbackManager { LazyCallbackManager(LazyCallbackManager &&) = delete; LazyCallbackManager &operator=(LazyCallbackManager &&) = delete; - /// Add a callback to the list. Allocates the underlying CallbackManager on first use. - void add(std::function &&callback) { - if (!this->callbacks_) { - this->callbacks_ = new CallbackManager(); - } - this->callbacks_->add(std::move(callback)); - } + /// Add any callable. Allocates the underlying CallbackManager on first use. + template void add(F &&callback) { this->add_(Callback::create(std::forward(callback))); } /// Call all callbacks in this manager. No-op if no callbacks registered. void call(Ts... args) { @@ -1809,6 +1853,13 @@ template class LazyCallbackManager { void operator()(Ts... args) { this->call(args...); } protected: + /// Non-template core to avoid code duplication per lambda type. + void add_(Callback cb) { + if (!this->callbacks_) { + this->callbacks_ = new CallbackManager(); + } + this->callbacks_->add_(cb); + } CallbackManager *callbacks_{nullptr}; };