From 862aca7ef3383075c8729bc4f72b5c6fa010e901 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Fri, 21 Aug 2026 16:37:57 -0500 Subject: [PATCH] Only format the MAC when a log line will use it; label HCI units --- esphome/components/esp32_ble/ble.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/esphome/components/esp32_ble/ble.cpp b/esphome/components/esp32_ble/ble.cpp index c6f844f631..6e6fb0e30d 100644 --- a/esphome/components/esp32_ble/ble.cpp +++ b/esphome/components/esp32_ble/ble.cpp @@ -647,15 +647,20 @@ void ESP32BLE::gap_event_handler(esp_gap_ble_cb_event_t event, esp_ble_gap_cb_pa // never answer an update, and without this the link silently stays on the // old parameters (visible only as unexplained supervision timeouts). case ESP_GAP_BLE_UPDATE_CONN_PARAMS_EVT: { - char mac_s[MAC_ADDRESS_PRETTY_BUFFER_SIZE]; - format_mac_addr_upper(param->update_conn_params.bda, mac_s); if (param->update_conn_params.status != ESP_BT_STATUS_SUCCESS) { + char mac_s[MAC_ADDRESS_PRETTY_BUFFER_SIZE]; + format_mac_addr_upper(param->update_conn_params.bda, mac_s); ESP_LOGW(TAG, "[%s] Conn param update failed, status=%d", mac_s, param->update_conn_params.status); - } else { - ESP_LOGV(TAG, "[%s] Conn params updated: interval=%u latency=%u timeout=%u", mac_s, + } +#if ESPHOME_LOG_LEVEL >= ESPHOME_LOG_LEVEL_VERBOSE + else { + char mac_s[MAC_ADDRESS_PRETTY_BUFFER_SIZE]; + format_mac_addr_upper(param->update_conn_params.bda, mac_s); + ESP_LOGV(TAG, "[%s] Conn params updated: interval=%u (x1.25ms) latency=%u timeout=%u (x10ms)", mac_s, param->update_conn_params.conn_int, param->update_conn_params.latency, param->update_conn_params.timeout); } +#endif return; }