From 82348af4143dfcda065ab40155169a0fe1aca8ff Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 18 Mar 2026 17:31:38 -1000 Subject: [PATCH] [ethernet] Address review feedback - Remove redundant ENC28J60lwIP.h include (already included via header) - Fix misleading duplex mode comment for ENC28J60 --- esphome/components/ethernet/ethernet_component_rp2040.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/esphome/components/ethernet/ethernet_component_rp2040.cpp b/esphome/components/ethernet/ethernet_component_rp2040.cpp index 1ad61a5e94..6bf4751d37 100644 --- a/esphome/components/ethernet/ethernet_component_rp2040.cpp +++ b/esphome/components/ethernet/ethernet_component_rp2040.cpp @@ -12,10 +12,6 @@ #include #include -#ifdef USE_ETHERNET_ENC28J60 -#include -#endif - namespace esphome::ethernet { static const char *const TAG = "ethernet"; @@ -231,7 +227,7 @@ const char *EthernetComponent::get_eth_mac_address_pretty_into_buffer( eth_duplex_t EthernetComponent::get_duplex_mode() { #ifdef USE_ETHERNET_ENC28J60 - // ENC28J60 supports full-duplex but defaults to half-duplex + // ENC28J60 is configured for full-duplex by the arduino-pico driver return ETH_DUPLEX_FULL; #else // W5500 is always full duplex