Warn only on corrupt reports, carry the traceback, name the file

Structural corruption at any level (containers or non-numeric leaves)
warns as malformed; a well-shaped report simply lacking DRAM/DIRAM is a
variant difference and stays at debug, so healthy builds on other
targets cannot train users to ignore the warning channel. The backstop
warning carries exc_info so a field report is actionable without -v,
and the image_size warning names its file. Tests pin each message
distinctly.
This commit is contained in:
J. Nick Koston
2026-08-23 15:49:41 -05:00
parent 7475ab8f94
commit 7595baebd2
2 changed files with 36 additions and 9 deletions
+19 -2
View File
@@ -213,15 +213,32 @@ def test_print_summary_nested_bad_shapes_never_raise(
caplog: pytest.LogCaptureFixture,
payload: dict,
) -> None:
"""Bad nested shapes hit the named RAM guard, not the blanket backstop."""
"""Corrupt nested shapes hit the named malformed guard, not the blanket."""
size_json = _write_size_json(tmp_path, payload)
print_summary(size_json, None)
# No half-formed bar for CI to scrape; every payload fails before printing
assert capsys.readouterr().out == ""
assert "Skipping RAM summary" in caplog.text
assert "malformed memory_types" in caplog.text
assert "Skipping size summary for" not in caplog.text
def test_print_summary_absent_region_stays_quiet(
tmp_path: Path,
capsys: pytest.CaptureFixture[str],
caplog: pytest.LogCaptureFixture,
) -> None:
"""A well-shaped report without DRAM/DIRAM is a variant difference, not
a broken artifact: debug, never a per-build warning."""
size_json = _write_size_json(tmp_path, {"memory_types": {}, "image_size": 1})
with caplog.at_level(logging.DEBUG, logger="esphome.espidf.size_summary"):
print_summary(size_json, None)
assert "RAM:" not in capsys.readouterr().out
assert "no usable DRAM/DIRAM region" in caplog.text
assert not [
r for r in caplog.records if r.levelno >= logging.WARNING and "RAM" in r.message
]
def test_print_summary_non_numeric_image_size_warns_by_name(
tmp_path: Path,
capsys: pytest.CaptureFixture[str],