github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-22 05:46:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

[packet_interface] Remove PacketBuffer::to_vector()

Browse Source 
It allocated a vector for each call, which invites heap churn. Only the
tests used it; they now have a local helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
clydebarrow
2026-10-19 14:40:08 +11:00
co-authored by Claude Opus 5.5
parent 574e9f4687
commit 726c30dccd
3 changed files with 19 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/uart/uart_packet_interface.cpp
+9 -3
View File
@@ -9,6 +9,13 @@
namespace esphome::uart::testing {
// Copies a packet into a vector, for comparing in tests
static std::vector<uint8_t> to_vector(const esphome::packet_interface::PacketBuffer &data) {
std::vector<uint8_t> result(data.size());
data.copy_to(result.data(), result.size());
return result;
}
using packet_interface::PacketBuffer;
using packet_interface::PacketMetaData;
@@ -26,9 +33,8 @@ class UartPacketInterfaceTest : public ::testing::Test {
interface_.set_uart_parent(&uart_);
interface_.setup();
interface_.add_packet_interface_listener([this](const PacketBuffer &data, const PacketMetaData &meta) {
received_packets_.push_back(data.to_vector());
});
interface_.add_packet_interface_listener(
[this](const PacketBuffer &data, const PacketMetaData &meta) { received_packets_.push_back(to_vector(data)); });
}
};