github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-01 08:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

[schema] Keep the field's own range when spreading a named schema

Browse Source 
Address esphbot review: emitting min/max means named scalar schemas now carry
bounds (e.g. core.uint8_t is 0..255), and shrink()'s spread copied those over a
tighter bound the field defined itself. cv.All(cv.uint8_t, cv.Range(min=1,
max=6)) dumped 0..255 instead of 1..6, and All(uint32_t, Range(min=1)) lost its
min. The spread now reconciles the two to the intersection (larger min, smaller
max); non-numeric bounds keep the field's own value.
This commit is contained in:
Jesse Hills
2026-09-15 07:13:29 +12:00
parent 59044484e2
commit 63e1adfd5f
2 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/script/test_build_language_schema.py
+11
View File
@@ -546,6 +546,17 @@ def test_cv_types_end_to_end(full_schema_dir: Path) -> None:
assert freq["min"] == 45.0
assert freq["max"] == 66.0
# cv.All(cv.uint8_t, cv.Range(min=1, max=6)): spreading the uint8_t named
# schema (0..255) must not clobber the field's own tighter 1..6 bound.
tm1637 = json.loads((full_schema_dir / "tm1637.json").read_text())
length = tm1637["tm1637.display"]["schemas"]["CONFIG_SCHEMA"]["schema"][
"config_vars"
]["length"]
assert length["type"] == "integer"
assert length["data_type"] == "uint8_t"
assert length["min"] == 1
assert length["max"] == 6
# positive_float = All(float_, Range(min=0)): a bounds-only named schema
# spreads its data_type name and its min onto the field.
light = json.loads((full_schema_dir / "light.json").read_text())["light"]