github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-09-30 00:10:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Code cleanup fixes for the select component (#3457)

Browse Source 
Co-authored-by: Maurice Makaay <mmakaay1@xs4all.net>
This commit is contained in:
Maurice Makaay
2022-05-11 10:58:28 +12:00
committed by GitHub
co-authored by Maurice Makaay
parent 235a97ea10
commit 62f9e181e0
5 changed files with 33 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/select/select.cpp
+8 -3
View File
@@ -23,6 +23,10 @@ void Select::add_on_state_callback(std::function<void(std::string, size_t)> &&ca
this->state_callback_.add(std::move(callback));
}
bool Select::has_option(const std::string &option) const { return this->index_of(option).has_value(); }
bool Select::has_index(size_t index) const { return index < this->size(); }
size_t Select::size() const {
auto options = traits.get_options();
return options.size();
@@ -46,11 +50,12 @@ optional<size_t> Select::active_index() const {
}
optional<std::string> Select::at(size_t index) const {
auto options = traits.get_options();
if (index >= options.size()) {
if (this->has_index(index)) {
auto options = traits.get_options();
return options.at(index);
} else {
return {};
}
return options.at(index);
}
uint32_t Select::hash_base() { return 2812997003UL; }