From 4736550677130ae4079afda9d36745795461f713 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Tue, 8 Sep 2026 03:57:59 +0200 Subject: [PATCH] [api] Say why ProtoDecodableMessage has no protected destructor --- esphome/components/api/proto.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/esphome/components/api/proto.h b/esphome/components/api/proto.h index 3ec3e6f436..1718ebe644 100644 --- a/esphome/components/api/proto.h +++ b/esphome/components/api/proto.h @@ -739,6 +739,9 @@ class ProtoDecodableMessage : public ProtoMessage { * @return Number of times the field appears in the buffer */ static uint32_t count_repeated_field(const uint8_t *buffer, size_t length, uint32_t target_field_id); + // No protected destructor here: without virtuals nothing can be deleted through this class, and the + // generated messages are aggregates whose sub message members are brace initialised, which needs an + // accessible destructor on the base temporary. ProtoMessage keeps its guard for the dump builds. }; #ifndef HAS_PROTO_MESSAGE_DUMP // decode() passes decode_field explicitly, so nothing here may add a vtable