github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-08-22 22:26:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[mipi_spi] Toggle D/C only while holding the SPI bus (#18529)

Browse Source
This commit is contained in:
Jesse Hills
2026-08-21 07:58:11 +12:00
committed by GitHub
parent 12da2140cf
commit 44dcd82d78
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/mipi_spi/mipi_spi.h
+9 -6
View File
@@ -246,33 +246,36 @@ class MipiSpi : public display::Display,
this->write_cmd_addr_data(8, 0x02, 24, cmd << 8, bytes, len); this->write_cmd_addr_data(8, 0x02, 24, cmd << 8, bytes, len);
this->disable(); this->disable();
} else if constexpr (BUS_TYPE == BUS_TYPE_OCTAL) { } else if constexpr (BUS_TYPE == BUS_TYPE_OCTAL) {
this->dc_pin_->digital_write(false); // Toggle D/C only while holding the bus; on boards where D/C doubles as
// another bus signal, driving it while another device owns the bus
// corrupts that device's transfer.
this->enable(); this->enable();
this->dc_pin_->digital_write(false);
this->write_cmd_addr_data(0, 0, 0, 0, &cmd, 1, 8); this->write_cmd_addr_data(0, 0, 0, 0, &cmd, 1, 8);
this->disable();
this->dc_pin_->digital_write(true); this->dc_pin_->digital_write(true);
this->disable();
if (len != 0) { if (len != 0) {
this->enable(); this->enable();
this->write_cmd_addr_data(0, 0, 0, 0, bytes, len, 8); this->write_cmd_addr_data(0, 0, 0, 0, bytes, len, 8);
this->disable(); this->disable();
} }
} else if constexpr (BUS_TYPE == BUS_TYPE_SINGLE) { } else if constexpr (BUS_TYPE == BUS_TYPE_SINGLE) {
this->dc_pin_->digital_write(false);
this->enable(); this->enable();
this->dc_pin_->digital_write(false);
this->write_byte(cmd); this->write_byte(cmd);
this->disable();
this->dc_pin_->digital_write(true); this->dc_pin_->digital_write(true);
this->disable();
if (len != 0) { if (len != 0) {
this->enable(); this->enable();
this->write_array(bytes, len); this->write_array(bytes, len);
this->disable(); this->disable();
} }
} else if constexpr (BUS_TYPE == BUS_TYPE_SINGLE_16) { } else if constexpr (BUS_TYPE == BUS_TYPE_SINGLE_16) {
this->dc_pin_->digital_write(false);
this->enable(); this->enable();
this->dc_pin_->digital_write(false);
this->write_byte(cmd); this->write_byte(cmd);
this->disable();
this->dc_pin_->digital_write(true); this->dc_pin_->digital_write(true);
this->disable();
for (size_t i = 0; i != len; i++) { for (size_t i = 0; i != len; i++) {
this->enable(); this->enable();
this->write_byte(0); this->write_byte(0);