github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-01 08:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

[espidf] Resolve cmake through the IDF environment when reading the CMake cache (#19947)

Browse Source
This commit is contained in:
J. Nick Koston
2026-09-30 13:17:07 +02:00
committed by GitHub
parent 6c43247395
commit 3fac97867e
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/test_espidf_toolchain.py
+4
View File
@@ -264,6 +264,7 @@ def test_get_cmake_output_with_configured_build(setup_core: Path) -> None:
)
with (
patch.object(toolchain, "_get_idf_env", return_value={}),
patch.object(toolchain, "_get_idf_tool", return_value="/idf/tools/cmake"),
patch.object(toolchain.subprocess, "run", return_value=completed) as mock_run,
):
assert toolchain._get_cmake_output(build_dir) == completed.stdout
@@ -271,6 +272,9 @@ def test_get_cmake_output_with_configured_build(setup_core: Path) -> None:
assert toolchain._get_cmake_output(build_dir) == completed.stdout
mock_run.assert_called_once()
# The resolved path, never a bare "cmake": Windows locates the child
# through the parent's PATH, where the IDF-managed cmake is missing.
assert mock_run.call_args.args[0][0] == "/idf/tools/cmake"
assert toolchain._get_cmake_tool_path("CMAKE_ADDR2LINE") == Path("/tool/addr2line")