diff --git a/esphome/components/absolute_humidity/absolute_humidity.cpp b/esphome/components/absolute_humidity/absolute_humidity.cpp index c927afcd509..36b6534c0de 100644 --- a/esphome/components/absolute_humidity/absolute_humidity.cpp +++ b/esphome/components/absolute_humidity/absolute_humidity.cpp @@ -10,7 +10,7 @@ void AbsoluteHumidityComponent::setup() { this->temperature_ = state; this->enable_loop(); }); - ESP_LOGD(TAG, " Added callback for temperature '%s'", LOG_STR_ARG(this->temperature_sensor_->get_log_name())); + ESP_LOGD(TAG, " Added callback for temperature '%s'", this->temperature_sensor_->get_name().c_str()); // Get initial value if (this->temperature_sensor_->has_state()) { this->temperature_ = this->temperature_sensor_->get_state(); @@ -20,7 +20,7 @@ void AbsoluteHumidityComponent::setup() { this->humidity_ = state; this->enable_loop(); }); - ESP_LOGD(TAG, " Added callback for relative humidity '%s'", LOG_STR_ARG(this->humidity_sensor_->get_log_name())); + ESP_LOGD(TAG, " Added callback for relative humidity '%s'", this->humidity_sensor_->get_name().c_str()); // Get initial value if (this->humidity_sensor_->has_state()) { this->humidity_ = this->humidity_sensor_->get_state(); @@ -49,8 +49,7 @@ void AbsoluteHumidityComponent::dump_config() { "Sources\n" " Temperature: '%s'\n" " Relative Humidity: '%s'", - LOG_STR_ARG(this->temperature_sensor_->get_log_name()), - LOG_STR_ARG(this->humidity_sensor_->get_log_name())); + this->temperature_sensor_->get_name().c_str(), this->humidity_sensor_->get_name().c_str()); } void AbsoluteHumidityComponent::loop() { diff --git a/esphome/components/adc/adc_sensor_common.cpp b/esphome/components/adc/adc_sensor_common.cpp index 86c864ea2a1..dcb41382015 100644 --- a/esphome/components/adc/adc_sensor_common.cpp +++ b/esphome/components/adc/adc_sensor_common.cpp @@ -66,7 +66,7 @@ template class Aggregator; void ADCSensor::update() { float value_v = this->sample(); - ESP_LOGV(TAG, "'%s': Voltage=%.4fV", LOG_STR_ARG(this->get_log_name()), value_v); + ESP_LOGV(TAG, "'%s': Voltage=%.4fV", this->get_name().c_str(), value_v); this->publish_state(value_v); } diff --git a/esphome/components/ads1115/sensor/ads1115_sensor.cpp b/esphome/components/ads1115/sensor/ads1115_sensor.cpp index d2f18142970..776346171b7 100644 --- a/esphome/components/ads1115/sensor/ads1115_sensor.cpp +++ b/esphome/components/ads1115/sensor/ads1115_sensor.cpp @@ -13,7 +13,7 @@ float ADS1115Sensor::sample() { void ADS1115Sensor::update() { float v = this->sample(); if (!std::isnan(v)) { - ESP_LOGD(TAG, "'%s': Got Voltage=%fV", LOG_STR_ARG(this->get_log_name()), v); + ESP_LOGD(TAG, "'%s': Got Voltage=%fV", this->get_name().c_str(), v); this->publish_state(v); } } diff --git a/esphome/components/ads1118/sensor/ads1118_sensor.cpp b/esphome/components/ads1118/sensor/ads1118_sensor.cpp index 74d25214155..2b3d68d1f40 100644 --- a/esphome/components/ads1118/sensor/ads1118_sensor.cpp +++ b/esphome/components/ads1118/sensor/ads1118_sensor.cpp @@ -21,7 +21,7 @@ float ADS1118Sensor::sample() { void ADS1118Sensor::update() { float v = this->sample(); if (!std::isnan(v)) { - ESP_LOGD(TAG, "'%s': Got Voltage=%fV", LOG_STR_ARG(this->get_log_name()), v); + ESP_LOGD(TAG, "'%s': Got Voltage=%fV", this->get_name().c_str(), v); this->publish_state(v); } } diff --git a/esphome/components/alarm_control_panel/alarm_control_panel.cpp b/esphome/components/alarm_control_panel/alarm_control_panel.cpp index 730cb80fd17..6f23b1aca89 100644 --- a/esphome/components/alarm_control_panel/alarm_control_panel.cpp +++ b/esphome/components/alarm_control_panel/alarm_control_panel.cpp @@ -31,7 +31,7 @@ void AlarmControlPanel::publish_state(AlarmControlPanelState state) { this->last_update_ = millis(); if (state != this->current_state_) { auto prev_state = this->current_state_; - ESP_LOGV(TAG, "'%s' >> %s (was %s)", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "'%s' >> %s (was %s)", this->get_name().c_str(), LOG_STR_ARG(alarm_control_panel_state_to_string(state)), LOG_STR_ARG(alarm_control_panel_state_to_string(prev_state))); this->current_state_ = state; diff --git a/esphome/components/am43/cover/am43_cover.cpp b/esphome/components/am43/cover/am43_cover.cpp index 7fac19b50f1..6fb8c0c7eba 100644 --- a/esphome/components/am43/cover/am43_cover.cpp +++ b/esphome/components/am43/cover/am43_cover.cpp @@ -30,9 +30,9 @@ void Am43Component::loop() { auto status = esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_, packet->length, packet->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE); - ESP_LOGI(TAG, "[%s] Logging into AM43", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "[%s] Logging into AM43", this->get_name().c_str()); if (status) { - ESP_LOGW(TAG, "[%s] Error writing set_pin to device, error = %d", LOG_STR_ARG(this->get_log_name()), status); + ESP_LOGW(TAG, "[%s] Error writing set_pin to device, error = %d", this->get_name().c_str(), status); } else { this->logged_in_ = true; } @@ -50,7 +50,7 @@ CoverTraits Am43Component::get_traits() { void Am43Component::control(const CoverCall &call) { if (this->node_state != espbt::ClientState::ESTABLISHED) { - ESP_LOGW(TAG, "[%s] Cannot send cover control, not connected", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Cannot send cover control, not connected", this->get_name().c_str()); return; } if (call.get_stop()) { @@ -59,7 +59,7 @@ void Am43Component::control(const CoverCall &call) { esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_, packet->length, packet->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE); if (status) { - ESP_LOGW(TAG, "[%s] Error writing stop command to device, error = %d", LOG_STR_ARG(this->get_log_name()), status); + ESP_LOGW(TAG, "[%s] Error writing stop command to device, error = %d", this->get_name().c_str(), status); } } auto opt_pos = call.get_position(); @@ -73,8 +73,7 @@ void Am43Component::control(const CoverCall &call) { esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_, packet->length, packet->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE); if (status) { - ESP_LOGW(TAG, "[%s] Error writing set_position command to device, error = %d", LOG_STR_ARG(this->get_log_name()), - status); + ESP_LOGW(TAG, "[%s] Error writing set_position command to device, error = %d", this->get_name().c_str(), status); } } } @@ -90,9 +89,9 @@ void Am43Component::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_ auto *chr = this->parent_->get_characteristic(AM43_SERVICE_UUID, AM43_CHARACTERISTIC_UUID); if (chr == nullptr) { if (this->parent_->get_characteristic(AM43_TUYA_SERVICE_UUID, AM43_TUYA_CHARACTERISTIC_UUID) != nullptr) { - ESP_LOGE(TAG, "[%s] Detected a Tuya AM43 which is not supported, sorry.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, "[%s] Detected a Tuya AM43 which is not supported, sorry.", this->get_name().c_str()); } else { - ESP_LOGE(TAG, "[%s] No control service found at device, not an AM43..?", LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, "[%s] No control service found at device, not an AM43..?", this->get_name().c_str()); } break; } @@ -101,8 +100,7 @@ void Am43Component::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_ auto status = esp_ble_gattc_register_for_notify(this->parent_->get_gattc_if(), this->parent_->get_remote_bda(), chr->handle); if (status) { - ESP_LOGW(TAG, "[%s] esp_ble_gattc_register_for_notify failed, status=%d", LOG_STR_ARG(this->get_log_name()), - status); + ESP_LOGW(TAG, "[%s] esp_ble_gattc_register_for_notify failed, status=%d", this->get_name().c_str(), status); } break; } @@ -128,26 +126,25 @@ void Am43Component::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_ if (this->decoder_->has_pin_response()) { if (this->decoder_->pin_ok_) { - ESP_LOGI(TAG, "[%s] AM43 pin accepted.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "[%s] AM43 pin accepted.", this->get_name().c_str()); auto *packet = this->encoder_->get_position_request(); auto status = esp_ble_gattc_write_char(this->parent_->get_gattc_if(), this->parent_->get_conn_id(), this->char_handle_, packet->length, packet->data, ESP_GATT_WRITE_TYPE_NO_RSP, ESP_GATT_AUTH_REQ_NONE); if (status) { - ESP_LOGW(TAG, "[%s] Error writing set_position to device, error = %d", LOG_STR_ARG(this->get_log_name()), - status); + ESP_LOGW(TAG, "[%s] Error writing set_position to device, error = %d", this->get_name().c_str(), status); } } else { - ESP_LOGW(TAG, "[%s] AM43 pin rejected!", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] AM43 pin rejected!", this->get_name().c_str()); } } if (this->decoder_->has_set_position_response() && !this->decoder_->set_position_ok_) { - ESP_LOGW(TAG, "[%s] Got nack after sending set_position. Bad pin?", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Got nack after sending set_position. Bad pin?", this->get_name().c_str()); } if (this->decoder_->has_set_state_response() && !this->decoder_->set_state_ok_) { - ESP_LOGW(TAG, "[%s] Got nack after sending set_state. Bad pin?", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Got nack after sending set_state. Bad pin?", this->get_name().c_str()); } break; } diff --git a/esphome/components/anova/anova.cpp b/esphome/components/anova/anova.cpp index 72a29607599..28e2da93e93 100644 --- a/esphome/components/anova/anova.cpp +++ b/esphome/components/anova/anova.cpp @@ -67,9 +67,8 @@ void Anova::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_ case ESP_GATTC_SEARCH_CMPL_EVT: { auto *chr = this->parent_->get_characteristic(ANOVA_SERVICE_UUID, ANOVA_CHARACTERISTIC_UUID); if (chr == nullptr) { - ESP_LOGW(TAG, "[%s] No control service found at device, not an Anova..?", LOG_STR_ARG(this->get_log_name())); - ESP_LOGW(TAG, "[%s] Note, this component does not currently support Anova Nano.", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] No control service found at device, not an Anova..?", this->get_name().c_str()); + ESP_LOGW(TAG, "[%s] Note, this component does not currently support Anova Nano.", this->get_name().c_str()); break; } this->char_handle_ = chr->handle; @@ -77,8 +76,7 @@ void Anova::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_ auto status = esp_ble_gattc_register_for_notify(this->parent_->get_gattc_if(), this->parent_->get_remote_bda(), chr->handle); if (status) { - ESP_LOGW(TAG, "[%s] esp_ble_gattc_register_for_notify failed, status=%d", LOG_STR_ARG(this->get_log_name()), - status); + ESP_LOGW(TAG, "[%s] esp_ble_gattc_register_for_notify failed, status=%d", this->get_name().c_str(), status); } break; } diff --git a/esphome/components/aqi/aqi_sensor.cpp b/esphome/components/aqi/aqi_sensor.cpp index 95f798d2b3d..c242ee39136 100644 --- a/esphome/components/aqi/aqi_sensor.cpp +++ b/esphome/components/aqi/aqi_sensor.cpp @@ -30,10 +30,10 @@ void AQISensor::dump_config() { ESP_LOGCONFIG(TAG, " Extended Range: %s", this->extended_range_ ? LOG_STR_LITERAL("enabled") : LOG_STR_LITERAL("disabled")); if (this->pm_2_5_sensor_ != nullptr) { - ESP_LOGCONFIG(TAG, " PM2.5 Sensor: '%s'", LOG_STR_ARG(this->pm_2_5_sensor_->get_log_name())); + ESP_LOGCONFIG(TAG, " PM2.5 Sensor: '%s'", this->pm_2_5_sensor_->get_name().c_str()); } if (this->pm_10_0_sensor_ != nullptr) { - ESP_LOGCONFIG(TAG, " PM10 Sensor: '%s'", LOG_STR_ARG(this->pm_10_0_sensor_->get_log_name())); + ESP_LOGCONFIG(TAG, " PM10 Sensor: '%s'", this->pm_10_0_sensor_->get_name().c_str()); } LOG_SENSOR(" ", "AQI", this); } diff --git a/esphome/components/atm90e32/atm90e32.cpp b/esphome/components/atm90e32/atm90e32.cpp index 937011c048a..0c4f095ab57 100644 --- a/esphome/components/atm90e32/atm90e32.cpp +++ b/esphome/components/atm90e32/atm90e32.cpp @@ -1289,7 +1289,7 @@ void ATM90E32Component::check_phase_status() { if (!status.empty()) { status.pop_back(); // remove space status.pop_back(); // remove semicolon - ESP_LOGW(TAG, "%s: %s", LOG_STR_ARG(sensor->get_log_name()), status.c_str()); + ESP_LOGW(TAG, "%s: %s", sensor->get_name().c_str(), status.c_str()); sensor->publish_state(status); } else { sensor->publish_state("Okay"); diff --git a/esphome/components/atm90e32/button/atm90e32_button.cpp b/esphome/components/atm90e32/button/atm90e32_button.cpp index 765dd7f9f3d..03871495214 100644 --- a/esphome/components/atm90e32/button/atm90e32_button.cpp +++ b/esphome/components/atm90e32/button/atm90e32_button.cpp @@ -8,12 +8,11 @@ ESPHOME_LOG_TAG(TAG, "atm90e32.button"); void ATM90E32GainCalibrationButton::press_action() { if (this->parent_ == nullptr) { - ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Gain Calibration button [%s]", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Gain Calibration button [%s]", this->get_name().c_str()); return; } - ESP_LOGI(TAG, "%s", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "%s", this->get_name().c_str()); ESP_LOGI(TAG, "[CALIBRATION] Use gain_ct: & gain_voltage: under each phase_x: in your config file to save these values"); this->parent_->run_gain_calibrations(); @@ -21,22 +20,21 @@ void ATM90E32GainCalibrationButton::press_action() { void ATM90E32ClearGainCalibrationButton::press_action() { if (this->parent_ == nullptr) { - ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Clear Gain button [%s]", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Clear Gain button [%s]", this->get_name().c_str()); return; } - ESP_LOGI(TAG, "%s", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "%s", this->get_name().c_str()); this->parent_->clear_gain_calibrations(); } void ATM90E32OffsetCalibrationButton::press_action() { if (this->parent_ == nullptr) { - ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Offset Calibration button [%s]", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Offset Calibration button [%s]", this->get_name().c_str()); return; } - ESP_LOGI(TAG, "%s", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "%s", this->get_name().c_str()); ESP_LOGI(TAG, "[CALIBRATION] **NOTE: CTs and ACVs must be 0 during this process. USB power only**"); ESP_LOGI(TAG, "[CALIBRATION] Use offset_voltage: & offset_current: under each phase_x: in your config file to save " "these values"); @@ -45,22 +43,21 @@ void ATM90E32OffsetCalibrationButton::press_action() { void ATM90E32ClearOffsetCalibrationButton::press_action() { if (this->parent_ == nullptr) { - ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Clear Offset button [%s]", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Clear Offset button [%s]", this->get_name().c_str()); return; } - ESP_LOGI(TAG, "%s", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "%s", this->get_name().c_str()); this->parent_->clear_offset_calibrations(); } void ATM90E32PowerOffsetCalibrationButton::press_action() { if (this->parent_ == nullptr) { - ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Power Calibration button [%s]", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Power Calibration button [%s]", this->get_name().c_str()); return; } - ESP_LOGI(TAG, "%s", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "%s", this->get_name().c_str()); ESP_LOGI(TAG, "[CALIBRATION] **NOTE: CTs must be 0 during this process. Voltage reference should be present**"); ESP_LOGI(TAG, "[CALIBRATION] Use offset_active_power: & offset_reactive_power: under each phase_x: in your config " "file to save these values"); @@ -69,11 +66,11 @@ void ATM90E32PowerOffsetCalibrationButton::press_action() { void ATM90E32ClearPowerOffsetCalibrationButton::press_action() { if (this->parent_ == nullptr) { - ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Clear Power button [%s]", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[CALIBRATION] No meters assigned to Clear Power button [%s]", this->get_name().c_str()); return; } - ESP_LOGI(TAG, "%s", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "%s", this->get_name().c_str()); this->parent_->clear_power_offset_calibrations(); } diff --git a/esphome/components/bedjet/climate/bedjet_climate.cpp b/esphome/components/bedjet/climate/bedjet_climate.cpp index 40c26a49278..196d4785e98 100644 --- a/esphome/components/bedjet/climate/bedjet_climate.cpp +++ b/esphome/components/bedjet/climate/bedjet_climate.cpp @@ -211,7 +211,7 @@ void BedJetClimate::control(const ClimateCall &call) { } else if (fan_mode == CLIMATE_FAN_HIGH) { result = this->parent_->set_fan_speed(75); } else { - ESP_LOGW(TAG, "[%s] Unsupported fan mode: %s", LOG_STR_ARG(this->get_log_name()), + ESP_LOGW(TAG, "[%s] Unsupported fan mode: %s", this->get_name().c_str(), LOG_STR_ARG(climate_fan_mode_to_string(fan_mode))); return; } @@ -223,7 +223,7 @@ void BedJetClimate::control(const ClimateCall &call) { auto fan_mode = call.get_custom_fan_mode(); auto fan_index = bedjet_fan_speed_to_step(fan_mode.c_str()); if (fan_index <= 19) { - ESP_LOGV(TAG, "[%s] Converted fan mode %.*s to bedjet fan step %d", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "[%s] Converted fan mode %.*s to bedjet fan step %d", this->get_name().c_str(), (int) fan_mode.size(), fan_mode.c_str(), fan_index); bool result = this->parent_->set_fan_index(fan_index); if (result) { @@ -236,7 +236,7 @@ void BedJetClimate::control(const ClimateCall &call) { void BedJetClimate::on_bedjet_state(bool is_ready) {} void BedJetClimate::on_status(const BedjetStatusPacket *data) { - ESP_LOGV(TAG, "[%s] Handling on_status with data=%p", LOG_STR_ARG(this->get_log_name()), (void *) data); + ESP_LOGV(TAG, "[%s] Handling on_status with data=%p", this->get_name().c_str(), (void *) data); auto converted_temp = bedjet_temp_to_c(data->target_temp_step); if (converted_temp > 0) @@ -310,11 +310,11 @@ void BedJetClimate::on_status(const BedjetStatusPacket *data) { break; default: - ESP_LOGW(TAG, "[%s] Unexpected mode: 0x%02X", LOG_STR_ARG(this->get_log_name()), data->mode); + ESP_LOGW(TAG, "[%s] Unexpected mode: 0x%02X", this->get_name().c_str(), data->mode); break; } - ESP_LOGV(TAG, "[%s] After on_status, new mode=%s", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "[%s] After on_status, new mode=%s", this->get_name().c_str(), LOG_STR_ARG(climate_mode_to_string(this->mode))); // FIXME: compare new state to previous state. this->publish_state(); @@ -351,11 +351,11 @@ bool BedJetClimate::update_status_() { } void BedJetClimate::update() { - ESP_LOGD(TAG, "[%s] update()", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "[%s] update()", this->get_name().c_str()); // TODO: if the hub component is already polling, do we also need to include polling? // We're already going to get on_status() at the hub's polling interval. auto result = this->update_status_(); - ESP_LOGD(TAG, "[%s] update_status result=%s", LOG_STR_ARG(this->get_log_name()), result ? "true" : "false"); + ESP_LOGD(TAG, "[%s] update_status result=%s", this->get_name().c_str(), result ? "true" : "false"); } } // namespace esphome::bedjet diff --git a/esphome/components/bedjet/fan/bedjet_fan.cpp b/esphome/components/bedjet/fan/bedjet_fan.cpp index 1f0762e40ce..4b1bd14ae34 100644 --- a/esphome/components/bedjet/fan/bedjet_fan.cpp +++ b/esphome/components/bedjet/fan/bedjet_fan.cpp @@ -53,7 +53,7 @@ void BedJetFan::control(const fan::FanCall &call) { } void BedJetFan::on_status(const BedjetStatusPacket *data) { - ESP_LOGVV(TAG, "[%s] Handling on_status with data=%p", LOG_STR_ARG(this->get_log_name()), (void *) data); + ESP_LOGVV(TAG, "[%s] Handling on_status with data=%p", this->get_name().c_str(), (void *) data); bool did_change = false; bool new_state = data->mode != MODE_STANDBY && data->mode != MODE_WAIT; @@ -96,11 +96,11 @@ bool BedJetFan::update_status_() { } void BedJetFan::update() { - ESP_LOGD(TAG, "[%s] update()", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "[%s] update()", this->get_name().c_str()); // TODO: if the hub component is already polling, do we also need to include polling? // We're already going to get on_status() at the hub's polling interval. auto result = this->update_status_(); - ESP_LOGD(TAG, "[%s] update_status result=%s", LOG_STR_ARG(this->get_log_name()), result ? "true" : "false"); + ESP_LOGD(TAG, "[%s] update_status result=%s", this->get_name().c_str(), result ? "true" : "false"); } /** Resets states to defaults. */ diff --git a/esphome/components/bh1750/bh1750.cpp b/esphome/components/bh1750/bh1750.cpp index ddd56d42147..2d9709f4228 100644 --- a/esphome/components/bh1750/bh1750.cpp +++ b/esphome/components/bh1750/bh1750.cpp @@ -75,7 +75,7 @@ void BH1750Sensor::dump_config() { LOG_SENSOR("", "BH1750", this); LOG_I2C_DEVICE(this); if (this->is_failed()) { - ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL_FOR, LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL_FOR, this->get_name().c_str()); } LOG_UPDATE_INTERVAL(this); @@ -154,7 +154,7 @@ void BH1750Sensor::loop() { break; } - ESP_LOGV(TAG, "'%s': Illuminance=%.1flx", LOG_STR_ARG(this->get_log_name()), lx); + ESP_LOGV(TAG, "'%s': Illuminance=%.1flx", this->get_name().c_str(), lx); this->status_clear_warning(); this->publish_state(lx); this->state_ = IDLE; diff --git a/esphome/components/binary_sensor/binary_sensor.cpp b/esphome/components/binary_sensor/binary_sensor.cpp index b4da1a15b6e..43915c4e17b 100644 --- a/esphome/components/binary_sensor/binary_sensor.cpp +++ b/esphome/components/binary_sensor/binary_sensor.cpp @@ -13,7 +13,7 @@ void log_binary_sensor(const char *tag, const char *prefix, const char *type, Bi return; } - ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, LOG_STR_ARG(obj->get_log_name())); + ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, obj->get_name().c_str()); LOG_ENTITY_DEVICE_CLASS(tag, prefix, *obj); } @@ -38,7 +38,7 @@ bool BinarySensor::set_new_state(const optional &new_state) { #if defined(USE_BINARY_SENSOR) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_binary_sensor_update(this); #endif - ESP_LOGV(TAG, "'%s' >> %s", LOG_STR_ARG(this->get_log_name()), ONOFFMAYBE(new_state)); + ESP_LOGV(TAG, "'%s' >> %s", this->get_name().c_str(), ONOFFMAYBE(new_state)); return true; } return false; diff --git a/esphome/components/binary_sensor_map/binary_sensor_map.cpp b/esphome/components/binary_sensor_map/binary_sensor_map.cpp index 78270046e06..4f00a85c8dd 100644 --- a/esphome/components/binary_sensor_map/binary_sensor_map.cpp +++ b/esphome/components/binary_sensor_map/binary_sensor_map.cpp @@ -47,7 +47,7 @@ void BinarySensorMap::process_group_() { } } else if (this->last_mask_ != 0ULL) { // no buttons are pressed and the states have changed since last run, so publish NAN - ESP_LOGV(TAG, "'%s' - No binary sensor active, publishing NAN", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' - No binary sensor active, publishing NAN", this->name_.c_str()); this->publish_state(NAN); } diff --git a/esphome/components/bl0940/bl0940.cpp b/esphome/components/bl0940/bl0940.cpp index 8698f1334d8..ac1386df03a 100644 --- a/esphome/components/bl0940/bl0940.cpp +++ b/esphome/components/bl0940/bl0940.cpp @@ -191,7 +191,7 @@ float BL0940::update_temp_(sensor::Sensor *sensor, uint16_le_t temperature) cons if (sensor != nullptr) { if (sensor->has_state() && std::abs(converted_temp - sensor->get_state()) > max_temperature_diff_) { ESP_LOGD(TAG, "Invalid temperature change. Sensor: '%s', Old temperature: %f, New temperature: %f", - LOG_STR_ARG(sensor->get_log_name()), sensor->get_state(), converted_temp); + sensor->get_name().c_str(), sensor->get_state(), converted_temp); return 0.0f; } sensor->publish_state(converted_temp); diff --git a/esphome/components/ble_client/sensor/ble_rssi_sensor.cpp b/esphome/components/ble_client/sensor/ble_rssi_sensor.cpp index f3f3b180fe9..69e7450dc20 100644 --- a/esphome/components/ble_client/sensor/ble_rssi_sensor.cpp +++ b/esphome/components/ble_client/sensor/ble_rssi_sensor.cpp @@ -63,7 +63,7 @@ void BLEClientRSSISensor::gap_event_handler(esp_gap_ble_cb_event_t event, esp_bl void BLEClientRSSISensor::update() { if (this->node_state != espbt::ClientState::ESTABLISHED) { - ESP_LOGW(TAG, "[%s] Cannot poll, not connected", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Cannot poll, not connected", this->get_name().c_str()); this->should_update_ = true; return; } diff --git a/esphome/components/ble_client/sensor/ble_sensor.cpp b/esphome/components/ble_client/sensor/ble_sensor.cpp index cca77e6fd79..1ddd50c3079 100644 --- a/esphome/components/ble_client/sensor/ble_sensor.cpp +++ b/esphome/components/ble_client/sensor/ble_sensor.cpp @@ -37,13 +37,13 @@ void BLESensor::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t ga switch (event) { case ESP_GATTC_OPEN_EVT: { if (param->open.status == ESP_GATT_OK) { - ESP_LOGI(TAG, "[%s] Connected successfully!", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "[%s] Connected successfully!", this->get_name().c_str()); break; } break; } case ESP_GATTC_CLOSE_EVT: { - ESP_LOGW(TAG, "[%s] Disconnected!", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Disconnected!", this->get_name().c_str()); this->status_set_warning(); this->publish_state(NAN); break; @@ -102,10 +102,10 @@ void BLESensor::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t ga } case ESP_GATTC_NOTIFY_EVT: { if (param->notify.value_len == 0) { - ESP_LOGW(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: empty value", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: empty value", this->get_name().c_str()); break; } - ESP_LOGD(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: handle=0x%x, value=0x%x", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: handle=0x%x, value=0x%x", this->get_name().c_str(), param->notify.handle, param->notify.value[0]); if (param->notify.handle != this->handle) break; @@ -143,11 +143,11 @@ float BLESensor::parse_data_(uint8_t *value, uint16_t value_len) { void BLESensor::update() { if (this->node_state != espbt::ClientState::ESTABLISHED) { - ESP_LOGW(TAG, "[%s] Cannot poll, not connected", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Cannot poll, not connected", this->get_name().c_str()); return; } if (this->handle == 0) { - ESP_LOGW(TAG, "[%s] Cannot poll, no service or characteristic found", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Cannot poll, no service or characteristic found", this->get_name().c_str()); return; } @@ -156,7 +156,7 @@ void BLESensor::update() { if (status) { this->status_set_warning(); this->publish_state(NAN); - ESP_LOGW(TAG, "[%s] Error sending read request for sensor, status=%d", LOG_STR_ARG(this->get_log_name()), status); + ESP_LOGW(TAG, "[%s] Error sending read request for sensor, status=%d", this->get_name().c_str(), status); } } diff --git a/esphome/components/ble_client/text_sensor/ble_text_sensor.cpp b/esphome/components/ble_client/text_sensor/ble_text_sensor.cpp index c82822d4296..f6df7b43364 100644 --- a/esphome/components/ble_client/text_sensor/ble_text_sensor.cpp +++ b/esphome/components/ble_client/text_sensor/ble_text_sensor.cpp @@ -38,7 +38,7 @@ void BLETextSensor::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_ switch (event) { case ESP_GATTC_OPEN_EVT: { if (param->open.status == ESP_GATT_OK) { - ESP_LOGI(TAG, "[%s] Connected successfully!", LOG_STR_ARG(this->get_log_name())); + ESP_LOGI(TAG, "[%s] Connected successfully!", this->get_name().c_str()); break; } break; @@ -104,10 +104,10 @@ void BLETextSensor::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_ if (param->notify.handle != this->handle) break; if (param->notify.value_len == 0) { - ESP_LOGW(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: empty value", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: empty value", this->get_name().c_str()); break; } - ESP_LOGV(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: handle=0x%x, value=0x%x", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "[%s] ESP_GATTC_NOTIFY_EVT: handle=0x%x, value=0x%x", this->get_name().c_str(), param->notify.handle, param->notify.value[0]); this->publish_state(reinterpret_cast(param->notify.value), param->notify.value_len); break; @@ -124,11 +124,11 @@ void BLETextSensor::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_ void BLETextSensor::update() { if (this->node_state != espbt::ClientState::ESTABLISHED) { - ESP_LOGW(TAG, "[%s] Cannot poll, not connected", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Cannot poll, not connected", this->get_name().c_str()); return; } if (this->handle == 0) { - ESP_LOGW(TAG, "[%s] Cannot poll, no service or characteristic found", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "[%s] Cannot poll, no service or characteristic found", this->get_name().c_str()); return; } @@ -137,7 +137,7 @@ void BLETextSensor::update() { if (status) { this->status_set_warning(); this->publish_state(""); - ESP_LOGW(TAG, "[%s] Error sending read request for sensor, status=%d", LOG_STR_ARG(this->get_log_name()), status); + ESP_LOGW(TAG, "[%s] Error sending read request for sensor, status=%d", this->get_name().c_str(), status); } } diff --git a/esphome/components/button/button.cpp b/esphome/components/button/button.cpp index 157693fffe9..e85ce60df6e 100644 --- a/esphome/components/button/button.cpp +++ b/esphome/components/button/button.cpp @@ -11,12 +11,12 @@ void log_button(const char *tag, const char *prefix, const char *type, Button *o return; } - ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, LOG_STR_ARG(obj->get_log_name())); + ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, obj->get_name().c_str()); LOG_ENTITY_ICON(tag, prefix, *obj); } void Button::press() { - ESP_LOGV(TAG, "'%s' Pressed.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' Pressed.", this->get_name().c_str()); this->press_action(); this->press_callback_.call(); } diff --git a/esphome/components/climate/climate.cpp b/esphome/components/climate/climate.cpp index 0403b5ad013..790307cec14 100644 --- a/esphome/components/climate/climate.cpp +++ b/esphome/components/climate/climate.cpp @@ -46,7 +46,7 @@ constexpr StringToUint8 CLIMATE_SWING_MODES_BY_STR[] = { void ClimateCall::perform() { this->parent_->control_callback_.call(*this); - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); this->validate_(); if (this->mode_.has_value()) { const LogString *mode_s = climate_mode_to_string(*this->mode_); @@ -183,7 +183,7 @@ ClimateCall &ClimateCall::set_mode(const char *mode, size_t len) { return *this; } } - ESP_LOGW(TAG, "'%s' - Unrecognized mode %.*s", LOG_STR_ARG(this->parent_->get_log_name()), (int) len, mode); + ESP_LOGW(TAG, "'%s' - Unrecognized mode %.*s", this->parent_->get_name().c_str(), (int) len, mode); return *this; } @@ -214,8 +214,7 @@ ClimateCall &ClimateCall::set_fan_mode(const char *custom_fan_mode, size_t len) this->fan_mode_.reset(); return *this; } - ESP_LOGW(TAG, "'%s' - Unrecognized fan mode %.*s", LOG_STR_ARG(this->parent_->get_log_name()), (int) len, - custom_fan_mode); + ESP_LOGW(TAG, "'%s' - Unrecognized fan mode %.*s", this->parent_->get_name().c_str(), (int) len, custom_fan_mode); return *this; } @@ -253,8 +252,7 @@ ClimateCall &ClimateCall::set_preset(const char *custom_preset, size_t len) { this->preset_.reset(); return *this; } - ESP_LOGW(TAG, "'%s' - Unrecognized preset %.*s", LOG_STR_ARG(this->parent_->get_log_name()), (int) len, - custom_preset); + ESP_LOGW(TAG, "'%s' - Unrecognized preset %.*s", this->parent_->get_name().c_str(), (int) len, custom_preset); return *this; } @@ -282,8 +280,7 @@ ClimateCall &ClimateCall::set_swing_mode(const char *swing_mode, size_t len) { return *this; } } - ESP_LOGW(TAG, "'%s' - Unrecognized swing mode %.*s", LOG_STR_ARG(this->parent_->get_log_name()), (int) len, - swing_mode); + ESP_LOGW(TAG, "'%s' - Unrecognized swing mode %.*s", this->parent_->get_name().c_str(), (int) len, swing_mode); return *this; } @@ -431,7 +428,7 @@ void Climate::save_state_(const ClimateTraits &traits) { void Climate::publish_state() { this->set_has_state(true); - ESP_LOGV(TAG, "'%s' >>", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' >>", this->name_.c_str()); auto traits = this->get_traits(); ESP_LOGV(TAG, " Mode: %s", LOG_STR_ARG(climate_mode_to_string(this->mode))); @@ -552,7 +549,7 @@ void ClimateDeviceRestoreState::apply(Climate *climate) { if (traits.supports_mode(this->mode)) { climate->mode = this->mode; } else { - ESP_LOGW(TAG, "'%s' - Saved mode %s is no longer supported, keeping %s", LOG_STR_ARG(climate->get_log_name()), + ESP_LOGW(TAG, "'%s' - Saved mode %s is no longer supported, keeping %s", climate->get_name().c_str(), LOG_STR_ARG(climate_mode_to_string(this->mode)), LOG_STR_ARG(climate_mode_to_string(climate->mode))); } if (traits.has_feature_flags(CLIMATE_SUPPORTS_TWO_POINT_TARGET_TEMPERATURE | diff --git a/esphome/components/climate/climate.h b/esphome/components/climate/climate.h index c6146f96aef..a9068972356 100644 --- a/esphome/components/climate/climate.h +++ b/esphome/components/climate/climate.h @@ -14,7 +14,7 @@ namespace esphome::climate { #define LOG_CLIMATE(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ } class Climate; diff --git a/esphome/components/combination/combination.cpp b/esphome/components/combination/combination.cpp index dcdabec8a27..0488fbb6ab2 100644 --- a/esphome/components/combination/combination.cpp +++ b/esphome/components/combination/combination.cpp @@ -30,14 +30,14 @@ void CombinationOneParameterComponent::add_source(Sensor *sensor, float value) { void CombinationNoParameterComponent::log_source_sensors() { ESP_LOGCONFIG(TAG, " Source Sensors:"); for (const auto &sensor : this->sensors_) { - ESP_LOGCONFIG(TAG, " - %s", LOG_STR_ARG(sensor->get_log_name())); + ESP_LOGCONFIG(TAG, " - %s", sensor->get_name().c_str()); } } void CombinationOneParameterComponent::log_source_sensors() { ESP_LOGCONFIG(TAG, " Source Sensors:"); for (const auto &source : this->sensor_sources_) { - ESP_LOGCONFIG(TAG, " - %s", LOG_STR_ARG(source.sensor->get_log_name())); + ESP_LOGCONFIG(TAG, " - %s", source.sensor->get_name().c_str()); } } diff --git a/esphome/components/cover/cover.cpp b/esphome/components/cover/cover.cpp index e71dd1c89f5..30e7f70b02b 100644 --- a/esphome/components/cover/cover.cpp +++ b/esphome/components/cover/cover.cpp @@ -39,7 +39,7 @@ CoverCall &CoverCall::set_command(const char *command) { } else if (ESPHOME_strcasecmp_P(command, ESPHOME_PSTR("TOGGLE")) == 0) { this->set_command_toggle(); } else { - ESP_LOGW(TAG, "'%s' - Unrecognized command %s", LOG_STR_ARG(this->parent_->get_log_name()), command); + ESP_LOGW(TAG, "'%s' - Unrecognized command %s", this->parent_->get_name().c_str(), command); } return *this; } @@ -68,7 +68,7 @@ CoverCall &CoverCall::set_tilt(float tilt) { return *this; } void CoverCall::perform() { - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); auto traits = this->parent_->get_traits(); this->validate_(); if (this->stop_) { @@ -94,7 +94,7 @@ const optional &CoverCall::get_tilt() const { return this->tilt_; } const optional &CoverCall::get_toggle() const { return this->toggle_; } void CoverCall::validate_() { auto traits = this->parent_->get_traits(); - const char *name = LOG_STR_ARG(this->parent_->get_log_name()); + const char *name = this->parent_->get_name().c_str(); if (this->position_.has_value()) { auto pos = *this->position_; @@ -139,7 +139,7 @@ void Cover::publish_state(bool save) { this->position = clamp(this->position, 0.0f, 1.0f); this->tilt = clamp(this->tilt, 0.0f, 1.0f); - ESP_LOGV(TAG, "'%s' >>", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' >>", this->name_.c_str()); auto traits = this->get_traits(); if (traits.get_supports_position()) { ESP_LOGV(TAG, " Position: %.0f%%", this->position * 100.0f); diff --git a/esphome/components/cover/cover.h b/esphome/components/cover/cover.h index d7f6df16d97..8bf45cfb579 100644 --- a/esphome/components/cover/cover.h +++ b/esphome/components/cover/cover.h @@ -15,7 +15,7 @@ static constexpr float COVER_CLOSED = 0.0f; #define LOG_COVER(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ auto traits_ = (obj)->get_traits(); \ if (traits_.get_is_assumed_state()) { \ ESP_LOGCONFIG(TAG, "%s Assumed State: YES", prefix); \ diff --git a/esphome/components/ct_clamp/ct_clamp_sensor.cpp b/esphome/components/ct_clamp/ct_clamp_sensor.cpp index 4c50c5ad045..6488c468c34 100644 --- a/esphome/components/ct_clamp/ct_clamp_sensor.cpp +++ b/esphome/components/ct_clamp/ct_clamp_sensor.cpp @@ -40,8 +40,7 @@ void CTClampSensor::update() { if (rms_ac_squared > 0) rms_ac = std::sqrt(rms_ac_squared); ESP_LOGD(TAG, "'%s' - Raw AC Value: %.3fA after %" PRIu32 " different samples (%" PRIu32 " SPS)", - LOG_STR_ARG(this->get_log_name()), rms_ac, this->num_samples_, - 1000 * this->num_samples_ / this->sample_duration_); + this->name_.c_str(), rms_ac, this->num_samples_, 1000 * this->num_samples_ / this->sample_duration_); this->publish_state(rms_ac); }); diff --git a/esphome/components/current_based/current_based_cover.cpp b/esphome/components/current_based/current_based_cover.cpp index 0c8e435fa23..04743975715 100644 --- a/esphome/components/current_based/current_based_cover.cpp +++ b/esphome/components/current_based/current_based_cover.cpp @@ -70,20 +70,20 @@ void CurrentBasedCover::loop() { this->direction_idle_(); this->malfunction_trigger_.trigger(); ESP_LOGI(TAG, "'%s' - Malfunction detected during opening. Current flow detected in close circuit", - LOG_STR_ARG(this->get_log_name())); + this->name_.c_str()); } else if (this->is_opening_blocked_()) { // Blocked - ESP_LOGD(TAG, "'%s' - Obstacle detected during opening.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Obstacle detected during opening.", this->name_.c_str()); this->direction_idle_(); if (this->obstacle_rollback_ != 0) { this->set_timeout(ROLLBACK_TIMEOUT_ID, 300, [this]() { - ESP_LOGD(TAG, "'%s' - Rollback.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Rollback.", this->name_.c_str()); this->target_position_ = clamp(this->position - this->obstacle_rollback_, 0.0F, 1.0F); this->start_direction_(COVER_OPERATION_CLOSING); }); } } else if (this->is_initial_delay_finished_() && !this->is_opening_()) { // End reached auto dur = (now - this->start_dir_time_) / 1e3f; - ESP_LOGD(TAG, "'%s' - Open position reached. Took %.1fs.", LOG_STR_ARG(this->get_log_name()), dur); + ESP_LOGD(TAG, "'%s' - Open position reached. Took %.1fs.", this->name_.c_str(), dur); this->direction_idle_(COVER_OPEN); } } else if (this->current_operation == COVER_OPERATION_CLOSING) { @@ -91,25 +91,25 @@ void CurrentBasedCover::loop() { this->direction_idle_(); this->malfunction_trigger_.trigger(); ESP_LOGI(TAG, "'%s' - Malfunction detected during closing. Current flow detected in open circuit", - LOG_STR_ARG(this->get_log_name())); + this->name_.c_str()); } else if (this->is_closing_blocked_()) { // Blocked - ESP_LOGD(TAG, "'%s' - Obstacle detected during closing.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Obstacle detected during closing.", this->name_.c_str()); this->direction_idle_(); if (this->obstacle_rollback_ != 0) { this->set_timeout(ROLLBACK_TIMEOUT_ID, 300, [this]() { - ESP_LOGD(TAG, "'%s' - Rollback.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Rollback.", this->name_.c_str()); this->target_position_ = clamp(this->position + this->obstacle_rollback_, 0.0F, 1.0F); this->start_direction_(COVER_OPERATION_OPENING); }); } } else if (this->is_initial_delay_finished_() && !this->is_closing_()) { // End reached auto dur = (now - this->start_dir_time_) / 1e3f; - ESP_LOGD(TAG, "'%s' - Close position reached. Took %.1fs.", LOG_STR_ARG(this->get_log_name()), dur); + ESP_LOGD(TAG, "'%s' - Close position reached. Took %.1fs.", this->name_.c_str(), dur); this->direction_idle_(COVER_CLOSED); } } if (now - this->start_dir_time_ > this->max_duration_) { - ESP_LOGD(TAG, "'%s' - Max duration reached. Stopping cover.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Max duration reached. Stopping cover.", this->name_.c_str()); this->direction_idle_(); } diff --git a/esphome/components/dallas_temp/dallas_temp.cpp b/esphome/components/dallas_temp/dallas_temp.cpp index c2c8336d1fb..45101e4981f 100644 --- a/esphome/components/dallas_temp/dallas_temp.cpp +++ b/esphome/components/dallas_temp/dallas_temp.cpp @@ -53,7 +53,7 @@ void DallasTemperatureSensor::update() { } float tempc = this->get_temp_c_(); - ESP_LOGD(TAG, "'%s': Got Temperature=%f°C", LOG_STR_ARG(this->get_log_name()), tempc); + ESP_LOGD(TAG, "'%s': Got Temperature=%f°C", this->get_name().c_str(), tempc); this->publish_state(tempc); }); } @@ -65,7 +65,7 @@ bool DallasTemperatureSensor::read_scratch_pad_() { i = this->bus_->read8(); } } else { - ESP_LOGW(TAG, "'%s' - reading scratch pad failed bus reset", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' - reading scratch pad failed bus reset", this->get_name().c_str()); this->status_set_warning(LOG_STR("bus reset failed")); } return success; diff --git a/esphome/components/datetime/date_entity.cpp b/esphome/components/datetime/date_entity.cpp index 91b7303d6c4..795d54afd90 100644 --- a/esphome/components/datetime/date_entity.cpp +++ b/esphome/components/datetime/date_entity.cpp @@ -30,7 +30,7 @@ void DateEntity::publish_state() { return; } this->set_has_state(true); - ESP_LOGV(TAG, "'%s' >> %d-%d-%d", LOG_STR_ARG(this->get_log_name()), this->year_, this->month_, this->day_); + ESP_LOGV(TAG, "'%s' >> %d-%d-%d", this->get_name().c_str(), this->year_, this->month_, this->day_); this->state_callback_.call(); #if defined(USE_DATETIME_DATE) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_date_update(this); @@ -81,7 +81,7 @@ void DateCall::validate_() { void DateCall::perform() { this->validate_(); - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); if (this->year_.has_value()) { ESP_LOGV(TAG, " Year: %d", *this->year_); diff --git a/esphome/components/datetime/date_entity.h b/esphome/components/datetime/date_entity.h index 83ef76ce275..9404d215120 100644 --- a/esphome/components/datetime/date_entity.h +++ b/esphome/components/datetime/date_entity.h @@ -14,7 +14,7 @@ namespace esphome::datetime { #define LOG_DATETIME_DATE(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ } diff --git a/esphome/components/datetime/datetime_entity.cpp b/esphome/components/datetime/datetime_entity.cpp index b3bb7c12eaa..6aa14163430 100644 --- a/esphome/components/datetime/datetime_entity.cpp +++ b/esphome/components/datetime/datetime_entity.cpp @@ -45,7 +45,7 @@ void DateTimeEntity::publish_state() { return; } this->set_has_state(true); - ESP_LOGV(TAG, "'%s' >> %04u-%02u-%02u %02d:%02d:%02d", LOG_STR_ARG(this->get_log_name()), this->year_, this->month_, + ESP_LOGV(TAG, "'%s' >> %04u-%02u-%02u %02d:%02d:%02d", this->get_name().c_str(), this->year_, this->month_, this->day_, this->hour_, this->minute_, this->second_); this->state_callback_.call(); #if defined(USE_DATETIME_DATETIME) && defined(USE_CONTROLLER_REGISTRY) @@ -125,7 +125,7 @@ void DateTimeCall::validate_() { void DateTimeCall::perform() { this->validate_(); - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); if (this->year_.has_value()) { ESP_LOGV(TAG, " Year: %d", *this->year_); diff --git a/esphome/components/datetime/datetime_entity.h b/esphome/components/datetime/datetime_entity.h index 75a677d67ba..57d305cb52b 100644 --- a/esphome/components/datetime/datetime_entity.h +++ b/esphome/components/datetime/datetime_entity.h @@ -14,7 +14,7 @@ namespace esphome::datetime { #define LOG_DATETIME_DATETIME(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ } diff --git a/esphome/components/datetime/time_entity.cpp b/esphome/components/datetime/time_entity.cpp index 8dcbe0ee1ca..ea1a97256cd 100644 --- a/esphome/components/datetime/time_entity.cpp +++ b/esphome/components/datetime/time_entity.cpp @@ -26,7 +26,7 @@ void TimeEntity::publish_state() { return; } this->set_has_state(true); - ESP_LOGV(TAG, "'%s' >> %02d:%02d:%02d", LOG_STR_ARG(this->get_log_name()), this->hour_, this->minute_, this->second_); + ESP_LOGV(TAG, "'%s' >> %02d:%02d:%02d", this->get_name().c_str(), this->hour_, this->minute_, this->second_); this->state_callback_.call(); #if defined(USE_DATETIME_TIME) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_time_update(this); @@ -50,7 +50,7 @@ void TimeCall::validate_() { void TimeCall::perform() { this->validate_(); - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); if (this->hour_.has_value()) { ESP_LOGV(TAG, " Hour: %d", *this->hour_); } diff --git a/esphome/components/datetime/time_entity.h b/esphome/components/datetime/time_entity.h index 64b3b331e99..fd31318ce5f 100644 --- a/esphome/components/datetime/time_entity.h +++ b/esphome/components/datetime/time_entity.h @@ -14,7 +14,7 @@ namespace esphome::datetime { #define LOG_DATETIME_TIME(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ } diff --git a/esphome/components/dew_point/dew_point.cpp b/esphome/components/dew_point/dew_point.cpp index 6c6a852334d..7012bcbb755 100644 --- a/esphome/components/dew_point/dew_point.cpp +++ b/esphome/components/dew_point/dew_point.cpp @@ -36,8 +36,7 @@ void DewPointComponent::dump_config() { "Sources\n" " Temperature: '%s'\n" " Humidity: '%s'", - LOG_STR_ARG(this->temperature_sensor_->get_log_name()), - LOG_STR_ARG(this->humidity_sensor_->get_log_name())); + this->temperature_sensor_->get_name().c_str(), this->humidity_sensor_->get_name().c_str()); } float DewPointComponent::get_setup_priority() const { return setup_priority::DATA; } @@ -76,8 +75,8 @@ void DewPointComponent::loop() { // Publish the calculated dew point this->publish_state(dew_point); - ESP_LOGD(TAG, "'%s' >> %.1f°C (T: %.1f°C, RH: %.1f%%)", LOG_STR_ARG(this->get_log_name()), dew_point, - this->temperature_value_, this->humidity_value_); + ESP_LOGD(TAG, "'%s' >> %.1f°C (T: %.1f°C, RH: %.1f%%)", this->get_name().c_str(), dew_point, this->temperature_value_, + this->humidity_value_); } } // namespace esphome::dew_point diff --git a/esphome/components/duty_cycle/duty_cycle_sensor.cpp b/esphome/components/duty_cycle/duty_cycle_sensor.cpp index 9c986192b1d..69a41eb548d 100644 --- a/esphome/components/duty_cycle/duty_cycle_sensor.cpp +++ b/esphome/components/duty_cycle/duty_cycle_sensor.cpp @@ -36,7 +36,7 @@ void DutyCycleSensor::update() { const float total_time = float(now - this->last_update_); const float value = (on_time * 100.0f) / total_time; - ESP_LOGD(TAG, "'%s' Got duty cycle=%.1f%%", LOG_STR_ARG(this->get_log_name()), value); + ESP_LOGD(TAG, "'%s' Got duty cycle=%.1f%%", this->get_name().c_str(), value); this->publish_state(value); } this->last_update_ = now; diff --git a/esphome/components/endstop/endstop_cover.cpp b/esphome/components/endstop/endstop_cover.cpp index 991f0d8f666..25b5b542092 100644 --- a/esphome/components/endstop/endstop_cover.cpp +++ b/esphome/components/endstop/endstop_cover.cpp @@ -70,20 +70,20 @@ void EndstopCover::loop() { if (this->current_operation == COVER_OPERATION_OPENING && this->is_open_()) { float dur = (now - this->start_dir_time_) / 1e3f; - ESP_LOGD(TAG, "'%s' - Open endstop reached. Took %.1fs.", LOG_STR_ARG(this->get_log_name()), dur); + ESP_LOGD(TAG, "'%s' - Open endstop reached. Took %.1fs.", this->name_.c_str(), dur); this->start_direction_(COVER_OPERATION_IDLE); this->position = COVER_OPEN; this->publish_state(); } else if (this->current_operation == COVER_OPERATION_CLOSING && this->is_closed_()) { float dur = (now - this->start_dir_time_) / 1e3f; - ESP_LOGD(TAG, "'%s' - Close endstop reached. Took %.1fs.", LOG_STR_ARG(this->get_log_name()), dur); + ESP_LOGD(TAG, "'%s' - Close endstop reached. Took %.1fs.", this->name_.c_str(), dur); this->start_direction_(COVER_OPERATION_IDLE); this->position = COVER_CLOSED; this->publish_state(); } else if (now - this->start_dir_time_ > this->max_duration_) { - ESP_LOGD(TAG, "'%s' - Max duration reached. Stopping cover.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Max duration reached. Stopping cover.", this->name_.c_str()); this->start_direction_(COVER_OPERATION_IDLE); this->publish_state(); } diff --git a/esphome/components/esp32_camera/esp32_camera.cpp b/esphome/components/esp32_camera/esp32_camera.cpp index b14d76b904d..ef29fc9b25d 100644 --- a/esphome/components/esp32_camera/esp32_camera.cpp +++ b/esphome/components/esp32_camera/esp32_camera.cpp @@ -132,9 +132,9 @@ void ESP32Camera::dump_config() { " External Clock: Pin:%d Frequency:%u\n" " I2C Pins: SDA:%d SCL:%d\n" " Reset Pin: %d", - LOG_STR_ARG(this->get_log_name()), YESNO(this->is_internal()), conf.pin_d0, conf.pin_d1, conf.pin_d2, - conf.pin_d3, conf.pin_d4, conf.pin_d5, conf.pin_d6, conf.pin_d7, conf.pin_vsync, conf.pin_href, - conf.pin_pclk, conf.pin_xclk, conf.xclk_freq_hz, conf.pin_sccb_sda, conf.pin_sccb_scl, conf.pin_reset); + this->name_.c_str(), YESNO(this->is_internal()), conf.pin_d0, conf.pin_d1, conf.pin_d2, conf.pin_d3, + conf.pin_d4, conf.pin_d5, conf.pin_d6, conf.pin_d7, conf.pin_vsync, conf.pin_href, conf.pin_pclk, + conf.pin_xclk, conf.xclk_freq_hz, conf.pin_sccb_sda, conf.pin_sccb_scl, conf.pin_reset); ESP_LOGCONFIG(TAG, " Resolution: %s", frame_size_to_str(this->config_.frame_size)); ESP_LOGCONFIG(TAG, " Pixel Format: %s", pixel_format_to_str(this->config_.pixel_format)); diff --git a/esphome/components/esp32_touch/esp32_touch.cpp b/esphome/components/esp32_touch/esp32_touch.cpp index 2de201ccf7a..ed7d0bd7cb2 100644 --- a/esphome/components/esp32_touch/esp32_touch.cpp +++ b/esphome/components/esp32_touch/esp32_touch.cpp @@ -346,13 +346,13 @@ void ESP32TouchComponent::loop() { child->publish_state(new_state); #ifdef USE_ESP32_VARIANT_ESP32 ESP_LOGV(TAG, "Touch Pad '%s' state: %s (value: %" PRIu32 ", threshold: %" PRIu32 ")", - LOG_STR_ARG(child->get_log_name()), ONOFF(new_state), value, child->get_threshold()); + child->get_name().c_str(), ONOFF(new_state), value, child->get_threshold()); #else if (new_state) { ESP_LOGV(TAG, "Touch Pad '%s' state: ON (value: %" PRIu32 ", benchmark: %" PRIu32 ", threshold: %" PRIu32 ")", - LOG_STR_ARG(child->get_log_name()), value, benchmark, child->get_threshold()); + child->get_name().c_str(), value, benchmark, child->get_threshold()); } else { - ESP_LOGV(TAG, "Touch Pad '%s' state: OFF", LOG_STR_ARG(child->get_log_name())); + ESP_LOGV(TAG, "Touch Pad '%s' state: OFF", child->get_name().c_str()); } #endif } @@ -475,8 +475,7 @@ void ESP32TouchComponent::process_setup_mode_logging_(uint32_t now) { child->value_ = smooth_value; #ifdef USE_ESP32_VARIANT_ESP32 - ESP_LOGD(TAG, "Touch Pad '%s' (Ch%d): %" PRIu32, LOG_STR_ARG(child->get_log_name()), child->channel_id_, - smooth_value); + ESP_LOGD(TAG, "Touch Pad '%s' (Ch%d): %" PRIu32, child->get_name().c_str(), child->channel_id_, smooth_value); #else uint32_t benchmark = 0; touch_channel_read_data(child->chan_handle_, TOUCH_CHAN_DATA_TYPE_BENCHMARK, &benchmark); @@ -485,7 +484,7 @@ void ESP32TouchComponent::process_setup_mode_logging_(uint32_t now) { ESP_LOGD(TAG, "Touch Pad '%s' (Ch%d): value=%" PRIu32 ", benchmark=%" PRIu32 ", difference=%" PRId32 " (set threshold < %" PRId32 " to detect touch)", - LOG_STR_ARG(child->get_log_name()), child->channel_id_, smooth_value, benchmark, difference, difference); + child->get_name().c_str(), child->channel_id_, smooth_value, benchmark, difference, difference); #endif } this->setup_mode_last_log_print_ = now; @@ -497,7 +496,7 @@ void ESP32TouchComponent::publish_initial_state_if_needed_(ESP32TouchBinarySenso if (now > INITIAL_STATE_DELAY_MS) { child->publish_initial_state(false); child->initial_state_published_ = true; - ESP_LOGV(TAG, "Touch Pad '%s' state: OFF (initial)", LOG_STR_ARG(child->get_log_name())); + ESP_LOGV(TAG, "Touch Pad '%s' state: OFF (initial)", child->get_name().c_str()); } } } diff --git a/esphome/components/event/event.cpp b/esphome/components/event/event.cpp index 70d48e0c2e9..671e11e7d21 100644 --- a/esphome/components/event/event.cpp +++ b/esphome/components/event/event.cpp @@ -17,11 +17,11 @@ void Event::trigger(const char *event_type) { } } if (found == nullptr) { - ESP_LOGE(TAG, "'%s': invalid event type for trigger(): %s", LOG_STR_ARG(this->get_log_name()), event_type); + ESP_LOGE(TAG, "'%s': invalid event type for trigger(): %s", this->get_name().c_str(), event_type); return; } this->last_event_type_ = found; - ESP_LOGV(TAG, "'%s' >> '%s'", LOG_STR_ARG(this->get_log_name()), this->last_event_type_); + ESP_LOGV(TAG, "'%s' >> '%s'", this->get_name().c_str(), this->last_event_type_); this->event_callback_.call(StringRef(found)); #if defined(USE_EVENT) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_event(this); diff --git a/esphome/components/event/event.h b/esphome/components/event/event.h index 2671b10b3ac..203ee52ac8e 100644 --- a/esphome/components/event/event.h +++ b/esphome/components/event/event.h @@ -16,7 +16,7 @@ using EventTypes = ConstVector; #define LOG_EVENT(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ LOG_ENTITY_DEVICE_CLASS(TAG, prefix, *(obj)); \ } diff --git a/esphome/components/fan/fan.cpp b/esphome/components/fan/fan.cpp index c2023780643..866f5eb0cda 100644 --- a/esphome/components/fan/fan.cpp +++ b/esphome/components/fan/fan.cpp @@ -52,15 +52,14 @@ FanCall &FanCall::set_preset_mode(const char *preset_mode, size_t len) { this->preset_mode_ = validated_mode; // Store pointer from traits } else { // Preset mode not found in traits - log warning and don't set - ESP_LOGW(TAG, "%s: Preset mode '%.*s' not supported", LOG_STR_ARG(this->parent_.get_log_name()), (int) len, - preset_mode); + ESP_LOGW(TAG, "%s: Preset mode '%.*s' not supported", this->parent_.get_name().c_str(), (int) len, preset_mode); this->preset_mode_ = nullptr; } return *this; } void FanCall::perform() { - ESP_LOGV(TAG, "'%s' - Setting:", LOG_STR_ARG(this->parent_.get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting:", this->parent_.get_name().c_str()); this->validate_(); if (this->binary_state_.has_value()) { ESP_LOGV(TAG, " State: %s", ONOFF(*this->binary_state_)); @@ -104,17 +103,17 @@ void FanCall::validate_() { } if (this->oscillating_.has_value() && !traits.supports_oscillation()) { - ESP_LOGW(TAG, "%s: Oscillation not supported", LOG_STR_ARG(this->parent_.get_log_name())); + ESP_LOGW(TAG, "%s: Oscillation not supported", this->parent_.get_name().c_str()); this->oscillating_.reset(); } if (this->speed_.has_value() && !traits.supports_speed()) { - ESP_LOGW(TAG, "%s: Speed control not supported", LOG_STR_ARG(this->parent_.get_log_name())); + ESP_LOGW(TAG, "%s: Speed control not supported", this->parent_.get_name().c_str()); this->speed_.reset(); } if (this->direction_.has_value() && !traits.supports_direction()) { - ESP_LOGW(TAG, "%s: Direction control not supported", LOG_STR_ARG(this->parent_.get_log_name())); + ESP_LOGW(TAG, "%s: Direction control not supported", this->parent_.get_name().c_str()); this->direction_.reset(); } } @@ -222,7 +221,7 @@ void Fan::publish_state() { ESP_LOGV(TAG, "'%s' >>\n" " State: %s", - LOG_STR_ARG(this->get_log_name()), ONOFF(this->state)); + this->name_.c_str(), ONOFF(this->state)); if (traits.supports_speed()) { ESP_LOGV(TAG, " Speed: %d", this->speed); } diff --git a/esphome/components/fan/fan.h b/esphome/components/fan/fan.h index 150d143dbeb..7e21971639e 100644 --- a/esphome/components/fan/fan.h +++ b/esphome/components/fan/fan.h @@ -12,7 +12,7 @@ namespace esphome::fan { #define LOG_FAN(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ (obj)->dump_traits_(TAG, prefix); \ } diff --git a/esphome/components/feedback/feedback_cover.cpp b/esphome/components/feedback/feedback_cover.cpp index d59c3d1e745..8fa56bd370e 100644 --- a/esphome/components/feedback/feedback_cover.cpp +++ b/esphome/components/feedback/feedback_cover.cpp @@ -98,7 +98,7 @@ void FeedbackCover::set_open_sensor(binary_sensor::BinarySensor *open_feedback) // setup callbacks to react to sensor changes open_feedback->add_on_state_callback([this](bool state) { - ESP_LOGD(TAG, "'%s' - Open feedback '%s'.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - Open feedback '%s'.", this->name_.c_str(), state ? LOG_STR_LITERAL("STARTED") : LOG_STR_LITERAL("ENDED")); this->recompute_position_(); if (!state && this->infer_endstop_ && this->current_trigger_operation_ == COVER_OPERATION_OPENING) { @@ -112,7 +112,7 @@ void FeedbackCover::set_close_sensor(binary_sensor::BinarySensor *close_feedback this->close_feedback_ = close_feedback; close_feedback->add_on_state_callback([this](bool state) { - ESP_LOGD(TAG, "'%s' - Close feedback '%s'.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - Close feedback '%s'.", this->name_.c_str(), state ? LOG_STR_LITERAL("STARTED") : LOG_STR_LITERAL("ENDED")); this->recompute_position_(); if (!state && this->infer_endstop_ && this->current_trigger_operation_ == COVER_OPERATION_CLOSING) { @@ -151,7 +151,7 @@ void FeedbackCover::endstop_reached_(bool open_endstop) { // from a position slightly past the endpoint if (this->current_trigger_operation_ == (open_endstop ? COVER_OPERATION_OPENING : COVER_OPERATION_CLOSING)) { float dur = (now - this->start_dir_time_) / 1e3f; - ESP_LOGD(TAG, "'%s' - %s endstop reached. Took %.1fs.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - %s endstop reached. Took %.1fs.", this->name_.c_str(), open_endstop ? LOG_STR_LITERAL("Open") : LOG_STR_LITERAL("Close"), dur); // if there is no external mechanism, stop the cover @@ -198,7 +198,7 @@ void FeedbackCover::set_close_obstacle_sensor(binary_sensor::BinarySensor *close close_obstacle->add_on_state_callback([this](bool state) { if (state && (this->current_operation == COVER_OPERATION_CLOSING || this->current_trigger_operation_ == COVER_OPERATION_CLOSING)) { - ESP_LOGD(TAG, "'%s' - Close obstacle detected.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Close obstacle detected.", this->name_.c_str()); this->start_direction_(COVER_OPERATION_IDLE); if (this->obstacle_rollback_) { @@ -215,7 +215,7 @@ void FeedbackCover::set_open_obstacle_sensor(binary_sensor::BinarySensor *open_o open_obstacle->add_on_state_callback([this](bool state) { if (state && (this->current_operation == COVER_OPERATION_OPENING || this->current_trigger_operation_ == COVER_OPERATION_OPENING)) { - ESP_LOGD(TAG, "'%s' - Open obstacle detected.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Open obstacle detected.", this->name_.c_str()); this->start_direction_(COVER_OPERATION_IDLE); if (this->obstacle_rollback_) { @@ -251,7 +251,7 @@ void FeedbackCover::loop() { this->start_overshoot_time_ = now; } else if (now - this->start_overshoot_time_ > this->overshoot_duration_ || now - this->start_dir_time_ > this->max_duration_) { - ESP_LOGD(TAG, "'%s' - Overshoot duration reached. Stopping cover.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Overshoot duration reached. Stopping cover.", this->name_.c_str()); this->start_direction_(COVER_OPERATION_IDLE); } #endif @@ -259,7 +259,7 @@ void FeedbackCover::loop() { this->start_direction_(COVER_OPERATION_IDLE); } } else if (now - this->start_dir_time_ > this->max_duration_) { - ESP_LOGD(TAG, "'%s' - Max duration reached. Stopping cover.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Max duration reached. Stopping cover.", this->name_.c_str()); this->start_direction_(COVER_OPERATION_IDLE); } } @@ -390,7 +390,7 @@ void FeedbackCover::start_direction_(CoverOperation dir) { // check if there is an obstacle to start the new operation -> abort without any change // the case when an obstacle appears while moving is handled in the callback if (obstacle != nullptr && obstacle->state) { - ESP_LOGD(TAG, "'%s' - %s obstacle detected. Action not started.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - %s obstacle detected. Action not started.", this->name_.c_str(), dir == COVER_OPERATION_OPENING ? LOG_STR_LITERAL("Open") : LOG_STR_LITERAL("Close")); return; } @@ -401,13 +401,13 @@ void FeedbackCover::start_direction_(CoverOperation dir) { if (this->direction_change_waittime_.has_value() && dir != COVER_OPERATION_IDLE && this->current_operation != COVER_OPERATION_IDLE && dir != this->current_operation) { const uint32_t waittime = *this->direction_change_waittime_; - ESP_LOGD(TAG, "'%s' - Reversing direction.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Reversing direction.", this->name_.c_str()); this->start_direction_(COVER_OPERATION_IDLE); this->set_timeout(DIRECTION_CHANGE_TIMEOUT_ID, waittime, [this, dir]() { this->start_direction_(dir); }); } else { this->set_current_operation_(dir, true); this->prev_command_trigger_ = trig; - ESP_LOGD(TAG, "'%s' - Firing '%s' trigger.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - Firing '%s' trigger.", this->name_.c_str(), dir == COVER_OPERATION_OPENING ? LOG_STR_LITERAL("OPEN") : dir == COVER_OPERATION_CLOSING ? LOG_STR_LITERAL("CLOSE") : LOG_STR_LITERAL("STOP")); diff --git a/esphome/components/gpio/switch/gpio_switch.cpp b/esphome/components/gpio/switch/gpio_switch.cpp index 4626916606a..68086d94660 100644 --- a/esphome/components/gpio/switch/gpio_switch.cpp +++ b/esphome/components/gpio/switch/gpio_switch.cpp @@ -28,7 +28,7 @@ void GPIOSwitch::dump_config() { for (auto *lock : this->interlock_) { if (lock == this) continue; - ESP_LOGCONFIG(TAG, " %s", LOG_STR_ARG(lock->get_log_name())); + ESP_LOGCONFIG(TAG, " %s", lock->get_name().c_str()); } } #endif diff --git a/esphome/components/he60r/he60r.cpp b/esphome/components/he60r/he60r.cpp index 3e9aa3c8e6f..7c67c5ffd3f 100644 --- a/esphome/components/he60r/he60r.cpp +++ b/esphome/components/he60r/he60r.cpp @@ -58,7 +58,7 @@ void HE60rCover::endstop_reached_(CoverOperation operation) { this->current_operation = COVER_OPERATION_IDLE; if (this->last_command_ == operation) { float dur = (float) (now - this->start_dir_time_) / 1e3f; - ESP_LOGD(TAG, "'%s' - %s endstop reached. Took %.1fs.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - %s endstop reached. Took %.1fs.", this->name_.c_str(), operation == COVER_OPERATION_OPENING ? LOG_STR_LITERAL("Open") : LOG_STR_LITERAL("Close"), dur); } this->publish_state(); @@ -213,7 +213,7 @@ void HE60rCover::start_direction_(CoverOperation dir) { this->last_command_ = dir; if (this->current_operation == dir) return; - ESP_LOGD(TAG, "'%s' - Direction '%s' requested.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "'%s' - Direction '%s' requested.", this->name_.c_str(), dir == COVER_OPERATION_OPENING ? LOG_STR_LITERAL("OPEN") : dir == COVER_OPERATION_CLOSING ? LOG_STR_LITERAL("CLOSE") : LOG_STR_LITERAL("STOP")); @@ -229,7 +229,7 @@ void HE60rCover::start_direction_(CoverOperation dir) { // just stop and reverse this->toggles_needed_ = 2; } - ESP_LOGD(TAG, "'%s' - Reversing direction.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Reversing direction.", this->name_.c_str()); } this->start_dir_time_ = millis(); } diff --git a/esphome/components/homeassistant/button/homeassistant_button.cpp b/esphome/components/homeassistant/button/homeassistant_button.cpp index 85ed0c42e99..6cf1c87eaa5 100644 --- a/esphome/components/homeassistant/button/homeassistant_button.cpp +++ b/esphome/components/homeassistant/button/homeassistant_button.cpp @@ -26,7 +26,7 @@ void HomeassistantButton::press_action() { #ifdef USE_API_WIZARD_LINKED_INPUTS if (this->entity_id_[0] == '\0') { - ESP_LOGW(TAG, "'%s': No entity ID set yet", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s': No entity ID set yet", this->get_name().c_str()); return; } #endif diff --git a/esphome/components/homeassistant/number/homeassistant_number.cpp b/esphome/components/homeassistant/number/homeassistant_number.cpp index fabe2d87364..df92aad38eb 100644 --- a/esphome/components/homeassistant/number/homeassistant_number.cpp +++ b/esphome/components/homeassistant/number/homeassistant_number.cpp @@ -31,7 +31,7 @@ void HomeassistantNumber::min_retrieved_(StringRef min) { ESP_LOGE(TAG, "'%s': Can't convert 'min' value '%s' to number!", this->entity_id_, min.c_str()); return; } - ESP_LOGD(TAG, "'%s': Min retrieved: %s", LOG_STR_ARG(this->get_log_name()), min.c_str()); + ESP_LOGD(TAG, "'%s': Min retrieved: %s", get_name().c_str(), min.c_str()); this->traits.set_min_value(min_value.value()); } @@ -41,7 +41,7 @@ void HomeassistantNumber::max_retrieved_(StringRef max) { ESP_LOGE(TAG, "'%s': Can't convert 'max' value '%s' to number!", this->entity_id_, max.c_str()); return; } - ESP_LOGD(TAG, "'%s': Max retrieved: %s", LOG_STR_ARG(this->get_log_name()), max.c_str()); + ESP_LOGD(TAG, "'%s': Max retrieved: %s", get_name().c_str(), max.c_str()); this->traits.set_max_value(max_value.value()); } @@ -51,7 +51,7 @@ void HomeassistantNumber::step_retrieved_(StringRef step) { ESP_LOGE(TAG, "'%s': Can't convert 'step' value '%s' to number!", this->entity_id_, step.c_str()); return; } - ESP_LOGD(TAG, "'%s': Step Retrieved %s", LOG_STR_ARG(this->get_log_name()), step.c_str()); + ESP_LOGD(TAG, "'%s': Step Retrieved %s", get_name().c_str(), step.c_str()); this->traits.set_step(step_value.value()); } @@ -82,7 +82,7 @@ void HomeassistantNumber::control(float value) { #ifdef USE_API_WIZARD_LINKED_INPUTS if (this->entity_id_[0] == '\0') { - ESP_LOGW(TAG, "'%s': No entity ID set yet", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s': No entity ID set yet", this->get_name().c_str()); return; } #endif diff --git a/esphome/components/homeassistant/select/homeassistant_select.cpp b/esphome/components/homeassistant/select/homeassistant_select.cpp index f8e658ac8f6..189a6b1f376 100644 --- a/esphome/components/homeassistant/select/homeassistant_select.cpp +++ b/esphome/components/homeassistant/select/homeassistant_select.cpp @@ -232,7 +232,7 @@ void HomeassistantSelect::control(size_t index) { #ifdef USE_API_WIZARD_LINKED_INPUTS if (this->entity_id_[0] == '\0') { - ESP_LOGW(TAG, "'%s': No entity ID set yet", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s': No entity ID set yet", this->get_name().c_str()); return; } #endif diff --git a/esphome/components/homeassistant/switch/homeassistant_switch.cpp b/esphome/components/homeassistant/switch/homeassistant_switch.cpp index 584573d8818..841f16df200 100644 --- a/esphome/components/homeassistant/switch/homeassistant_switch.cpp +++ b/esphome/components/homeassistant/switch/homeassistant_switch.cpp @@ -42,7 +42,7 @@ void HomeassistantSwitch::write_state(bool state) { #ifdef USE_API_WIZARD_LINKED_INPUTS if (this->entity_id_[0] == '\0') { - ESP_LOGW(TAG, "'%s': No entity ID set yet", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s': No entity ID set yet", this->get_name().c_str()); return; } #endif diff --git a/esphome/components/homeassistant/text/homeassistant_text.cpp b/esphome/components/homeassistant/text/homeassistant_text.cpp index 6c006224dc6..7155f6ee189 100644 --- a/esphome/components/homeassistant/text/homeassistant_text.cpp +++ b/esphome/components/homeassistant/text/homeassistant_text.cpp @@ -81,7 +81,7 @@ void HomeassistantText::control(const std::string &value) { #ifdef USE_API_WIZARD_LINKED_INPUTS if (this->entity_id_[0] == '\0') { - ESP_LOGW(TAG, "'%s': No entity ID set yet", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s': No entity ID set yet", this->get_name().c_str()); return; } #endif diff --git a/esphome/components/hx711/hx711.cpp b/esphome/components/hx711/hx711.cpp index bccafa29b80..48afc0192de 100644 --- a/esphome/components/hx711/hx711.cpp +++ b/esphome/components/hx711/hx711.cpp @@ -25,7 +25,7 @@ void HX711Sensor::update() { uint32_t result; if (this->read_sensor_(&result)) { int32_t value = static_cast(result); - ESP_LOGD(TAG, "'%s': Got value %" PRId32, LOG_STR_ARG(this->get_log_name()), value); + ESP_LOGD(TAG, "'%s': Got value %" PRId32, this->name_.c_str(), value); this->publish_state(value); } } diff --git a/esphome/components/infrared/infrared.cpp b/esphome/components/infrared/infrared.cpp index 78077af8fb8..9b766a8996c 100644 --- a/esphome/components/infrared/infrared.cpp +++ b/esphome/components/infrared/infrared.cpp @@ -11,7 +11,7 @@ void Infrared::dump_config() { "Infrared '%s'\n" " Supports Transmitter: %s\n" " Supports Receiver: %s", - LOG_STR_ARG(this->get_log_name()), YESNO(this->get_supports_transmitter()), + this->get_name().c_str(), YESNO(this->get_supports_transmitter()), YESNO(this->get_supports_receiver())); } diff --git a/esphome/components/ir_rf_base/ir_rf_base.cpp b/esphome/components/ir_rf_base/ir_rf_base.cpp index 4bfdc7b7ef6..91db4252c07 100644 --- a/esphome/components/ir_rf_base/ir_rf_base.cpp +++ b/esphome/components/ir_rf_base/ir_rf_base.cpp @@ -143,7 +143,7 @@ bool IrRfEntity::expect_api_reply_(api::APIConnection *conn) { if (this->api_reply_ == ApiReply::API_REPLY_WAITING) this->finish_api_reply_(false); if (this->api_reply_ != ApiReply::API_REPLY_NONE && !this->send_api_reply_()) { - ESP_LOGW(TAG, "'%s': transmit %s", LOG_STR_ARG(this->get_log_name()), LOG_STR_LITERAL("refused, reply still owed")); + ESP_LOGW(TAG, "'%s': transmit %s", this->get_name().c_str(), LOG_STR_LITERAL("refused, reply still owed")); this->refuse_api_call_(conn); return false; } @@ -198,14 +198,13 @@ void IrRfEntity::loop() { if (this->api_reply_ != ApiReply::API_REPLY_WAITING) { if (this->send_api_reply_() || remaining > 0) return; - ESP_LOGW(TAG, "'%s': transmit %s", LOG_STR_ARG(this->get_log_name()), - LOG_STR_LITERAL("reply dropped, client not reading")); + ESP_LOGW(TAG, "'%s': transmit %s", this->get_name().c_str(), LOG_STR_LITERAL("reply dropped, client not reading")); this->clear_api_reply_(); return; } if (remaining > 0) return; - ESP_LOGW(TAG, "'%s': transmit %s", LOG_STR_ARG(this->get_log_name()), LOG_STR_LITERAL("never reported completion")); + ESP_LOGW(TAG, "'%s': transmit %s", this->get_name().c_str(), LOG_STR_LITERAL("never reported completion")); this->finish_api_reply_(false); } diff --git a/esphome/components/ir_rf_proxy/ir_rf_proxy.cpp b/esphome/components/ir_rf_proxy/ir_rf_proxy.cpp index c88f1315916..0eae11d1a51 100644 --- a/esphome/components/ir_rf_proxy/ir_rf_proxy.cpp +++ b/esphome/components/ir_rf_proxy/ir_rf_proxy.cpp @@ -17,7 +17,7 @@ void IrRfProxy::dump_config() { "IR Proxy '%s'\n" " Supports Transmitter: %s\n" " Supports Receiver: %s", - LOG_STR_ARG(this->get_log_name()), YESNO(this->get_supports_transmitter()), + this->get_name().c_str(), YESNO(this->get_supports_transmitter()), YESNO(this->get_supports_receiver())); if (this->is_rf()) { @@ -44,7 +44,7 @@ void RfProxy::dump_config() { "RF Proxy '%s'\n" " Supports Transmitter: %s\n" " Supports Receiver: %s", - LOG_STR_ARG(this->get_log_name()), YESNO(this->get_supports_transmitter()), + this->get_name().c_str(), YESNO(this->get_supports_transmitter()), YESNO(this->get_supports_receiver())); const auto &traits = this->traits_; diff --git a/esphome/components/ld6002b/ld6002b.cpp b/esphome/components/ld6002b/ld6002b.cpp index 59010ed9102..93a2ea341f4 100644 --- a/esphome/components/ld6002b/ld6002b.cpp +++ b/esphome/components/ld6002b/ld6002b.cpp @@ -1058,8 +1058,8 @@ void LD6002BComponent::publish_number_clamped_(number::Number *number, float val // Outside the declared range the user cannot write the value back, so publish // what they can reach and say what the module actually sent. if (value < min_value || value > max_value) { - ESP_LOGW(TAG, "'%s': module reported %.1f, clamped to %.1f..%.1f", LOG_STR_ARG(number->get_log_name()), value, - min_value, max_value); + ESP_LOGW(TAG, "'%s': module reported %.1f, clamped to %.1f..%.1f", number->get_name().c_str(), value, min_value, + max_value); value = std::clamp(value, min_value, max_value); } number->publish_state(value); diff --git a/esphome/components/light/addressable_light.cpp b/esphome/components/light/addressable_light.cpp index 86faac3a08b..a6440700fa9 100644 --- a/esphome/components/light/addressable_light.cpp +++ b/esphome/components/light/addressable_light.cpp @@ -10,7 +10,7 @@ void AddressableLight::call_setup() { #ifdef ESPHOME_LOG_HAS_VERY_VERBOSE this->set_interval(5000, [this]() { - const char *name = this->state_parent_ == nullptr ? "" : LOG_STR_ARG(this->state_parent_->get_log_name()); + const char *name = this->state_parent_ == nullptr ? "" : this->state_parent_->get_name().c_str(); ESP_LOGVV(TAG, "Addressable Light '%s' (effect_active=%s)", name, YESNO(this->effect_active_)); for (int i = 0; i < this->size(); i++) { auto color = this->get(i); diff --git a/esphome/components/light/light_call.cpp b/esphome/components/light/light_call.cpp index e8a5aae50e9..0970c513a29 100644 --- a/esphome/components/light/light_call.cpp +++ b/esphome/components/light/light_call.cpp @@ -74,7 +74,7 @@ static void log_percent(const LogString *param, float value) { #endif void LightCall::perform() { - const char *name = LOG_STR_ARG(this->parent_->get_log_name()); + const char *name = this->parent_->get_name().c_str(); LightColorValues v = this->validate_(); const bool publish = this->get_publish_(); @@ -182,7 +182,7 @@ void LightCall::perform() { } void LightCall::log_and_clear_unsupported_(FieldFlags flag, const LogString *feature, bool use_color_mode_log) { - auto *name = LOG_STR_ARG(this->parent_->get_log_name()); + auto *name = this->parent_->get_name().c_str(); if (use_color_mode_log) { log_color_mode_not_supported(name, feature); } else { @@ -192,7 +192,7 @@ void LightCall::log_and_clear_unsupported_(FieldFlags flag, const LogString *fea } LightColorValues LightCall::validate_() { - auto *name = LOG_STR_ARG(this->parent_->get_log_name()); + auto *name = this->parent_->get_name().c_str(); auto traits = this->parent_->get_traits(); // Snapshot before the adjustments below add flags of their own @@ -446,7 +446,7 @@ void LightCall::transform_parameters_(const LightTraits &traits) { !(this->color_mode_ & ColorCapability::COLOR_TEMPERATURE) && // min_mireds > 0.0f && max_mireds > 0.0f) { ESP_LOGV(TAG, "'%s': setting cold/warm white channels using white/color temperature values", - LOG_STR_ARG(this->parent_->get_log_name())); + this->parent_->get_name().c_str()); // Only compute cold_white/warm_white from color_temperature if they're not already explicitly set. // This is important for state restoration, where both color_temperature and cold_white/warm_white // are restored from flash - we want to preserve the saved cold_white/warm_white values. @@ -492,7 +492,7 @@ ColorMode LightCall::compute_color_mode_(const LightTraits &traits) { // Don't change if the current mode is in the intersection (suitable AND supported) if (ColorModeMask::mask_contains(intersection, current_mode)) { - ESP_LOGV(TAG, "'%s': color mode not specified; retaining %s", LOG_STR_ARG(this->parent_->get_log_name()), + ESP_LOGV(TAG, "'%s': color mode not specified; retaining %s", this->parent_->get_name().c_str(), LOG_STR_ARG(color_mode_to_human(current_mode))); return current_mode; } @@ -500,7 +500,7 @@ ColorMode LightCall::compute_color_mode_(const LightTraits &traits) { // Use the preferred suitable mode. if (intersection != 0) { ColorMode mode = ColorModeMask::first_value_from_mask(intersection); - ESP_LOGV(TAG, "'%s': color mode not specified; using %s", LOG_STR_ARG(this->parent_->get_log_name()), + ESP_LOGV(TAG, "'%s': color mode not specified; using %s", this->parent_->get_name().c_str(), LOG_STR_ARG(color_mode_to_human(mode))); return mode; } @@ -508,7 +508,7 @@ ColorMode LightCall::compute_color_mode_(const LightTraits &traits) { // There's no supported mode for this call, so warn, use the current more or a mode at random and let validation strip // out whatever we don't support. auto color_mode = current_mode != ColorMode::UNKNOWN ? current_mode : *supported_modes.begin(); - ESP_LOGW(TAG, "'%s': no suitable color mode supported; defaulting to %s", LOG_STR_ARG(this->parent_->get_log_name()), + ESP_LOGW(TAG, "'%s': no suitable color mode supported; defaulting to %s", this->parent_->get_name().c_str(), LOG_STR_ARG(color_mode_to_human(color_mode))); return color_mode; } @@ -587,7 +587,7 @@ LightCall &LightCall::set_effect(const char *effect, size_t len) { } } if (!found) { - ESP_LOGW(TAG, "'%s': no such effect '%.*s'", LOG_STR_ARG(this->parent_->get_log_name()), (int) len, effect); + ESP_LOGW(TAG, "'%s': no such effect '%.*s'", this->parent_->get_name().c_str(), (int) len, effect); } return *this; } diff --git a/esphome/components/light/light_state.cpp b/esphome/components/light/light_state.cpp index 98c953d557f..885440187f9 100644 --- a/esphome/components/light/light_state.cpp +++ b/esphome/components/light/light_state.cpp @@ -91,7 +91,7 @@ void LightState::setup() { call.perform(); } void LightState::dump_config() { - ESP_LOGCONFIG(TAG, "Light '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGCONFIG(TAG, "Light '%s'", this->get_name().c_str()); auto traits = this->get_traits(); if (traits.supports_color_capability(ColorCapability::BRIGHTNESS)) { #ifdef USE_LIGHT_GAMMA_LUT diff --git a/esphome/components/lock/lock.cpp b/esphome/components/lock/lock.cpp index ff6bb71c291..aca3a3b0248 100644 --- a/esphome/components/lock/lock.cpp +++ b/esphome/components/lock/lock.cpp @@ -30,10 +30,10 @@ void Lock::lock() { this->set_state_(LOCK_STATE_LOCKED); } void Lock::unlock() { this->set_state_(LOCK_STATE_UNLOCKED); } void Lock::open() { if (traits.get_supports_open()) { - ESP_LOGD(TAG, "'%s' Opening.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' Opening.", this->get_name().c_str()); this->open_latch(); } else { - ESP_LOGW(TAG, "'%s' Does not support Open.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' Does not support Open.", this->get_name().c_str()); } } void Lock::publish_state(LockState state) { @@ -42,7 +42,7 @@ void Lock::publish_state(LockState state) { this->state = state; this->rtc_.save(&this->state); - ESP_LOGV(TAG, "'%s' >> %s", LOG_STR_ARG(this->get_log_name()), LOG_STR_ARG(lock_state_to_string(state))); + ESP_LOGV(TAG, "'%s' >> %s", this->name_.c_str(), LOG_STR_ARG(lock_state_to_string(state))); this->state_callback_.call(state); #if defined(USE_LOCK) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_lock_update(this); @@ -50,7 +50,7 @@ void Lock::publish_state(LockState state) { } void LockCall::perform() { - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); this->validate_(); if (this->state_.has_value()) { ESP_LOGV(TAG, " State: %s", LOG_STR_ARG(lock_state_to_string(*this->state_))); @@ -92,7 +92,7 @@ LockCall &LockCall::set_state(const char *state) { } else if (ESPHOME_strcasecmp_P(state, ESPHOME_PSTR("NONE")) == 0) { this->set_state(LOCK_STATE_NONE); } else { - ESP_LOGW(TAG, "'%s' - Unrecognized state %s", LOG_STR_ARG(this->parent_->get_log_name()), state); + ESP_LOGW(TAG, "'%s' - Unrecognized state %s", this->parent_->get_name().c_str(), state); } return *this; } diff --git a/esphome/components/lock/lock.h b/esphome/components/lock/lock.h index 2862c33955f..b32d0da8e74 100644 --- a/esphome/components/lock/lock.h +++ b/esphome/components/lock/lock.h @@ -13,7 +13,7 @@ class Lock; #define LOG_LOCK(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ if ((obj)->traits.get_assumed_state()) { \ ESP_LOGCONFIG(TAG, "%s Assumed State: YES", prefix); \ diff --git a/esphome/components/max31856/max31856.cpp b/esphome/components/max31856/max31856.cpp index 864f58dc04a..bdb47216daa 100644 --- a/esphome/components/max31856/max31856.cpp +++ b/esphome/components/max31856/max31856.cpp @@ -94,28 +94,28 @@ bool MAX31856Sensor::has_fault_() { this->status_set_warning(); if ((faults & MAX31856_FAULT_CJRANGE) == MAX31856_FAULT_CJRANGE) { - ESP_LOGW(TAG, "Cold Junction Out-of-Range: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Cold Junction Out-of-Range: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_TCRANGE) == MAX31856_FAULT_TCRANGE) { - ESP_LOGW(TAG, "Thermocouple Out-of-Range: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Thermocouple Out-of-Range: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_CJHIGH) == MAX31856_FAULT_CJHIGH) { - ESP_LOGW(TAG, "Cold-Junction High Fault: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Cold-Junction High Fault: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_CJLOW) == MAX31856_FAULT_CJLOW) { - ESP_LOGW(TAG, "Cold-Junction Low Fault: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Cold-Junction Low Fault: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_TCHIGH) == MAX31856_FAULT_TCHIGH) { - ESP_LOGW(TAG, "Thermocouple Temperature High Fault: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Thermocouple Temperature High Fault: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_TCLOW) == MAX31856_FAULT_TCLOW) { - ESP_LOGW(TAG, "Thermocouple Temperature Low Fault: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Thermocouple Temperature Low Fault: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_OVUV) == MAX31856_FAULT_OVUV) { - ESP_LOGW(TAG, "Overvoltage or Undervoltage Input Fault: '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Overvoltage or Undervoltage Input Fault: '%s'", this->name_.c_str()); } if ((faults & MAX31856_FAULT_OPEN) == MAX31856_FAULT_OPEN) { - ESP_LOGW(TAG, "Thermocouple Open-Circuit Fault (possibly not connected): '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Thermocouple Open-Circuit Fault (possibly not connected): '%s'", this->name_.c_str()); } return true; diff --git a/esphome/components/max6675/max6675.cpp b/esphome/components/max6675/max6675.cpp index 2207106ed06..2fc8dbb73d7 100644 --- a/esphome/components/max6675/max6675.cpp +++ b/esphome/components/max6675/max6675.cpp @@ -39,7 +39,7 @@ void MAX6675Sensor::read_data_() { } float temperature = float(val >> 3) / 4.0f; - ESP_LOGD(TAG, "'%s': Got temperature=%.1f°C", LOG_STR_ARG(this->get_log_name()), temperature); + ESP_LOGD(TAG, "'%s': Got temperature=%.1f°C", this->name_.c_str(), temperature); this->publish_state(temperature); this->status_clear_warning(); } diff --git a/esphome/components/mcp9808/mcp9808.cpp b/esphome/components/mcp9808/mcp9808.cpp index c9c3c1c8518..47df37f4563 100644 --- a/esphome/components/mcp9808/mcp9808.cpp +++ b/esphome/components/mcp9808/mcp9808.cpp @@ -20,21 +20,21 @@ void MCP9808Sensor::setup() { uint16_t manu = 0; if (!this->read_byte_16(MCP9808_REG_MANUF_ID, &manu) || manu != MCP9808_MANUF_ID) { this->mark_failed(); - ESP_LOGE(TAG, "Incorrect manufacturer ID (%X) for '%s'", manu, LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, "Incorrect manufacturer ID (%X) for '%s'", manu, this->name_.c_str()); return; } uint16_t dev_id = 0; if (!this->read_byte_16(MCP9808_REG_DEVICE_ID, &dev_id) || dev_id != MCP9808_DEV_ID) { this->mark_failed(); - ESP_LOGE(TAG, "Incorrect device ID (%X) for '%s'", dev_id, LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, "Incorrect device ID (%X) for '%s'", dev_id, this->name_.c_str()); return; } } void MCP9808Sensor::dump_config() { - ESP_LOGCONFIG(TAG, "%s:", LOG_STR_ARG(this->get_log_name())); + ESP_LOGCONFIG(TAG, "%s:", this->name_.c_str()); LOG_I2C_DEVICE(this); if (this->is_failed()) { - ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL_FOR, LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL_FOR, this->name_.c_str()); } LOG_UPDATE_INTERVAL(this); LOG_SENSOR(" ", "Temperature", this); @@ -68,7 +68,7 @@ void MCP9808Sensor::update() { return; } - ESP_LOGD(TAG, "%s: Got temperature=%.4f°C", LOG_STR_ARG(this->get_log_name()), temp); + ESP_LOGD(TAG, "%s: Got temperature=%.4f°C", this->name_.c_str(), temp); this->publish_state(temp); this->status_clear_warning(); } diff --git a/esphome/components/media_player/media_player.cpp b/esphome/components/media_player/media_player.cpp index 1716a054c71..423832dd2ff 100644 --- a/esphome/components/media_player/media_player.cpp +++ b/esphome/components/media_player/media_player.cpp @@ -109,7 +109,7 @@ void MediaPlayerCall::validate_() { } void MediaPlayerCall::perform() { - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); this->validate_(); if (this->command_.has_value()) { const char *command_s = media_player_command_to_string(this->command_.value()); @@ -177,7 +177,7 @@ MediaPlayerCall &MediaPlayerCall::set_command(const char *command) { } else if (ESPHOME_strcasecmp_P(command, ESPHOME_PSTR("GROUP_JOIN")) == 0) { this->set_command(MEDIA_PLAYER_COMMAND_GROUP_JOIN); } else { - ESP_LOGW(TAG, "'%s' - Unrecognized command %s", LOG_STR_ARG(this->parent_->get_log_name()), command); + ESP_LOGW(TAG, "'%s' - Unrecognized command %s", this->parent_->get_name().c_str(), command); } return *this; } diff --git a/esphome/components/mlx90614/mlx90614.cpp b/esphome/components/mlx90614/mlx90614.cpp index c85223b142b..a67d770cc3d 100644 --- a/esphome/components/mlx90614/mlx90614.cpp +++ b/esphome/components/mlx90614/mlx90614.cpp @@ -174,7 +174,7 @@ void MLX90614Component::update() { // Bit 15 set means the device flagged the reading as invalid const float temperature = (raw & 0x8000) ? NAN : raw * 0.02f - 273.15f; - ESP_LOGD(TAG, "'%s': Got temperature=%.1f°C", LOG_STR_ARG(sensor->get_log_name()), temperature); + ESP_LOGD(TAG, "'%s': Got temperature=%.1f°C", sensor->get_name().c_str(), temperature); sensor->publish_state(temperature); return ec; }; diff --git a/esphome/components/modbus_controller/number/modbus_number.cpp b/esphome/components/modbus_controller/number/modbus_number.cpp index 6d228872443..f33fc36b0a1 100644 --- a/esphome/components/modbus_controller/number/modbus_number.cpp +++ b/esphome/components/modbus_controller/number/modbus_number.cpp @@ -57,8 +57,7 @@ void ModbusNumber::control(float value) { bytes.push_back(word_bytes[1]); } if (!this->send_raw_frame_deprecated_(std::span(bytes.data(), bytes.size()))) { - ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", this->get_name().c_str()); return; } this->publish_state(value); @@ -83,7 +82,7 @@ void ModbusNumber::control(float value) { ESP_LOGD(TAG, "Updating register: connected Sensor=%s start address=0x%X register count=%d new value=%.02f (val=%.02f)", - LOG_STR_ARG(this->get_log_name()), this->start_address, this->entity_count(), value, write_value); + this->get_name().c_str(), this->start_address, this->entity_count(), value, write_value); bool queued; if (this->entity_count() == 1 && !this->use_write_multiple_) { @@ -92,8 +91,7 @@ void ModbusNumber::control(float value) { queued = this->write_multiple_registers(this->write_address(), data); } if (!queued) { - ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", this->get_name().c_str()); return; } this->publish_state(value); diff --git a/esphome/components/modbus_controller/select/modbus_select.cpp b/esphome/components/modbus_controller/select/modbus_select.cpp index a68bb0c9318..793aa8e9ea4 100644 --- a/esphome/components/modbus_controller/select/modbus_select.cpp +++ b/esphome/components/modbus_controller/select/modbus_select.cpp @@ -100,8 +100,7 @@ void ModbusSelect::control(size_t index) { } if (!queued) { - ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", this->get_name().c_str()); return; } if (this->optimistic_) diff --git a/esphome/components/modbus_controller/switch/modbus_switch.cpp b/esphome/components/modbus_controller/switch/modbus_switch.cpp index 7a9f51395ea..fe2b2762313 100644 --- a/esphome/components/modbus_controller/switch/modbus_switch.cpp +++ b/esphome/components/modbus_controller/switch/modbus_switch.cpp @@ -48,7 +48,7 @@ void ModbusSwitch::parse_and_publish(std::span data) { } } - ESP_LOGV(TAG, "Publish '%s': new value = %s type = %d address = %X offset = %zx", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "Publish '%s': new value = %s type = %d address = %X offset = %zx", this->get_name().c_str(), ONOFF(value), (int) this->register_type, this->start_address, offset); this->publish_state(value); } @@ -77,8 +77,7 @@ void ModbusSwitch::write_state(bool state) { format_hex_pretty_to(hex_buf, sizeof(hex_buf), data.data(), data.size())); // The lambda filled a legacy raw frame (device address + function code + data). if (!this->send_raw_frame_deprecated_(data)) { - ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", this->get_name().c_str()); return; } this->publish_state(state); @@ -94,8 +93,8 @@ void ModbusSwitch::write_state(bool state) { write_value = val.value(); } ESP_LOGV(TAG, "write_state '%s': new value = %s (wire = %s) type = %d address = %X offset = %x", - LOG_STR_ARG(this->get_log_name()), ONOFF(state), ONOFF(write_value), (int) this->register_type, - this->start_address, this->offset); + this->get_name().c_str(), ONOFF(state), ONOFF(write_value), (int) this->register_type, this->start_address, + this->offset); bool queued; if (this->register_type == EntityType::COIL) { // offset for coil and discrete inputs is the coil/register number not bytes @@ -114,8 +113,7 @@ void ModbusSwitch::write_state(bool state) { } } if (!queued) { - ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "Modbus write for '%s' was refused by the hub; state not published", this->get_name().c_str()); return; } this->publish_state(state); diff --git a/esphome/components/mqtt/mqtt_alarm_control_panel.cpp b/esphome/components/mqtt/mqtt_alarm_control_panel.cpp index 7d3f156228d..225f8396339 100644 --- a/esphome/components/mqtt/mqtt_alarm_control_panel.cpp +++ b/esphome/components/mqtt/mqtt_alarm_control_panel.cpp @@ -59,9 +59,9 @@ void MQTTAlarmControlPanelComponent::setup() { if (!root.isNull()) { const char *state = root[ESPHOME_F("state")]; if (state == nullptr) { - ESP_LOGW(TAG, "'%s': JSON payload missing 'state' key", LOG_STR_ARG(this->log_name_())); + ESP_LOGW(TAG, "'%s': JSON payload missing 'state' key", this->friendly_name_().c_str()); } else if (!apply_command(call, state)) { - ESP_LOGW(TAG, "'%s': Received unknown state in JSON payload: %s", LOG_STR_ARG(this->log_name_()), state); + ESP_LOGW(TAG, "'%s': Received unknown state in JSON payload: %s", this->friendly_name_().c_str(), state); } else { const char *code = root[ESPHOME_F("code")]; if (code != nullptr) { @@ -70,14 +70,14 @@ void MQTTAlarmControlPanelComponent::setup() { } } } else if (!apply_command(call, payload.c_str())) { - ESP_LOGW(TAG, "'%s': Received unknown command payload %s", LOG_STR_ARG(this->log_name_()), payload.c_str()); + ESP_LOGW(TAG, "'%s': Received unknown command payload %s", this->friendly_name_().c_str(), payload.c_str()); } call.perform(); }); } void MQTTAlarmControlPanelComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT alarm_control_panel '%s':", LOG_STR_ARG(this->alarm_control_panel_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT alarm_control_panel '%s':", this->alarm_control_panel_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); ESP_LOGCONFIG(TAG, " Supported Features: %" PRIu32 "\n" diff --git a/esphome/components/mqtt/mqtt_binary_sensor.cpp b/esphome/components/mqtt/mqtt_binary_sensor.cpp index 7e9bf9e7bc7..7a75cca6e88 100644 --- a/esphome/components/mqtt/mqtt_binary_sensor.cpp +++ b/esphome/components/mqtt/mqtt_binary_sensor.cpp @@ -18,7 +18,7 @@ void MQTTBinarySensorComponent::setup() { } void MQTTBinarySensorComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Binary Sensor '%s':", LOG_STR_ARG(this->binary_sensor_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Binary Sensor '%s':", this->binary_sensor_->get_name().c_str()); LOG_MQTT_COMPONENT(true, false); } MQTTBinarySensorComponent::MQTTBinarySensorComponent(binary_sensor::BinarySensor *binary_sensor) diff --git a/esphome/components/mqtt/mqtt_button.cpp b/esphome/components/mqtt/mqtt_button.cpp index e03bd943d9f..a04121e2a13 100644 --- a/esphome/components/mqtt/mqtt_button.cpp +++ b/esphome/components/mqtt/mqtt_button.cpp @@ -19,13 +19,13 @@ void MQTTButtonComponent::setup() { if (payload == "PRESS") { this->button_->press(); } else { - ESP_LOGW(TAG, "'%s': Received unknown status payload: %s", LOG_STR_ARG(this->log_name_()), payload.c_str()); + ESP_LOGW(TAG, "'%s': Received unknown status payload: %s", this->friendly_name_().c_str(), payload.c_str()); this->status_momentary_warning(5000); } }); } void MQTTButtonComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Button '%s': ", LOG_STR_ARG(this->button_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Button '%s': ", this->button_->get_name().c_str()); LOG_MQTT_COMPONENT(false, true); } diff --git a/esphome/components/mqtt/mqtt_component.cpp b/esphome/components/mqtt/mqtt_component.cpp index e51b06ba389..adb5a958287 100644 --- a/esphome/components/mqtt/mqtt_component.cpp +++ b/esphome/components/mqtt/mqtt_component.cpp @@ -186,11 +186,11 @@ bool MQTTComponent::send_discovery_() { StringRef discovery_topic = this->get_discovery_topic_to_(discovery_topic_buf, discovery_info); if (discovery_info.clean) { - ESP_LOGV(TAG, "'%s': Cleaning discovery", LOG_STR_ARG(this->log_name_())); + ESP_LOGV(TAG, "'%s': Cleaning discovery", this->friendly_name_().c_str()); return global_mqtt_client->publish(discovery_topic.c_str(), "", 0, this->qos_, true); } - ESP_LOGV(TAG, "'%s': Sending discovery", LOG_STR_ARG(this->log_name_())); + ESP_LOGV(TAG, "'%s': Sending discovery", this->friendly_name_().c_str()); // NOLINTBEGIN(clang-analyzer-cplusplus.NewDeleteLeaks) false positive with ArduinoJson return global_mqtt_client->publish_json( @@ -207,12 +207,7 @@ bool MQTTComponent::send_discovery_() { } // Fields from EntityBase - if (this->get_entity()->has_own_name()) { - // ArduinoJson copies flash strings into the document itself - root[MQTT_NAME] = reinterpret_cast(this->get_entity()->get_name_progmem().progmem_ptr()); - } else { - root[MQTT_NAME] = StringRef(); - } + root[MQTT_NAME] = this->get_entity()->has_own_name() ? this->friendly_name_() : StringRef(); if (this->is_disabled_by_default_()) root[MQTT_ENABLED_BY_DEFAULT] = false; @@ -258,10 +253,9 @@ bool MQTTComponent::send_discovery_() { char object_id_buf[OBJECT_ID_MAX_LEN]; StringRef object_id = this->get_default_object_id_to_(object_id_buf); if (discovery_info.unique_id_generator == MQTT_MAC_ADDRESS_UNIQUE_ID_GENERATOR) { - char name_buf[ENTITY_NAME_BUF_SIZE]; char friendly_name_hash[9]; buf_append_printf(friendly_name_hash, sizeof(friendly_name_hash), 0, "%08" PRIx32, - fnv1_hash(this->get_entity()->get_name_to(name_buf).c_str())); + fnv1_hash(this->friendly_name_().c_str())); // Format: mac-component_type-hash (e.g. "aabbccddeeff-sensor-12345678") // MAC (12) + "-" (1) + domain (max 20) + "-" (1) + hash (8) + null (1) = 43 char unique_id[MAC_ADDRESS_BUFFER_SIZE + ESPHOME_DOMAIN_MAX_LEN + 11]; @@ -413,11 +407,7 @@ void MQTTComponent::schedule_resend_state() { this->resend_state_ = true; } bool MQTTComponent::is_connected_() const { return global_mqtt_client->is_connected(); } // Pull these properties from EntityBase if not overridden -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wdeprecated-declarations" const StringRef &MQTTComponent::friendly_name_() const { return this->get_entity()->get_name(); } -#pragma GCC diagnostic pop -const LogString *MQTTComponent::log_name_() const { return this->get_entity()->get_log_name(); } StringRef MQTTComponent::get_default_object_id_to_(std::span buf) const { return this->get_entity()->get_object_id_to(buf); } diff --git a/esphome/components/mqtt/mqtt_component.h b/esphome/components/mqtt/mqtt_component.h index 300af2b5a46..141b5f12b38 100644 --- a/esphome/components/mqtt/mqtt_component.h +++ b/esphome/components/mqtt/mqtt_component.h @@ -300,9 +300,7 @@ class MQTTComponent : public Component { */ virtual const EntityBase *get_entity() const = 0; - /// Entity name for a "%s" log argument. - const LogString *log_name_() const; - ESPDEPRECATED("Use log_name_() for logging. Removed in 2027.5.0", "2026.11.0") + /// Get the friendly name of this MQTT component. const StringRef &friendly_name_() const; /// Get the icon field of this component into a stack buffer diff --git a/esphome/components/mqtt/mqtt_cover.cpp b/esphome/components/mqtt/mqtt_cover.cpp index c05c8d1ceb2..a7da9a1b228 100644 --- a/esphome/components/mqtt/mqtt_cover.cpp +++ b/esphome/components/mqtt/mqtt_cover.cpp @@ -63,7 +63,7 @@ void MQTTCoverComponent::setup() { } void MQTTCoverComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT cover '%s':", LOG_STR_ARG(this->cover_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT cover '%s':", this->cover_->get_name().c_str()); auto traits = this->cover_->get_traits(); bool has_command_topic = traits.get_supports_position() || !traits.get_supports_tilt(); LOG_MQTT_COMPONENT(true, has_command_topic); diff --git a/esphome/components/mqtt/mqtt_date.cpp b/esphome/components/mqtt/mqtt_date.cpp index 43ee3fc2eae..b5f1cf8fb8b 100644 --- a/esphome/components/mqtt/mqtt_date.cpp +++ b/esphome/components/mqtt/mqtt_date.cpp @@ -35,7 +35,7 @@ void MQTTDateComponent::setup() { } void MQTTDateComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Date '%s':", LOG_STR_ARG(this->date_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Date '%s':", this->date_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_datetime.cpp b/esphome/components/mqtt/mqtt_datetime.cpp index d54e0581077..82755809387 100644 --- a/esphome/components/mqtt/mqtt_datetime.cpp +++ b/esphome/components/mqtt/mqtt_datetime.cpp @@ -46,7 +46,7 @@ void MQTTDateTimeComponent::setup() { } void MQTTDateTimeComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT DateTime '%s':", LOG_STR_ARG(this->datetime_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT DateTime '%s':", this->datetime_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_event.cpp b/esphome/components/mqtt/mqtt_event.cpp index e5484d03164..4266722ca82 100644 --- a/esphome/components/mqtt/mqtt_event.cpp +++ b/esphome/components/mqtt/mqtt_event.cpp @@ -28,7 +28,7 @@ void MQTTEventComponent::setup() { } void MQTTEventComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Event '%s': ", LOG_STR_ARG(this->event_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Event '%s': ", this->event_->get_name().c_str()); ESP_LOGCONFIG(TAG, "Event Types: "); for (const char *event_type : this->event_->get_event_types()) { ESP_LOGCONFIG(TAG, "- %s", event_type); diff --git a/esphome/components/mqtt/mqtt_fan.cpp b/esphome/components/mqtt/mqtt_fan.cpp index b0eebaca55e..7aa2f8e9d5a 100644 --- a/esphome/components/mqtt/mqtt_fan.cpp +++ b/esphome/components/mqtt/mqtt_fan.cpp @@ -32,15 +32,15 @@ void MQTTFanComponent::setup() { auto val = parse_on_off(payload.c_str()); switch (val) { case PARSE_ON: - ESP_LOGD(TAG, "'%s' Turning Fan ON.", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s' Turning Fan ON.", this->friendly_name_().c_str()); this->state_->turn_on().perform(); break; case PARSE_OFF: - ESP_LOGD(TAG, "'%s' Turning Fan OFF.", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s' Turning Fan OFF.", this->friendly_name_().c_str()); this->state_->turn_off().perform(); break; case PARSE_TOGGLE: - ESP_LOGD(TAG, "'%s' Toggling Fan.", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s' Toggling Fan.", this->friendly_name_().c_str()); this->state_->toggle().perform(); break; case PARSE_NONE: @@ -56,11 +56,11 @@ void MQTTFanComponent::setup() { auto val = parse_on_off(payload.c_str(), "forward", "reverse"); switch (val) { case PARSE_ON: - ESP_LOGD(TAG, "'%s': Setting direction FORWARD", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s': Setting direction FORWARD", this->friendly_name_().c_str()); this->state_->make_call().set_direction(fan::FanDirection::FORWARD).perform(); break; case PARSE_OFF: - ESP_LOGD(TAG, "'%s': Setting direction REVERSE", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s': Setting direction REVERSE", this->friendly_name_().c_str()); this->state_->make_call().set_direction(fan::FanDirection::REVERSE).perform(); break; case PARSE_TOGGLE: @@ -83,11 +83,11 @@ void MQTTFanComponent::setup() { auto val = parse_on_off(payload.c_str(), "oscillate_on", "oscillate_off"); switch (val) { case PARSE_ON: - ESP_LOGD(TAG, "'%s': Setting oscillating ON", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s': Setting oscillating ON", this->friendly_name_().c_str()); this->state_->make_call().set_oscillating(true).perform(); break; case PARSE_OFF: - ESP_LOGD(TAG, "'%s': Setting oscillating OFF", LOG_STR_ARG(this->log_name_())); + ESP_LOGD(TAG, "'%s': Setting oscillating OFF", this->friendly_name_().c_str()); this->state_->make_call().set_oscillating(false).perform(); break; case PARSE_TOGGLE: @@ -125,7 +125,7 @@ void MQTTFanComponent::setup() { } void MQTTFanComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Fan '%s': ", LOG_STR_ARG(this->state_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Fan '%s': ", this->state_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); if (this->state_->get_traits().supports_direction()) { ESP_LOGCONFIG(TAG, @@ -168,7 +168,7 @@ void MQTTFanComponent::send_discovery(JsonObject root, mqtt::SendDiscoveryConfig bool MQTTFanComponent::publish_state() { char topic_buf[MQTT_DEFAULT_TOPIC_MAX_LEN]; const char *state_s = this->state_->state ? "ON" : "OFF"; - ESP_LOGD(TAG, "'%s' Sending state %s.", LOG_STR_ARG(this->state_->get_log_name()), state_s); + ESP_LOGD(TAG, "'%s' Sending state %s.", this->state_->get_name().c_str(), state_s); this->publish(this->get_state_topic_to_(topic_buf), state_s); bool failed = false; if (this->state_->get_traits().supports_direction()) { diff --git a/esphome/components/mqtt/mqtt_light.cpp b/esphome/components/mqtt/mqtt_light.cpp index 91bd1010a31..e1affae8a24 100644 --- a/esphome/components/mqtt/mqtt_light.cpp +++ b/esphome/components/mqtt/mqtt_light.cpp @@ -88,7 +88,7 @@ void MQTTJSONLightComponent::send_discovery(JsonObject root, mqtt::SendDiscovery } bool MQTTJSONLightComponent::send_initial_state() { return this->publish_state_(); } void MQTTJSONLightComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Light '%s':", LOG_STR_ARG(this->state_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Light '%s':", this->state_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_lock.cpp b/esphome/components/mqtt/mqtt_lock.cpp index 8d8a0e65627..8e9a6289852 100644 --- a/esphome/components/mqtt/mqtt_lock.cpp +++ b/esphome/components/mqtt/mqtt_lock.cpp @@ -24,7 +24,7 @@ void MQTTLockComponent::setup() { } else if (ESPHOME_strcasecmp_P(payload.c_str(), ESPHOME_PSTR("OPEN")) == 0) { this->lock_->open(); } else { - ESP_LOGW(TAG, "'%s': Received unknown status payload: %s", LOG_STR_ARG(this->log_name_()), payload.c_str()); + ESP_LOGW(TAG, "'%s': Received unknown status payload: %s", this->friendly_name_().c_str(), payload.c_str()); this->status_momentary_warning(5000); } }); @@ -32,7 +32,7 @@ void MQTTLockComponent::setup() { [this](LockState /*state*/) { this->defer(SEND_DEFER_ID, [this]() { this->publish_state(); }); }); } void MQTTLockComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Lock '%s': ", LOG_STR_ARG(this->lock_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Lock '%s': ", this->lock_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_number.cpp b/esphome/components/mqtt/mqtt_number.cpp index 53306ef02e9..3b2bebf291d 100644 --- a/esphome/components/mqtt/mqtt_number.cpp +++ b/esphome/components/mqtt/mqtt_number.cpp @@ -33,7 +33,7 @@ void MQTTNumberComponent::setup() { } void MQTTNumberComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Number '%s':", LOG_STR_ARG(this->number_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Number '%s':", this->number_->get_name().c_str()); LOG_MQTT_COMPONENT(true, false); } diff --git a/esphome/components/mqtt/mqtt_select.cpp b/esphome/components/mqtt/mqtt_select.cpp index 892a6a3fbc8..42c0ae002e4 100644 --- a/esphome/components/mqtt/mqtt_select.cpp +++ b/esphome/components/mqtt/mqtt_select.cpp @@ -24,7 +24,7 @@ void MQTTSelectComponent::setup() { } void MQTTSelectComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Select '%s':", LOG_STR_ARG(this->select_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Select '%s':", this->select_->get_name().c_str()); LOG_MQTT_COMPONENT(true, false); } diff --git a/esphome/components/mqtt/mqtt_sensor.cpp b/esphome/components/mqtt/mqtt_sensor.cpp index 794eab5e867..bdaaa47e8f4 100644 --- a/esphome/components/mqtt/mqtt_sensor.cpp +++ b/esphome/components/mqtt/mqtt_sensor.cpp @@ -25,7 +25,7 @@ void MQTTSensorComponent::setup() { } void MQTTSensorComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Sensor '%s':", LOG_STR_ARG(this->sensor_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Sensor '%s':", this->sensor_->get_name().c_str()); if (this->get_expire_after() > 0) { ESP_LOGCONFIG(TAG, " Expire After: %" PRIu32 "s", this->get_expire_after() / 1000); } diff --git a/esphome/components/mqtt/mqtt_switch.cpp b/esphome/components/mqtt/mqtt_switch.cpp index 90536c0a2ed..44ce2497720 100644 --- a/esphome/components/mqtt/mqtt_switch.cpp +++ b/esphome/components/mqtt/mqtt_switch.cpp @@ -28,7 +28,7 @@ void MQTTSwitchComponent::setup() { break; case PARSE_NONE: default: - ESP_LOGW(TAG, "'%s': Received unknown status payload: %s", LOG_STR_ARG(this->log_name_()), payload.c_str()); + ESP_LOGW(TAG, "'%s': Received unknown status payload: %s", this->friendly_name_().c_str(), payload.c_str()); this->status_momentary_warning(5000); break; } @@ -37,7 +37,7 @@ void MQTTSwitchComponent::setup() { [this](bool enabled) { this->defer(SEND_DEFER_ID, [this, enabled]() { this->publish_state(enabled); }); }); } void MQTTSwitchComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Switch '%s': ", LOG_STR_ARG(this->switch_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Switch '%s': ", this->switch_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_text.cpp b/esphome/components/mqtt/mqtt_text.cpp index 95813a25b32..dd43a8e2cb3 100644 --- a/esphome/components/mqtt/mqtt_text.cpp +++ b/esphome/components/mqtt/mqtt_text.cpp @@ -29,7 +29,7 @@ void MQTTTextComponent::setup() { } void MQTTTextComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT text '%s':", LOG_STR_ARG(this->text_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT text '%s':", this->text_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_text_sensor.cpp b/esphome/components/mqtt/mqtt_text_sensor.cpp index 3cf501d054f..d105aaac992 100644 --- a/esphome/components/mqtt/mqtt_text_sensor.cpp +++ b/esphome/components/mqtt/mqtt_text_sensor.cpp @@ -21,7 +21,7 @@ void MQTTTextSensor::setup() { } void MQTTTextSensor::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Text Sensor '%s':", LOG_STR_ARG(this->sensor_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Text Sensor '%s':", this->sensor_->get_name().c_str()); LOG_MQTT_COMPONENT(true, false); } diff --git a/esphome/components/mqtt/mqtt_time.cpp b/esphome/components/mqtt/mqtt_time.cpp index f572f887891..889ee2bf349 100644 --- a/esphome/components/mqtt/mqtt_time.cpp +++ b/esphome/components/mqtt/mqtt_time.cpp @@ -35,7 +35,7 @@ void MQTTTimeComponent::setup() { } void MQTTTimeComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Time '%s':", LOG_STR_ARG(this->time_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Time '%s':", this->time_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_update.cpp b/esphome/components/mqtt/mqtt_update.cpp index 29a1821b86f..69b2f64771b 100644 --- a/esphome/components/mqtt/mqtt_update.cpp +++ b/esphome/components/mqtt/mqtt_update.cpp @@ -19,7 +19,7 @@ void MQTTUpdateComponent::setup() { if (payload == "INSTALL") { this->update_->perform(); } else { - ESP_LOGW(TAG, "'%s': Received unknown update payload: %s", LOG_STR_ARG(this->log_name_()), payload.c_str()); + ESP_LOGW(TAG, "'%s': Received unknown update payload: %s", this->friendly_name_().c_str(), payload.c_str()); this->status_momentary_warning(5000); } }); @@ -49,7 +49,7 @@ void MQTTUpdateComponent::send_discovery(JsonObject root, mqtt::SendDiscoveryCon bool MQTTUpdateComponent::send_initial_state() { return this->publish_state(); } void MQTTUpdateComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT Update '%s': ", LOG_STR_ARG(this->update_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT Update '%s': ", this->update_->get_name().c_str()); LOG_MQTT_COMPONENT(true, true); } diff --git a/esphome/components/mqtt/mqtt_valve.cpp b/esphome/components/mqtt/mqtt_valve.cpp index 7ca3e959b40..b41a482de94 100644 --- a/esphome/components/mqtt/mqtt_valve.cpp +++ b/esphome/components/mqtt/mqtt_valve.cpp @@ -51,7 +51,7 @@ void MQTTValveComponent::setup() { } void MQTTValveComponent::dump_config() { - ESP_LOGCONFIG(TAG, "MQTT valve '%s':", LOG_STR_ARG(this->valve_->get_log_name())); + ESP_LOGCONFIG(TAG, "MQTT valve '%s':", this->valve_->get_name().c_str()); auto traits = this->valve_->get_traits(); bool has_command_topic = traits.get_supports_position(); LOG_MQTT_COMPONENT(true, has_command_topic); diff --git a/esphome/components/nau7802/nau7802.cpp b/esphome/components/nau7802/nau7802.cpp index ad7191c0a70..ad1a569e0fa 100644 --- a/esphome/components/nau7802/nau7802.cpp +++ b/esphome/components/nau7802/nau7802.cpp @@ -125,7 +125,7 @@ void NAU7802Sensor::dump_config() { LOG_I2C_DEVICE(this); if (this->is_failed()) { - ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL_FOR, LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, ESP_LOG_MSG_COMM_FAIL_FOR, this->get_name().c_str()); return; } // Note these may differ from the values on the device if calbration has been run @@ -307,7 +307,7 @@ void NAU7802Sensor::update() { // Get the most recent sample to publish int32_t result = this->read_value_(ADCO_B2_REG, 3); - ESP_LOGD(TAG, "'%s': Got value %" PRId32, LOG_STR_ARG(this->get_log_name()), result); + ESP_LOGD(TAG, "'%s': Got value %" PRId32, this->name_.c_str(), result); this->publish_state(result); } diff --git a/esphome/components/ntc/ntc.cpp b/esphome/components/ntc/ntc.cpp index 60b0dd2d891..d2b095a3d75 100644 --- a/esphome/components/ntc/ntc.cpp +++ b/esphome/components/ntc/ntc.cpp @@ -21,7 +21,7 @@ void NTC::process_(float value) { double v = this->a_ + this->b_ * lr + this->c_ * lr * lr * lr; auto temp = float(1.0 / v - 273.15); - ESP_LOGV(TAG, "'%s' - Temperature: %.1f°C", LOG_STR_ARG(this->get_log_name()), temp); + ESP_LOGV(TAG, "'%s' - Temperature: %.1f°C", this->name_.c_str(), temp); this->publish_state(temp); } diff --git a/esphome/components/number/number.cpp b/esphome/components/number/number.cpp index d21d757b863..1d5533c423b 100644 --- a/esphome/components/number/number.cpp +++ b/esphome/components/number/number.cpp @@ -13,7 +13,7 @@ void log_number(const char *tag, const char *prefix, const char *type, Number *o return; } - ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, LOG_STR_ARG(obj->get_log_name())); + ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, obj->get_name().c_str()); LOG_ENTITY_ICON(tag, prefix, *obj); LOG_ENTITY_UNIT_OF_MEASUREMENT(tag, prefix, *obj); LOG_ENTITY_DEVICE_CLASS(tag, prefix, *obj); @@ -22,7 +22,7 @@ void log_number(const char *tag, const char *prefix, const char *type, Number *o void Number::publish_state(float state) { this->set_has_state(true); this->state = state; - ESP_LOGV(TAG, "'%s' >> %.2f", LOG_STR_ARG(this->get_log_name()), state); + ESP_LOGV(TAG, "'%s' >> %.2f", this->get_name().c_str(), state); this->state_callback_.call(state); #if defined(USE_NUMBER) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_number_update(this); diff --git a/esphome/components/number/number_call.cpp b/esphome/components/number/number_call.cpp index 4079d775227..a928eaf3fa4 100644 --- a/esphome/components/number/number_call.cpp +++ b/esphome/components/number/number_call.cpp @@ -8,12 +8,12 @@ ESPHOME_LOG_TAG(TAG, "number"); // Helper functions to reduce code size for logging void NumberCall::log_perform_warning_(const LogString *message) { - ESP_LOGW(TAG, "'%s': %s", LOG_STR_ARG(this->parent_->get_log_name()), LOG_STR_ARG(message)); + ESP_LOGW(TAG, "'%s': %s", this->parent_->get_name().c_str(), LOG_STR_ARG(message)); } void NumberCall::log_perform_warning_value_range_(const LogString *comparison, const LogString *limit_type, float val, float limit) { - ESP_LOGW(TAG, "'%s': %f %s %s %f", LOG_STR_ARG(this->parent_->get_log_name()), val, LOG_STR_ARG(comparison), + ESP_LOGW(TAG, "'%s': %f %s %s %f", this->parent_->get_name().c_str(), val, LOG_STR_ARG(comparison), LOG_STR_ARG(limit_type), limit); } @@ -48,7 +48,7 @@ NumberCall &NumberCall::with_cycle(bool cycle) { void NumberCall::perform() { auto *parent = this->parent_; - const auto *name = LOG_STR_ARG(parent->get_log_name()); + const auto *name = parent->get_name().c_str(); const auto &traits = parent->traits; if (this->operation_ == NUMBER_OP_NONE) { diff --git a/esphome/components/opentherm/switch/opentherm_switch.cpp b/esphome/components/opentherm/switch/opentherm_switch.cpp index 17640dc7180..6bf06f825e9 100644 --- a/esphome/components/opentherm/switch/opentherm_switch.cpp +++ b/esphome/components/opentherm/switch/opentherm_switch.cpp @@ -10,9 +10,9 @@ void OpenthermSwitch::setup() { auto restored = this->get_initial_state_with_restore_mode(); bool state = false; if (!restored.has_value()) { - ESP_LOGD(TAG, "Couldn't restore state for OpenTherm switch '%s'", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "Couldn't restore state for OpenTherm switch '%s'", this->get_name().c_str()); } else { - ESP_LOGD(TAG, "Restored state for OpenTherm switch '%s': %d", LOG_STR_ARG(this->get_log_name()), restored.value()); + ESP_LOGD(TAG, "Restored state for OpenTherm switch '%s': %d", this->get_name().c_str(), restored.value()); state = restored.value(); } this->write_state(state); diff --git a/esphome/components/opt3001/opt3001.cpp b/esphome/components/opt3001/opt3001.cpp index da94327c1fb..0101368cebd 100644 --- a/esphome/components/opt3001/opt3001.cpp +++ b/esphome/components/opt3001/opt3001.cpp @@ -112,7 +112,7 @@ void OPT3001Sensor::update() { this->publish_state(NAN); return; } - ESP_LOGD(TAG, "'%s': Illuminance=%.1flx", LOG_STR_ARG(this->get_log_name()), val); + ESP_LOGD(TAG, "'%s': Illuminance=%.1flx", this->get_name().c_str(), val); this->status_clear_warning(); this->publish_state(val); }); diff --git a/esphome/components/pid/pid_autotuner.cpp b/esphome/components/pid/pid_autotuner.cpp index 140bf209ff6..8b9ce7bbee3 100644 --- a/esphome/components/pid/pid_autotuner.cpp +++ b/esphome/components/pid/pid_autotuner.cpp @@ -74,7 +74,7 @@ PIDAutotuner::PIDAutotuneResult PIDAutotuner::update(float setpoint, float proce } if (!std::isnan(this->setpoint_) && this->setpoint_ != setpoint) { - ESP_LOGW(TAG, "%s: Setpoint changed during autotune! The result will not be accurate!", LOG_STR_ARG(this->id_)); + ESP_LOGW(TAG, "%s: Setpoint changed during autotune! The result will not be accurate!", this->id_.c_str()); } this->setpoint_ = setpoint; @@ -88,7 +88,7 @@ PIDAutotuner::PIDAutotuneResult PIDAutotuner::update(float setpoint, float proce if (!this->frequency_detector_.has_enough_data() || !this->amplitude_detector_.has_enough_data()) { // not enough data for calculation yet - ESP_LOGV(TAG, "%s: Not enough data yet for autotuner", LOG_STR_ARG(this->id_)); + ESP_LOGV(TAG, "%s: Not enough data yet for autotuner", this->id_.c_str()); return res; } @@ -98,13 +98,13 @@ PIDAutotuner::PIDAutotuneResult PIDAutotuner::update(float setpoint, float proce // The frequency/amplitude is not fully accurate yet, try to wait // until the fault clears, or terminate after a while anyway if (!zc_symmetrical) { - ESP_LOGVV(TAG, "%s: ZC is not symmetrical", LOG_STR_ARG(this->id_)); + ESP_LOGVV(TAG, "%s: ZC is not symmetrical", this->id_.c_str()); } if (!amplitude_convergent) { - ESP_LOGVV(TAG, "%s: Amplitude is not convergent", LOG_STR_ARG(this->id_)); + ESP_LOGVV(TAG, "%s: Amplitude is not convergent", this->id_.c_str()); } uint32_t phase = this->relay_function_.phase_count; - ESP_LOGVV(TAG, "%s: >", LOG_STR_ARG(this->id_)); + ESP_LOGVV(TAG, "%s: >", this->id_.c_str()); ESP_LOGVV(TAG, " Phase %" PRIu32 ", enough=%" PRIu32, phase, enough_data_phase_); if (this->enough_data_phase_ == 0) { @@ -118,7 +118,7 @@ PIDAutotuner::PIDAutotuneResult PIDAutotuner::update(float setpoint, float proce } } - ESP_LOGI(TAG, "%s: PID Autotune finished!", LOG_STR_ARG(this->id_)); + ESP_LOGI(TAG, "%s: PID Autotune finished!", this->id_.c_str()); float osc_ampl = this->amplitude_detector_.get_mean_oscillation_amplitude(); float d = (this->relay_function_.output_positive - this->relay_function_.output_negative) / 2.0f; @@ -137,7 +137,7 @@ void PIDAutotuner::dump_config() { ESP_LOGI(TAG, "%s: PID Autotune:\n" " State: Succeeded!", - LOG_STR_ARG(this->id_)); + this->id_.c_str()); bool has_issue = false; if (!this->amplitude_detector_.is_amplitude_convergent()) { ESP_LOGW(TAG, " Could not reliably determine oscillation amplitude, PID parameters may be inaccurate!\n" @@ -181,7 +181,7 @@ void PIDAutotuner::dump_config() { print_rule_("Pessen Integral PID", 0.7f, 1.75f, 0.105f); print_rule_("Some Overshoot PID", 0.333f, 0.667f, 0.111f); print_rule_("No Overshoot PID", 0.2f, 0.4f, 0.0625f); - ESP_LOGI(TAG, "%s: Autotune completed", LOG_STR_ARG(this->id_)); + ESP_LOGI(TAG, "%s: Autotune completed", this->id_.c_str()); } if (this->state_ == AUTOTUNE_RUNNING) { @@ -193,7 +193,7 @@ void PIDAutotuner::dump_config() { " Phases: %" PRIu32 "\n" " Detected %zu zero-crossings\n" " Current Phase Min: %.2f, Max: %.2f", - LOG_STR_ARG(this->id_), setpoint_ - relay_function_.current_target_error(), relay_function_.phase_count, + this->id_.c_str(), setpoint_ - relay_function_.current_target_error(), relay_function_.phase_count, frequency_detector_.zerocrossing_intervals.size(), amplitude_detector_.phase_min, amplitude_detector_.phase_max); } diff --git a/esphome/components/pid/pid_autotuner.h b/esphome/components/pid/pid_autotuner.h index ebfa6be4193..5115c73c95b 100644 --- a/esphome/components/pid/pid_autotuner.h +++ b/esphome/components/pid/pid_autotuner.h @@ -29,8 +29,7 @@ class PIDAutotuner { void dump_config(); - /// Name shown in log lines; must outlive the autotuner. - void set_autotuner_id(const LogString *id) { this->id_ = id; } + void set_autotuner_id(std::string id) { this->id_ = std::move(id); } void set_noiseband(float noiseband) { relay_function_.noiseband = noiseband; @@ -107,7 +106,7 @@ class PIDAutotuner { } state_ = AUTOTUNE_RUNNING; float ku_; float pu_; - const LogString *id_{nullptr}; + std::string id_; }; } // namespace esphome::pid diff --git a/esphome/components/pid/pid_climate.cpp b/esphome/components/pid/pid_climate.cpp index 059f130130e..d33a7f75441 100644 --- a/esphome/components/pid/pid_climate.cpp +++ b/esphome/components/pid/pid_climate.cpp @@ -184,14 +184,14 @@ void PIDClimate::start_autotune(std::unique_ptr &&autotune) { float min_value = this->supports_cool_() ? -1.0f : 0.0f; float max_value = this->supports_heat_() ? 1.0f : 0.0f; this->autotuner_->config(min_value, max_value); - this->autotuner_->set_autotuner_id(this->get_log_name()); + this->autotuner_->set_autotuner_id(this->get_name()); ESP_LOGI(TAG, "%s: Autotune has started. This can take a long time depending on the " "responsiveness of your system. Your system " "output will be altered to deliberately oscillate above and below the setpoint multiple times. " "Until your sensor provides a reading, the autotuner may display \'nan\'", - LOG_STR_ARG(this->get_log_name())); + this->get_name().c_str()); this->set_interval(AUTOTUNE_PROGRESS_INTERVAL_ID, 10000, [this]() { if (this->autotuner_ != nullptr && !this->autotuner_->is_finished()) @@ -200,7 +200,7 @@ void PIDClimate::start_autotune(std::unique_ptr &&autotune) { if (mode != climate::CLIMATE_MODE_HEAT_COOL) { ESP_LOGW(TAG, "%s: !!! For PID autotuner you need to set AUTO (also called heat/cool) mode!", - LOG_STR_ARG(this->get_log_name())); + this->get_name().c_str()); } } diff --git a/esphome/components/prometheus/prometheus_handler.cpp b/esphome/components/prometheus/prometheus_handler.cpp index 502ffa15571..00c2e043102 100644 --- a/esphome/components/prometheus/prometheus_handler.cpp +++ b/esphome/components/prometheus/prometheus_handler.cpp @@ -109,23 +109,18 @@ void PrometheusHandler::handleRequest(AsyncWebServerRequest *req) { req->send(stream); } -void PrometheusHandler::print_relabel_id_(AsyncResponseStream *stream, EntityBase *obj) { +std::string PrometheusHandler::relabel_id_(EntityBase *obj) { auto item = relabel_map_id_.find(obj); if (item != relabel_map_id_.end()) { - stream->print(item->second.c_str()); - return; + return item->second; } char object_id_buf[OBJECT_ID_MAX_LEN]; - stream->print(obj->get_object_id_to(object_id_buf).c_str()); + return obj->get_object_id_to(object_id_buf).str(); } -void PrometheusHandler::print_relabel_name_(AsyncResponseStream *stream, EntityBase *obj) { +std::string PrometheusHandler::relabel_name_(EntityBase *obj) { auto item = relabel_map_name_.find(obj); - if (item != relabel_map_name_.end()) { - stream->print(item->second.c_str()); - return; - } - stream->print(reinterpret_cast(obj->get_name_progmem().progmem_ptr())); + return item == relabel_map_name_.end() ? obj->get_name() : item->second; } void PrometheusHandler::add_area_label_(AsyncResponseStream *stream, std::string &area) { @@ -153,12 +148,12 @@ void PrometheusHandler::print_metric_labels_(AsyncResponseStream *stream, Progme std::string &area, std::string &node, std::string &friendly_name) { stream->print(metric_name); stream->print(ESPHOME_F("{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); } // Type-specific implementation @@ -174,21 +169,21 @@ void PrometheusHandler::sensor_row_(AsyncResponseStream *stream, sensor::Sensor if (!std::isnan(obj->state)) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_sensor_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_sensor_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",unit=\"")); stream->print(obj->get_unit_of_measurement_ref().c_str()); stream->print(ESPHOME_F("\"} ")); @@ -199,12 +194,12 @@ void PrometheusHandler::sensor_row_(AsyncResponseStream *stream, sensor::Sensor } else { // Invalid state stream->print(ESPHOME_F("esphome_sensor_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -223,33 +218,33 @@ void PrometheusHandler::binary_sensor_row_(AsyncResponseStream *stream, binary_s if (obj->has_state()) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_binary_sensor_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_binary_sensor_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->state); stream->print(ESPHOME_F("\n")); } else { // Invalid state stream->print(ESPHOME_F("esphome_binary_sensor_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -267,33 +262,33 @@ void PrometheusHandler::fan_row_(AsyncResponseStream *stream, fan::Fan *obj, std if (obj->is_internal() && !this->include_internal_) return; stream->print(ESPHOME_F("esphome_fan_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_fan_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->state); stream->print(ESPHOME_F("\n")); // Speed if available if (obj->get_traits().supports_speed()) { stream->print(ESPHOME_F("esphome_fan_speed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->speed); stream->print(ESPHOME_F("\n")); @@ -301,12 +296,12 @@ void PrometheusHandler::fan_row_(AsyncResponseStream *stream, fan::Fan *obj, std // Oscillation if available if (obj->get_traits().supports_oscillation()) { stream->print(ESPHOME_F("esphome_fan_oscillation{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->oscillating); stream->print(ESPHOME_F("\n")); @@ -390,32 +385,32 @@ void PrometheusHandler::cover_row_(AsyncResponseStream *stream, cover::Cover *ob if (!std::isnan(obj->position)) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_cover_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_cover_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->position); stream->print(ESPHOME_F("\n")); if (obj->get_traits().get_supports_tilt()) { stream->print(ESPHOME_F("esphome_cover_tilt{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->tilt); stream->print(ESPHOME_F("\n")); @@ -423,12 +418,12 @@ void PrometheusHandler::cover_row_(AsyncResponseStream *stream, cover::Cover *ob } else { // Invalid state stream->print(ESPHOME_F("esphome_cover_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -444,21 +439,21 @@ void PrometheusHandler::switch_row_(AsyncResponseStream *stream, switch_::Switch if (obj->is_internal() && !this->include_internal_) return; stream->print(ESPHOME_F("esphome_switch_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_switch_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->state); stream->print(ESPHOME_F("\n")); @@ -475,21 +470,21 @@ void PrometheusHandler::lock_row_(AsyncResponseStream *stream, lock::Lock *obj, if (obj->is_internal() && !this->include_internal_) return; stream->print(ESPHOME_F("esphome_lock_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_lock_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->state); stream->print(ESPHOME_F("\n")); @@ -509,21 +504,21 @@ void PrometheusHandler::text_sensor_row_(AsyncResponseStream *stream, text_senso if (obj->has_state()) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_text_sensor_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_text_sensor_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",value=\"")); stream->print(obj->state.c_str()); stream->print(ESPHOME_F("\"} ")); @@ -532,12 +527,12 @@ void PrometheusHandler::text_sensor_row_(AsyncResponseStream *stream, text_senso } else { // Invalid state stream->print(ESPHOME_F("esphome_text_sensor_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -556,21 +551,21 @@ void PrometheusHandler::text_row_(AsyncResponseStream *stream, text::Text *obj, if (obj->has_state()) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_text_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_text_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",value=\"")); stream->print(obj->state.c_str()); stream->print(ESPHOME_F("\"} ")); @@ -579,12 +574,12 @@ void PrometheusHandler::text_row_(AsyncResponseStream *stream, text::Text *obj, } else { // Invalid state stream->print(ESPHOME_F("esphome_text_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -603,21 +598,21 @@ void PrometheusHandler::event_row_(AsyncResponseStream *stream, event::Event *ob if (obj->has_event()) { // We have a valid event type, output this value stream->print(ESPHOME_F("esphome_event_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_event_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",last_event_type=\"")); // get_last_event_type() returns StringRef (null-terminated) stream->print(obj->get_last_event_type().c_str()); @@ -627,12 +622,12 @@ void PrometheusHandler::event_row_(AsyncResponseStream *stream, event::Event *ob } else { // No event triggered yet stream->print(ESPHOME_F("esphome_event_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -651,33 +646,33 @@ void PrometheusHandler::number_row_(AsyncResponseStream *stream, number::Number if (!std::isnan(obj->state)) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_number_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_number_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->state); stream->print(ESPHOME_F("\n")); } else { // Invalid state stream->print(ESPHOME_F("esphome_number_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -695,21 +690,21 @@ void PrometheusHandler::select_row_(AsyncResponseStream *stream, select::Select if (obj->has_state()) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_select_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_select_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",value=\"")); // c_str() is safe as option values are null-terminated strings from codegen stream->print(obj->current_option().c_str()); @@ -719,12 +714,12 @@ void PrometheusHandler::select_row_(AsyncResponseStream *stream, select::Select } else { // Invalid state stream->print(ESPHOME_F("esphome_select_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -742,43 +737,43 @@ void PrometheusHandler::media_player_row_(AsyncResponseStream *stream, media_pla if (obj->is_internal() && !this->include_internal_) return; stream->print(ESPHOME_F("esphome_media_player_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_media_player_state_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",value=\"")); stream->print(media_player::media_player_state_to_string(obj->state)); stream->print(ESPHOME_F("\"} ")); stream->print(ESPHOME_F("1.0")); stream->print(ESPHOME_F("\n")); stream->print(ESPHOME_F("esphome_media_player_volume{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->volume); stream->print(ESPHOME_F("\n")); stream->print(ESPHOME_F("esphome_media_player_is_muted{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); if (obj->is_muted()) { stream->print(ESPHOME_F("1.0")); @@ -823,21 +818,21 @@ void PrometheusHandler::update_entity_row_(AsyncResponseStream *stream, update:: if (obj->has_state()) { // We have a valid value, output this value stream->print(ESPHOME_F("esphome_update_entity_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // First update state stream->print(ESPHOME_F("esphome_update_entity_state{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",value=\"")); handle_update_state_(stream, obj->state); stream->print(ESPHOME_F("\"} ")); @@ -845,12 +840,12 @@ void PrometheusHandler::update_entity_row_(AsyncResponseStream *stream, update:: stream->print(ESPHOME_F("\n")); // Next update info stream->print(ESPHOME_F("esphome_update_entity_info{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",current_version=\"")); stream->print(obj->update_info.current_version.c_str()); stream->print(ESPHOME_F("\",latest_version=\"")); @@ -863,12 +858,12 @@ void PrometheusHandler::update_entity_row_(AsyncResponseStream *stream, update:: } else { // Invalid state stream->print(ESPHOME_F("esphome_update_entity_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 1\n")); } } @@ -886,21 +881,21 @@ void PrometheusHandler::valve_row_(AsyncResponseStream *stream, valve::Valve *ob if (obj->is_internal() && !this->include_internal_) return; stream->print(ESPHOME_F("esphome_valve_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} 0\n")); // Data itself stream->print(ESPHOME_F("esphome_valve_operation{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",operation=\"")); stream->print(reinterpret_cast(valve::valve_operation_to_str(obj->current_operation))); stream->print(ESPHOME_F("\"} ")); @@ -909,12 +904,12 @@ void PrometheusHandler::valve_row_(AsyncResponseStream *stream, valve::Valve *ob // Now see if position is supported if (obj->get_traits().get_supports_position()) { stream->print(ESPHOME_F("esphome_valve_position{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\"} ")); stream->print(obj->position); stream->print(ESPHOME_F("\n")); @@ -933,12 +928,12 @@ void PrometheusHandler::climate_setting_row_(AsyncResponseStream *stream, climat std::string &node, std::string &friendly_name, std::string &setting, const LogString *setting_value) { stream->print(ESPHOME_F("esphome_climate_setting{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",category=\"")); stream->print(setting.c_str()); stream->print(ESPHOME_F("\",setting_value=\"")); @@ -956,12 +951,12 @@ void PrometheusHandler::climate_value_row_(AsyncResponseStream *stream, climate: std::string &node, std::string &friendly_name, std::string &category, const char *climate_value) { stream->print(ESPHOME_F("esphome_climate_value{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",category=\"")); stream->print(category.c_str()); stream->print(ESPHOME_F("\"} ")); @@ -973,12 +968,12 @@ void PrometheusHandler::climate_failed_row_(AsyncResponseStream *stream, climate std::string &node, std::string &friendly_name, std::string &category, bool is_failed_value) { stream->print(ESPHOME_F("esphome_climate_failed{id=\"")); - this->print_relabel_id_(stream, obj); + stream->print(relabel_id_(obj).c_str()); add_area_label_(stream, area); add_node_label_(stream, node); add_friendly_name_label_(stream, friendly_name); stream->print(ESPHOME_F("\",name=\"")); - this->print_relabel_name_(stream, obj); + stream->print(relabel_name_(obj).c_str()); stream->print(ESPHOME_F("\",category=\"")); stream->print(category.c_str()); stream->print(ESPHOME_F("\"} ")); diff --git a/esphome/components/prometheus/prometheus_handler.h b/esphome/components/prometheus/prometheus_handler.h index a5a83995bd7..9dcbf7e6869 100644 --- a/esphome/components/prometheus/prometheus_handler.h +++ b/esphome/components/prometheus/prometheus_handler.h @@ -63,8 +63,8 @@ class PrometheusHandler final : public AsyncWebHandler, public Component { } protected: - void print_relabel_id_(AsyncResponseStream *stream, EntityBase *obj); - void print_relabel_name_(AsyncResponseStream *stream, EntityBase *obj); + std::string relabel_id_(EntityBase *obj); + std::string relabel_name_(EntityBase *obj); void add_area_label_(AsyncResponseStream *stream, std::string &area); void add_node_label_(AsyncResponseStream *stream, std::string &node); void add_friendly_name_label_(AsyncResponseStream *stream, std::string &friendly_name); diff --git a/esphome/components/pulse_counter/pulse_counter_sensor.cpp b/esphome/components/pulse_counter/pulse_counter_sensor.cpp index 42771a50bc9..b104016fb8f 100644 --- a/esphome/components/pulse_counter/pulse_counter_sensor.cpp +++ b/esphome/components/pulse_counter/pulse_counter_sensor.cpp @@ -197,13 +197,13 @@ void PulseCounterSensor::update() { if (this->last_time_ != 0) { uint32_t interval = now - this->last_time_; float value = (60000.0f * raw) / float(interval); // per minute - ESP_LOGD(TAG, "'%s': Retrieved counter: %0.2f pulses/min", LOG_STR_ARG(this->get_log_name()), value); + ESP_LOGD(TAG, "'%s': Retrieved counter: %0.2f pulses/min", this->get_name().c_str(), value); this->publish_state(value); } if (this->total_sensor_ != nullptr) { current_total_ += raw; - ESP_LOGD(TAG, "'%s': Total : %" PRIu32 " pulses", LOG_STR_ARG(this->get_log_name()), current_total_); + ESP_LOGD(TAG, "'%s': Total : %" PRIu32 " pulses", this->get_name().c_str(), current_total_); this->total_sensor_->publish_state(current_total_); } this->last_time_ = now; diff --git a/esphome/components/pulse_width/pulse_width.cpp b/esphome/components/pulse_width/pulse_width.cpp index b53e71ef58d..53896cbacdb 100644 --- a/esphome/components/pulse_width/pulse_width.cpp +++ b/esphome/components/pulse_width/pulse_width.cpp @@ -22,7 +22,7 @@ void PulseWidthSensor::dump_config() { } void PulseWidthSensor::update() { float width = this->store_.get_pulse_width_s(); - ESP_LOGCONFIG(TAG, "'%s' - Got pulse width %.3f s", LOG_STR_ARG(this->get_log_name()), width); + ESP_LOGCONFIG(TAG, "'%s' - Got pulse width %.3f s", this->name_.c_str(), width); this->publish_state(width); } diff --git a/esphome/components/radio_frequency/radio_frequency.cpp b/esphome/components/radio_frequency/radio_frequency.cpp index 5f379790f3d..231d6c3f898 100644 --- a/esphome/components/radio_frequency/radio_frequency.cpp +++ b/esphome/components/radio_frequency/radio_frequency.cpp @@ -13,7 +13,7 @@ void RadioFrequency::dump_config() { "Radio Frequency '%s'\n" " Supports Transmitter: %s\n" " Supports Receiver: %s", - LOG_STR_ARG(this->get_log_name()), YESNO(this->get_supports_transmitter()), + this->get_name().c_str(), YESNO(this->get_supports_transmitter()), YESNO(this->get_supports_receiver())); if (this->traits_.get_frequency_min_hz() > 0) { if (this->traits_.get_frequency_min_hz() == this->traits_.get_frequency_max_hz()) { diff --git a/esphome/components/resistance/resistance_sensor.cpp b/esphome/components/resistance/resistance_sensor.cpp index de5d4a7879e..d6bc324fa42 100644 --- a/esphome/components/resistance/resistance_sensor.cpp +++ b/esphome/components/resistance/resistance_sensor.cpp @@ -38,7 +38,7 @@ void ResistanceSensor::process_(float value) { } res *= this->resistor_; - ESP_LOGV(TAG, "'%s' - Resistance %.1fΩ", LOG_STR_ARG(this->get_log_name()), res); + ESP_LOGV(TAG, "'%s' - Resistance %.1fΩ", this->name_.c_str(), res); this->publish_state(res); } diff --git a/esphome/components/scd4x/scd4x.cpp b/esphome/components/scd4x/scd4x.cpp index 2cfb2705c41..8249a6feb1e 100644 --- a/esphome/components/scd4x/scd4x.cpp +++ b/esphome/components/scd4x/scd4x.cpp @@ -133,7 +133,7 @@ void SCD4XComponent::dump_config() { ONOFF(this->enable_asc_), measurement_mode_str, this->temperature_offset_); if (this->ambient_pressure_source_ != nullptr) { ESP_LOGCONFIG(TAG, " Dynamic ambient pressure compensation using '%s'", - LOG_STR_ARG(this->ambient_pressure_source_->get_log_name())); + this->ambient_pressure_source_->get_name().c_str()); } else { if (this->ambient_pressure_) { ESP_LOGCONFIG(TAG, diff --git a/esphome/components/select/select.cpp b/esphome/components/select/select.cpp index acbb1b3a915..4d77c6d6f6c 100644 --- a/esphome/components/select/select.cpp +++ b/esphome/components/select/select.cpp @@ -13,19 +13,19 @@ void Select::publish_state(const char *state) { if (index.has_value()) { this->publish_state(index.value()); } else { - ESP_LOGE(TAG, "'%s': Invalid option %s", LOG_STR_ARG(this->get_log_name()), state); + ESP_LOGE(TAG, "'%s': Invalid option %s", this->get_name().c_str(), state); } } void Select::publish_state(size_t index) { if (!this->has_index(index)) { - ESP_LOGE(TAG, "'%s': Invalid index %zu", LOG_STR_ARG(this->get_log_name()), index); + ESP_LOGE(TAG, "'%s': Invalid index %zu", this->get_name().c_str(), index); return; } const char *option = this->option_at(index); this->set_has_state(true); this->active_index_ = index; - ESP_LOGV(TAG, "'%s' >> %s (%zu)", LOG_STR_ARG(this->get_log_name()), option, index); + ESP_LOGV(TAG, "'%s' >> %s (%zu)", this->get_name().c_str(), option, index); this->state_callback_.call(index); #if defined(USE_SELECT) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_select_update(this); diff --git a/esphome/components/select/select.h b/esphome/components/select/select.h index 7a801d6b207..2294f34e624 100644 --- a/esphome/components/select/select.h +++ b/esphome/components/select/select.h @@ -11,7 +11,7 @@ namespace esphome::select { #define LOG_SELECT(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ } diff --git a/esphome/components/select/select_call.cpp b/esphome/components/select/select_call.cpp index 9841dbde792..167e6769a4a 100644 --- a/esphome/components/select/select_call.cpp +++ b/esphome/components/select/select_call.cpp @@ -40,7 +40,7 @@ SelectCall &SelectCall::with_option(const char *option, size_t len) { SelectCall &SelectCall::with_index(size_t index) { this->operation_ = SELECT_OP_SET; if (index >= this->parent_->size()) { - ESP_LOGW(TAG, "'%s' - Index value %zu out of bounds", LOG_STR_ARG(this->parent_->get_log_name()), index); + ESP_LOGW(TAG, "'%s' - Index value %zu out of bounds", this->parent_->get_name().c_str(), index); this->index_ = nullopt; // Store nullopt for invalid index } else { this->index_ = index; @@ -101,7 +101,7 @@ optional SelectCall::calculate_target_index_(const char *name) { void SelectCall::perform() { auto *parent = this->parent_; - const auto *name = LOG_STR_ARG(parent->get_log_name()); + const auto *name = parent->get_name().c_str(); if (this->operation_ == SELECT_OP_NONE) { ESP_LOGW(TAG, "'%s' - SelectCall performed without selecting an operation", name); diff --git a/esphome/components/sensor/sensor.cpp b/esphome/components/sensor/sensor.cpp index c235ff08f5e..df73e2c481a 100644 --- a/esphome/components/sensor/sensor.cpp +++ b/esphome/components/sensor/sensor.cpp @@ -19,7 +19,7 @@ void log_sensor(const char *tag, const char *prefix, const char *type, Sensor *o "%s State Class: '%s'\n" "%s Unit of Measurement: '%s'\n" "%s Accuracy Decimals: %d", - prefix, type, LOG_STR_ARG(obj->get_log_name()), prefix, + prefix, type, obj->get_name().c_str(), prefix, LOG_STR_ARG(state_class_to_string(obj->get_state_class())), prefix, obj->get_unit_of_measurement_ref().c_str(), prefix, obj->get_accuracy_decimals()); @@ -68,7 +68,7 @@ void Sensor::publish_state(float state) { this->raw_callback_.call(state); #endif - ESP_LOGV(TAG, "'%s': Received new state %f", LOG_STR_ARG(this->get_log_name()), state); + ESP_LOGV(TAG, "'%s': Received new state %f", this->name_.c_str(), state); #ifdef USE_SENSOR_FILTER if (this->filter_list_ == nullptr) { @@ -116,8 +116,8 @@ void Sensor::clear_filters() { void Sensor::internal_send_state_to_frontend(float state) { this->set_has_state(true); this->state = state; - ESP_LOGV(TAG, "'%s' >> %.*f %s", LOG_STR_ARG(this->get_log_name()), std::max(0, (int) this->get_accuracy_decimals()), - state, this->get_unit_of_measurement_ref().c_str()); + ESP_LOGV(TAG, "'%s' >> %.*f %s", this->get_name().c_str(), std::max(0, (int) this->get_accuracy_decimals()), state, + this->get_unit_of_measurement_ref().c_str()); this->callback_.call(state); #if defined(USE_SENSOR) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_sensor_update(this); diff --git a/esphome/components/sonoff_d1/sonoff_d1.cpp b/esphome/components/sonoff_d1/sonoff_d1.cpp index c8eb385bd93..c72210e932f 100644 --- a/esphome/components/sonoff_d1/sonoff_d1.cpp +++ b/esphome/components/sonoff_d1/sonoff_d1.cpp @@ -297,8 +297,8 @@ void SonoffD1Output::dump_config() { " Use RM433 Remote: %s\n" " Minimal brightness: %d\n" " Maximal brightness: %d", - this->light_state_ ? LOG_STR_ARG(this->light_state_->get_log_name()) : "", - ONOFF(this->use_rm433_remote_), this->min_value_, this->max_value_); + this->light_state_ ? this->light_state_->get_name().c_str() : "", ONOFF(this->use_rm433_remote_), + this->min_value_, this->max_value_); } void SonoffD1Output::loop() { diff --git a/esphome/components/sprinkler/sprinkler.cpp b/esphome/components/sprinkler/sprinkler.cpp index 5a0cd14940c..eb9e61958f5 100644 --- a/esphome/components/sprinkler/sprinkler.cpp +++ b/esphome/components/sprinkler/sprinkler.cpp @@ -868,22 +868,12 @@ void Sprinkler::reset_resume() { this->resume_duration_.reset(); } -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wdeprecated-declarations" const char *Sprinkler::valve_name(const size_t valve_number) { if (this->is_a_valid_valve(valve_number)) { return this->valve_[valve_number].controller_switch->get_name().c_str(); } return nullptr; } -#pragma GCC diagnostic pop - -const LogString *Sprinkler::valve_log_name(const size_t valve_number) { - if (this->is_a_valid_valve(valve_number)) { - return this->valve_[valve_number].controller_switch->get_log_name(); - } - return nullptr; -} optional Sprinkler::active_valve_request_is_from() { if (this->active_req_.has_request()) { @@ -1596,8 +1586,7 @@ void Sprinkler::dump_config() { " Valve %zu:\n" " Name: %s\n" " Run Duration: %" PRIu32 " seconds", - valve_number, LOG_STR_ARG(this->valve_log_name(valve_number)), - this->valve_run_duration(valve_number)); + valve_number, this->valve_name(valve_number), this->valve_run_duration(valve_number)); } if (!this->pump_.empty()) { ESP_LOGCONFIG(TAG, " Total number of pumps: %zu", this->pump_.size()); diff --git a/esphome/components/sprinkler/sprinkler.h b/esphome/components/sprinkler/sprinkler.h index e5922b56c97..c51824d8833 100644 --- a/esphome/components/sprinkler/sprinkler.h +++ b/esphome/components/sprinkler/sprinkler.h @@ -336,10 +336,7 @@ class Sprinkler final : public Component { void reset_resume(); /// returns a pointer to a valve's name string object; returns nullptr if valve_number is invalid - ESPDEPRECATED("Use valve_log_name() or control_switch()->get_name_to() instead. Removed in 2027.5.0", "2026.11.0") const char *valve_name(size_t valve_number); - /// returns a valve's name for a "%s" log argument; returns nullptr if valve_number is invalid - const LogString *valve_log_name(size_t valve_number); /// returns what invoked the valve that is currently active, if any. check with 'has_value()' optional active_valve_request_is_from(); diff --git a/esphome/components/status_led/light/status_led_light.cpp b/esphome/components/status_led/light/status_led_light.cpp index 5877dcfb76f..6eeb9732a47 100644 --- a/esphome/components/status_led/light/status_led_light.cpp +++ b/esphome/components/status_led/light/status_led_light.cpp @@ -35,7 +35,7 @@ void StatusLEDLightOutput::loop() { void StatusLEDLightOutput::setup_state(light::LightState *state) { lightstate_ = state; - ESP_LOGD(TAG, "'%s': Setting initial state", LOG_STR_ARG(state->get_log_name())); + ESP_LOGD(TAG, "'%s': Setting initial state", state->get_name().c_str()); this->write_state(state); } @@ -46,7 +46,7 @@ void StatusLEDLightOutput::write_state(light::LightState *state) { // if in warning/error, don't overwrite the status_led // once it is back to OK, the loop will restore the state if ((App.get_app_state() & (STATUS_LED_ERROR | STATUS_LED_WARNING)) == 0u) { - ESP_LOGD(TAG, "'%s': Setting state %s", LOG_STR_ARG(state->get_log_name()), ONOFF(binary)); + ESP_LOGD(TAG, "'%s': Setting state %s", state->get_name().c_str(), ONOFF(binary)); this->output_state_(binary); } } diff --git a/esphome/components/stcc4/stcc4.cpp b/esphome/components/stcc4/stcc4.cpp index e14daeb0005..ac7a998e5d6 100644 --- a/esphome/components/stcc4/stcc4.cpp +++ b/esphome/components/stcc4/stcc4.cpp @@ -151,16 +151,16 @@ void STCC4Component::dump_config() { : LOG_STR_LITERAL("Single shot")); if (this->ambient_pressure_source_ != nullptr) { ESP_LOGCONFIG(TAG, " Dynamic ambient pressure compensation using '%s'", - LOG_STR_ARG(this->ambient_pressure_source_->get_log_name())); + this->ambient_pressure_source_->get_name().c_str()); } else if (this->ambient_pressure_in_pa_2_ != 0) { ESP_LOGCONFIG(TAG, " Ambient pressure compensation: %f hPa", pressure_in_pa_2_to_hpa(this->ambient_pressure_in_pa_2_)); } if (this->temperature_source_ != nullptr) { - ESP_LOGCONFIG(TAG, " Temperature compensation using '%s'", LOG_STR_ARG(this->temperature_source_->get_log_name())); + ESP_LOGCONFIG(TAG, " Temperature compensation using '%s'", this->temperature_source_->get_name().c_str()); } if (this->humidity_source_ != nullptr) { - ESP_LOGCONFIG(TAG, " Humidity compensation using '%s'", LOG_STR_ARG(this->humidity_source_->get_log_name())); + ESP_LOGCONFIG(TAG, " Humidity compensation using '%s'", this->humidity_source_->get_name().c_str()); } LOG_UPDATE_INTERVAL(this); LOG_SENSOR(" ", "CO2", this->co2_sensor_); diff --git a/esphome/components/switch/switch.cpp b/esphome/components/switch/switch.cpp index c5ca8e24be3..179ef2ce35d 100644 --- a/esphome/components/switch/switch.cpp +++ b/esphome/components/switch/switch.cpp @@ -17,15 +17,15 @@ void Switch::control(bool target_state) { } } void Switch::turn_on() { - ESP_LOGV(TAG, "'%s' Turning ON.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' Turning ON.", this->get_name().c_str()); this->write_state(!this->inverted_); } void Switch::turn_off() { - ESP_LOGV(TAG, "'%s' Turning OFF.", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' Turning OFF.", this->get_name().c_str()); this->write_state(this->inverted_); } void Switch::toggle() { - ESP_LOGV(TAG, "'%s' Toggling %s.", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "'%s' Toggling %s.", this->get_name().c_str(), this->state ? LOG_STR_LITERAL("OFF") : LOG_STR_LITERAL("ON")); this->write_state(this->inverted_ == this->state); } @@ -62,7 +62,7 @@ void Switch::publish_state(bool state) { if (restore_mode & RESTORE_MODE_PERSISTENT_MASK) this->rtc_.save(&this->state); - ESP_LOGV(TAG, "'%s' >> %s", LOG_STR_ARG(this->get_log_name()), ONOFF(this->state)); + ESP_LOGV(TAG, "'%s' >> %s", this->name_.c_str(), ONOFF(this->state)); this->state_callback_.call(this->state); #if defined(USE_SWITCH) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_switch_update(this); @@ -86,7 +86,7 @@ void log_switch(const char *tag, const char *prefix, const char *type, Switch *o ESP_LOGCONFIG(tag, "%s%s '%s'\n" "%s Restore Mode: %s%s %s", - prefix, type, LOG_STR_ARG(obj->get_log_name()), prefix, LOG_STR_ARG(inverted), LOG_STR_ARG(restore), + prefix, type, obj->get_name().c_str(), prefix, LOG_STR_ARG(inverted), LOG_STR_ARG(restore), LOG_STR_ARG(onoff)); // Add optional fields separately diff --git a/esphome/components/template/alarm_control_panel/template_alarm_control_panel.cpp b/esphome/components/template/alarm_control_panel/template_alarm_control_panel.cpp index 6d16b9b7edb..12ff0b5a4b4 100644 --- a/esphome/components/template/alarm_control_panel/template_alarm_control_panel.cpp +++ b/esphome/components/template/alarm_control_panel/template_alarm_control_panel.cpp @@ -67,8 +67,7 @@ void TemplateAlarmControlPanel::dump_config() { " Armed night bypass: %s\n" " Auto bypass: %s\n" " Chime mode: %s", - LOG_STR_ARG(alarm_sensor.sensor->get_log_name()), - LOG_STR_ARG(sensor_type_to_string(alarm_sensor.info.type)), + alarm_sensor.sensor->get_name().c_str(), LOG_STR_ARG(sensor_type_to_string(alarm_sensor.info.type)), TRUEFALSE(flags & BINARY_SENSOR_MODE_BYPASS_ARMED_HOME), TRUEFALSE(flags & BINARY_SENSOR_MODE_BYPASS_ARMED_NIGHT), TRUEFALSE(flags & BINARY_SENSOR_MODE_BYPASS_AUTO), TRUEFALSE(flags & BINARY_SENSOR_MODE_CHIME)); @@ -253,7 +252,7 @@ void TemplateAlarmControlPanel::auto_bypass_sensors_() { auto *sensor = alarm_sensor.sensor; // Check for faulted bypass_auto sensors and remove them from monitoring if ((info.flags & BINARY_SENSOR_MODE_BYPASS_AUTO) && (sensor->state)) { - ESP_LOGW(TAG, "'%s' is faulted and will be automatically bypassed", LOG_STR_ARG(sensor->get_log_name())); + ESP_LOGW(TAG, "'%s' is faulted and will be automatically bypassed", sensor->get_name().c_str()); info.auto_bypassed = true; } } diff --git a/esphome/components/template/climate/template_climate.cpp b/esphome/components/template/climate/template_climate.cpp index 9345cf2ac20..a731f037e32 100644 --- a/esphome/components/template/climate/template_climate.cpp +++ b/esphome/components/template/climate/template_climate.cpp @@ -115,7 +115,7 @@ void TemplateClimate::control(const climate::ClimateCall &call) { // so check here instead -- otherwise a typo is published as state the receiving end will reject. void TemplateClimate::set_mode(climate::ClimateMode mode) { if (!this->traits_.supports_mode(mode)) { - ESP_LOGW(TAG, "'%s' - Unsupported mode %u", LOG_STR_ARG(this->get_log_name()), static_cast(mode)); + ESP_LOGW(TAG, "'%s' - Unsupported mode %u", this->get_name().c_str(), static_cast(mode)); return; } this->mode = mode; @@ -123,8 +123,7 @@ void TemplateClimate::set_mode(climate::ClimateMode mode) { void TemplateClimate::set_swing_mode(climate::ClimateSwingMode swing_mode) { if (!this->traits_.supports_swing_mode(swing_mode)) { - ESP_LOGW(TAG, "'%s' - Unsupported swing mode %u", LOG_STR_ARG(this->get_log_name()), - static_cast(swing_mode)); + ESP_LOGW(TAG, "'%s' - Unsupported swing mode %u", this->get_name().c_str(), static_cast(swing_mode)); return; } this->swing_mode = swing_mode; @@ -132,7 +131,7 @@ void TemplateClimate::set_swing_mode(climate::ClimateSwingMode swing_mode) { void TemplateClimate::set_fan_mode(climate::ClimateFanMode fan_mode) { if (!this->traits_.supports_fan_mode(fan_mode)) { - ESP_LOGW(TAG, "'%s' - Unsupported fan mode %u", LOG_STR_ARG(this->get_log_name()), static_cast(fan_mode)); + ESP_LOGW(TAG, "'%s' - Unsupported fan mode %u", this->get_name().c_str(), static_cast(fan_mode)); return; } this->set_fan_mode_(fan_mode); @@ -140,7 +139,7 @@ void TemplateClimate::set_fan_mode(climate::ClimateFanMode fan_mode) { void TemplateClimate::set_preset(climate::ClimatePreset preset) { if (!this->traits_.supports_preset(preset)) { - ESP_LOGW(TAG, "'%s' - Unsupported preset %u", LOG_STR_ARG(this->get_log_name()), static_cast(preset)); + ESP_LOGW(TAG, "'%s' - Unsupported preset %u", this->get_name().c_str(), static_cast(preset)); return; } this->set_preset_(preset); @@ -148,7 +147,7 @@ void TemplateClimate::set_preset(climate::ClimatePreset preset) { void TemplateClimate::set_custom_fan_mode(StringRef mode) { if (this->find_custom_fan_mode_(mode.c_str(), mode.size()) == nullptr) { - ESP_LOGW(TAG, "'%s' - Unsupported custom fan mode '%s'", LOG_STR_ARG(this->get_log_name()), mode.c_str()); + ESP_LOGW(TAG, "'%s' - Unsupported custom fan mode '%s'", this->get_name().c_str(), mode.c_str()); return; } this->set_custom_fan_mode_(mode); @@ -156,7 +155,7 @@ void TemplateClimate::set_custom_fan_mode(StringRef mode) { void TemplateClimate::set_custom_preset(StringRef preset) { if (this->find_custom_preset_(preset.c_str(), preset.size()) == nullptr) { - ESP_LOGW(TAG, "'%s' - Unsupported custom preset '%s'", LOG_STR_ARG(this->get_log_name()), preset.c_str()); + ESP_LOGW(TAG, "'%s' - Unsupported custom preset '%s'", this->get_name().c_str(), preset.c_str()); return; } this->set_custom_preset_(preset); diff --git a/esphome/components/text/text.cpp b/esphome/components/text/text.cpp index 809ee57e0a6..58ab300b904 100644 --- a/esphome/components/text/text.cpp +++ b/esphome/components/text/text.cpp @@ -15,9 +15,9 @@ void Text::publish_state(const char *state, size_t len) { this->state.assign(state, len); } if (this->traits.get_mode() == TEXT_MODE_PASSWORD) { - ESP_LOGV(TAG, "'%s' >> " LOG_SECRET("'%s'"), LOG_STR_ARG(this->get_log_name()), this->state.c_str()); + ESP_LOGV(TAG, "'%s' >> " LOG_SECRET("'%s'"), this->get_name().c_str(), this->state.c_str()); } else { - ESP_LOGV(TAG, "'%s' >> '%s'", LOG_STR_ARG(this->get_log_name()), this->state.c_str()); + ESP_LOGV(TAG, "'%s' >> '%s'", this->get_name().c_str(), this->state.c_str()); } this->state_callback_.call(this->state); #if defined(USE_TEXT) && defined(USE_CONTROLLER_REGISTRY) diff --git a/esphome/components/text/text.h b/esphome/components/text/text.h index 5cb0916a312..54afb8db8f2 100644 --- a/esphome/components/text/text.h +++ b/esphome/components/text/text.h @@ -10,7 +10,7 @@ namespace esphome::text { #define LOG_TEXT(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ LOG_ENTITY_ICON(TAG, prefix, *(obj)); \ } diff --git a/esphome/components/text/text_call.cpp b/esphome/components/text/text_call.cpp index c4283af318d..93f0610d7d6 100644 --- a/esphome/components/text/text_call.cpp +++ b/esphome/components/text/text_call.cpp @@ -17,7 +17,7 @@ TextCall &TextCall::set_value(const char *value, size_t len) { } void TextCall::validate_() { - const auto *name = LOG_STR_ARG(this->parent_->get_log_name()); + const auto *name = this->parent_->get_name().c_str(); if (!this->value_.has_value()) { ESP_LOGW(TAG, "'%s' - No value set for TextCall", name); @@ -42,16 +42,16 @@ void TextCall::validate_() { void TextCall::perform() { this->validate_(); if (!this->value_.has_value()) { - ESP_LOGW(TAG, "'%s' - No value set for TextCall", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGW(TAG, "'%s' - No value set for TextCall", this->parent_->get_name().c_str()); return; } std::string target_value = this->value_.value(); if (this->parent_->traits.get_mode() == TEXT_MODE_PASSWORD) { - ESP_LOGV(TAG, "'%s' - Setting password value: " LOG_SECRET("'%s'"), LOG_STR_ARG(this->parent_->get_log_name()), + ESP_LOGV(TAG, "'%s' - Setting password value: " LOG_SECRET("'%s'"), this->parent_->get_name().c_str(), target_value.c_str()); } else { - ESP_LOGV(TAG, "'%s' - Setting text value: %s", LOG_STR_ARG(this->parent_->get_log_name()), target_value.c_str()); + ESP_LOGV(TAG, "'%s' - Setting text value: %s", this->parent_->get_name().c_str(), target_value.c_str()); } this->parent_->control(target_value); } diff --git a/esphome/components/text_sensor/text_sensor.cpp b/esphome/components/text_sensor/text_sensor.cpp index 1dde0981948..af4c5fd0816 100644 --- a/esphome/components/text_sensor/text_sensor.cpp +++ b/esphome/components/text_sensor/text_sensor.cpp @@ -13,7 +13,7 @@ void log_text_sensor(const char *tag, const char *prefix, const char *type, Text return; } - ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, LOG_STR_ARG(obj->get_log_name())); + ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, obj->get_name().c_str()); LOG_ENTITY_DEVICE_CLASS(tag, prefix, *obj); LOG_ENTITY_ICON(tag, prefix, *obj); } @@ -30,7 +30,7 @@ void TextSensor::publish_state(const char *state, size_t len) { #ifdef USE_TEXT_SENSOR_FILTER this->raw_callback_.call(this->state); #endif - ESP_LOGV(TAG, "'%s': Received new state %s", LOG_STR_ARG(this->get_log_name()), this->state.c_str()); + ESP_LOGV(TAG, "'%s': Received new state %s", this->name_.c_str(), this->state.c_str()); this->notify_frontend_(); #ifdef USE_TEXT_SENSOR_FILTER } else { @@ -40,7 +40,7 @@ void TextSensor::publish_state(const char *state, size_t len) { this->raw_state_.assign(state, len); } this->raw_callback_.call(this->raw_state_); - ESP_LOGV(TAG, "'%s': Received new state %s", LOG_STR_ARG(this->get_log_name()), this->raw_state_.c_str()); + ESP_LOGV(TAG, "'%s': Received new state %s", this->name_.c_str(), this->raw_state_.c_str()); this->filter_list_->input(this->raw_state_); } #endif @@ -97,7 +97,7 @@ void TextSensor::internal_send_state_to_frontend(const char *state, size_t len) void TextSensor::notify_frontend_() { this->set_has_state(true); - ESP_LOGV(TAG, "'%s' >> '%s'", LOG_STR_ARG(this->get_log_name()), this->state.c_str()); + ESP_LOGV(TAG, "'%s' >> '%s'", this->name_.c_str(), this->state.c_str()); this->callback_.call(this->state); #if defined(USE_TEXT_SENSOR) && defined(USE_CONTROLLER_REGISTRY) ControllerRegistry::notify_text_sensor_update(this); diff --git a/esphome/components/tmp1075/tmp1075.cpp b/esphome/components/tmp1075/tmp1075.cpp index f5bce6efc2d..9b152c1ad34 100644 --- a/esphome/components/tmp1075/tmp1075.cpp +++ b/esphome/components/tmp1075/tmp1075.cpp @@ -19,7 +19,7 @@ static float regvalue2temp(uint16_t regvalue); void TMP1075Sensor::setup() { uint8_t cfg; if (!this->read_byte(REG_CFGR, &cfg)) { - ESP_LOGE(TAG, "'%s' - unable to read", LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, "'%s' - unable to read", this->name_.c_str()); this->mark_failed(); return; } @@ -30,7 +30,7 @@ void TMP1075Sensor::setup() { void TMP1075Sensor::update() { uint16_t regvalue; if (!read_byte_16(REG_TEMP, ®value)) { - ESP_LOGW(TAG, "'%s' - unable to read temperature register", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' - unable to read temperature register", this->name_.c_str()); this->status_set_warning(LOG_STR("can't read")); return; } @@ -61,11 +61,11 @@ void TMP1075Sensor::dump_config() { void TMP1075Sensor::set_fault_count(const int faults) { if (faults < 1) { - ESP_LOGE(TAG, "'%s' - fault_count too low: %d", LOG_STR_ARG(this->get_log_name()), faults); + ESP_LOGE(TAG, "'%s' - fault_count too low: %d", this->name_.c_str(), faults); return; } if (faults > 4) { - ESP_LOGE(TAG, "'%s' - fault_count too high: %d", LOG_STR_ARG(this->get_log_name()), faults); + ESP_LOGE(TAG, "'%s' - fault_count too high: %d", this->name_.c_str(), faults); return; } config_.fields.faults = faults - 1; @@ -90,28 +90,28 @@ void TMP1075Sensor::write_config() { } void TMP1075Sensor::send_config_() { - ESP_LOGV(TAG, "'%s' - sending configuration %02x", LOG_STR_ARG(this->get_log_name()), config_.regvalue); + ESP_LOGV(TAG, "'%s' - sending configuration %02x", this->name_.c_str(), config_.regvalue); log_config_(); if (!this->write_byte(REG_CFGR, config_.regvalue)) { - ESP_LOGW(TAG, "'%s' - unable to write configuration register", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' - unable to write configuration register", this->name_.c_str()); return; } } void TMP1075Sensor::send_alert_limit_low_() { - ESP_LOGV(TAG, "'%s' - sending alert limit low %.3f °C", LOG_STR_ARG(this->get_log_name()), alert_limit_low_); + ESP_LOGV(TAG, "'%s' - sending alert limit low %.3f °C", this->name_.c_str(), alert_limit_low_); const uint16_t regvalue = temp2regvalue(alert_limit_low_); if (!this->write_byte_16(REG_LLIM, regvalue)) { - ESP_LOGW(TAG, "'%s' - unable to write low limit register", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' - unable to write low limit register", this->name_.c_str()); return; } } void TMP1075Sensor::send_alert_limit_high_() { - ESP_LOGV(TAG, "'%s' - sending alert limit high %.3f °C", LOG_STR_ARG(this->get_log_name()), alert_limit_high_); + ESP_LOGV(TAG, "'%s' - sending alert limit high %.3f °C", this->name_.c_str(), alert_limit_high_); const uint16_t regvalue = temp2regvalue(alert_limit_high_); if (!this->write_byte_16(REG_HLIM, regvalue)) { - ESP_LOGW(TAG, "'%s' - unable to write high limit register", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' - unable to write high limit register", this->name_.c_str()); return; } } diff --git a/esphome/components/uart/button/uart_button.cpp b/esphome/components/uart/button/uart_button.cpp index 07cc75bfdf8..99b5ee548d0 100644 --- a/esphome/components/uart/button/uart_button.cpp +++ b/esphome/components/uart/button/uart_button.cpp @@ -6,7 +6,7 @@ namespace esphome::uart { ESPHOME_LOG_TAG(TAG, "uart.button"); void UARTButton::press_action() { - ESP_LOGD(TAG, "'%s': Sending data", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s': Sending data", this->get_name().c_str()); this->write_array_progmem(this->data_, this->data_len_); } diff --git a/esphome/components/uart/switch/uart_switch.cpp b/esphome/components/uart/switch/uart_switch.cpp index c078e023461..1af497ffcfd 100644 --- a/esphome/components/uart/switch/uart_switch.cpp +++ b/esphome/components/uart/switch/uart_switch.cpp @@ -18,11 +18,11 @@ void UARTSwitch::loop() { void UARTSwitch::write_command_(bool state) { if (state && this->data_on_len_ != 0) { - ESP_LOGD(TAG, "'%s': Sending on data", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s': Sending on data", this->get_name().c_str()); this->write_array_progmem(this->data_on_, this->data_on_len_); } if (!state && this->data_off_len_ != 0) { - ESP_LOGD(TAG, "'%s': Sending off data", LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s': Sending off data", this->get_name().c_str()); this->write_array_progmem(this->data_off_, this->data_off_len_); } } diff --git a/esphome/components/ultrasonic/ultrasonic_sensor.cpp b/esphome/components/ultrasonic/ultrasonic_sensor.cpp index c119c91d9e5..039d08eaae7 100644 --- a/esphome/components/ultrasonic/ultrasonic_sensor.cpp +++ b/esphome/components/ultrasonic/ultrasonic_sensor.cpp @@ -60,7 +60,7 @@ void UltrasonicSensorComponent::loop() { if (!this->store_.echo_start) { uint32_t elapsed = micros() - this->measurement_start_us_; if (elapsed >= START_TIMEOUT_US) { - ESP_LOGW(TAG, "'%s' - Measurement start timed out", LOG_STR_ARG(this->get_log_name())); + ESP_LOGW(TAG, "'%s' - Measurement start timed out", this->name_.c_str()); this->publish_state(NAN); this->measurement_pending_ = false; return; @@ -73,8 +73,7 @@ void UltrasonicSensorComponent::loop() { elapsed = micros() - this->store_.echo_start_us; } if (elapsed >= this->timeout_us_) { - ESP_LOGD(TAG, "'%s' - Measurement pulse timed out after %" PRIu32 "us", LOG_STR_ARG(this->get_log_name()), - elapsed); + ESP_LOGD(TAG, "'%s' - Measurement pulse timed out after %" PRIu32 "us", this->name_.c_str(), elapsed); this->publish_state(NAN); this->measurement_pending_ = false; return; @@ -85,7 +84,7 @@ void UltrasonicSensorComponent::loop() { uint32_t pulse_duration = this->store_.echo_end_us - this->store_.echo_start_us; ESP_LOGV(TAG, "Echo took %" PRIu32 "us", pulse_duration); float result = UltrasonicSensorComponent::us_to_m(pulse_duration); - ESP_LOGD(TAG, "'%s' - Got distance: %.3f m", LOG_STR_ARG(this->get_log_name()), result); + ESP_LOGD(TAG, "'%s' - Got distance: %.3f m", this->name_.c_str(), result); this->publish_state(result); this->measurement_pending_ = false; return; diff --git a/esphome/components/update/update_entity.cpp b/esphome/components/update/update_entity.cpp index 89608c797d6..33c33ccb621 100644 --- a/esphome/components/update/update_entity.cpp +++ b/esphome/components/update/update_entity.cpp @@ -20,7 +20,7 @@ void UpdateEntity::publish_state() { ESP_LOGV(TAG, "'%s' >>\n" " Current Version: %s", - LOG_STR_ARG(this->get_log_name()), this->update_info_.current_version.c_str()); + this->name_.c_str(), this->update_info_.current_version.c_str()); if (!this->update_info_.md5.empty()) { ESP_LOGV(TAG, " Latest Version: %s", this->update_info_.latest_version.c_str()); diff --git a/esphome/components/valve/valve.cpp b/esphome/components/valve/valve.cpp index fdee764936f..a5ad9817df7 100644 --- a/esphome/components/valve/valve.cpp +++ b/esphome/components/valve/valve.cpp @@ -42,7 +42,7 @@ ValveCall &ValveCall::set_command(const char *command) { } else if (ESPHOME_strcasecmp_P(command, ESPHOME_PSTR("TOGGLE")) == 0) { this->set_command_toggle(); } else { - ESP_LOGW(TAG, "'%s' - Unrecognized command %s", LOG_STR_ARG(this->parent_->get_log_name()), command); + ESP_LOGW(TAG, "'%s' - Unrecognized command %s", this->parent_->get_name().c_str(), command); } return *this; } @@ -67,7 +67,7 @@ ValveCall &ValveCall::set_position(float position) { return *this; } void ValveCall::perform() { - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); auto traits = this->parent_->get_traits(); this->validate_(); if (this->stop_) { @@ -92,18 +92,16 @@ void ValveCall::validate_() { if (this->position_.has_value()) { auto pos = *this->position_; if (!traits.get_supports_position() && pos != VALVE_OPEN && pos != VALVE_CLOSED) { - ESP_LOGW(TAG, "'%s' - This valve device does not support setting position!", - LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGW(TAG, "'%s' - This valve device does not support setting position!", this->parent_->get_name().c_str()); this->position_.reset(); } else if (pos < 0.0f || pos > 1.0f) { - ESP_LOGW(TAG, "'%s' - Position %.2f is out of range [0.0 - 1.0]", LOG_STR_ARG(this->parent_->get_log_name()), - pos); + ESP_LOGW(TAG, "'%s' - Position %.2f is out of range [0.0 - 1.0]", this->parent_->get_name().c_str(), pos); this->position_ = clamp(pos, 0.0f, 1.0f); } } if (this->toggle_.has_value()) { if (!traits.get_supports_toggle()) { - ESP_LOGW(TAG, "'%s' - This valve device does not support toggle!", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGW(TAG, "'%s' - This valve device does not support toggle!", this->parent_->get_name().c_str()); this->toggle_.reset(); } } @@ -125,7 +123,7 @@ ValveCall &ValveCall::set_stop(bool stop) { void Valve::publish_state(bool save) { this->position = clamp(this->position, 0.0f, 1.0f); - ESP_LOGV(TAG, "'%s' >>", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s' >>", this->name_.c_str()); auto traits = this->get_traits(); if (traits.get_supports_position()) { ESP_LOGV(TAG, " Position: %.0f%%", this->position * 100.0f); diff --git a/esphome/components/valve/valve.h b/esphome/components/valve/valve.h index 2316870d3b6..183680e5e4a 100644 --- a/esphome/components/valve/valve.h +++ b/esphome/components/valve/valve.h @@ -14,7 +14,7 @@ const extern float VALVE_CLOSED; #define LOG_VALVE(prefix, type, obj) \ if ((obj) != nullptr) { \ - ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), LOG_STR_ARG((obj)->get_log_name())); \ + ESP_LOGCONFIG(TAG, "%s%s '%s'", prefix, LOG_STR_LITERAL(type), (obj)->get_name().c_str()); \ auto traits_ = (obj)->get_traits(); \ if (traits_.get_is_assumed_state()) { \ ESP_LOGCONFIG(TAG, "%s Assumed State: YES", prefix); \ diff --git a/esphome/components/veml3235/veml3235.cpp b/esphome/components/veml3235/veml3235.cpp index 40f320aad26..3a856696782 100644 --- a/esphome/components/veml3235/veml3235.cpp +++ b/esphome/components/veml3235/veml3235.cpp @@ -47,7 +47,7 @@ bool VEML3235Sensor::refresh_config_reg() { void VEML3235Sensor::update() { if (this->measurement_in_progress_) { - ESP_LOGV(TAG, "'%s': Previous measurement still in progress; skipping update", LOG_STR_ARG(this->get_log_name())); + ESP_LOGV(TAG, "'%s': Previous measurement still in progress; skipping update", this->get_name().c_str()); return; } this->measurement_in_progress_ = true; @@ -80,9 +80,9 @@ void VEML3235Sensor::read_and_publish_(uint8_t adjustments_left) { } float lux = this->counts_to_lux_(als_counts); - ESP_LOGVV(TAG, "'%s': ALS counts = %u, sensitivity = %ux", LOG_STR_ARG(this->get_log_name()), als_counts, + ESP_LOGVV(TAG, "'%s': ALS counts = %u, sensitivity = %ux", this->get_name().c_str(), als_counts, this->sensitivity_factor_()); - ESP_LOGV(TAG, "'%s': Illuminance = %.4flx", LOG_STR_ARG(this->get_log_name()), lux); + ESP_LOGV(TAG, "'%s': Illuminance = %.4flx", this->get_name().c_str(), lux); this->publish_state(lux); this->measurement_in_progress_ = false; } @@ -177,7 +177,7 @@ bool VEML3235Sensor::adjust_sensitivity_(uint16_t counts) { return false; } - ESP_LOGV(TAG, "'%s': Sensitivity adjusted from %ux to %ux (ALS counts = %u)", LOG_STR_ARG(this->get_log_name()), + ESP_LOGV(TAG, "'%s': Sensitivity adjusted from %ux to %ux (ALS counts = %u)", this->get_name().c_str(), current_factor, new_factor, counts); return true; } diff --git a/esphome/components/vl53l0x/vl53l0x_sensor.cpp b/esphome/components/vl53l0x/vl53l0x_sensor.cpp index fdd3c063f1e..2e3d1c85299 100644 --- a/esphome/components/vl53l0x/vl53l0x_sensor.cpp +++ b/esphome/components/vl53l0x/vl53l0x_sensor.cpp @@ -92,7 +92,7 @@ void VL53L0XSensor::setup() { uint32_t timeout_start_us = micros(); while (reg(0x83).get() == 0x00) { if (this->timeout_us_ > 0 && (micros() - timeout_start_us > this->timeout_us_)) { - ESP_LOGE(TAG, "'%s' - setup timeout", LOG_STR_ARG(this->get_log_name())); + ESP_LOGE(TAG, "'%s' - setup timeout", this->name_.c_str()); this->mark_failed(); return; } @@ -267,7 +267,7 @@ void VL53L0XSensor::update() { this->publish_state(NAN); this->status_momentary_warning(5000); ESP_LOGW(TAG, "%s - update called before prior reading complete - initiated:%d waiting_for_interrupt:%d", - LOG_STR_ARG(this->get_log_name()), this->initiated_read_, this->waiting_for_interrupt_); + this->name_.c_str(), this->initiated_read_, this->waiting_for_interrupt_); return; } @@ -306,14 +306,13 @@ void VL53L0XSensor::loop() { this->waiting_for_interrupt_ = false; if (range_mm >= 8190) { - ESP_LOGD(TAG, "'%s' - Distance is out of range, please move the target closer", - LOG_STR_ARG(this->get_log_name())); + ESP_LOGD(TAG, "'%s' - Distance is out of range, please move the target closer", this->name_.c_str()); this->publish_state(NAN); return; } float range_m = range_mm / 1e3f; - ESP_LOGD(TAG, "'%s' - Got distance %.3f m", LOG_STR_ARG(this->get_log_name()), range_m); + ESP_LOGD(TAG, "'%s' - Got distance %.3f m", this->name_.c_str(), range_m); this->publish_state(range_m); } } diff --git a/esphome/components/water_heater/water_heater.cpp b/esphome/components/water_heater/water_heater.cpp index cd5020a5822..e5236a04916 100644 --- a/esphome/components/water_heater/water_heater.cpp +++ b/esphome/components/water_heater/water_heater.cpp @@ -15,7 +15,7 @@ ESPHOME_LOG_TAG(TAG, "water_heater"); void log_water_heater(const char *tag, const char *prefix, const char *type, WaterHeater *obj) { if (obj != nullptr) { - ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, LOG_STR_ARG(obj->get_log_name())); + ESP_LOGCONFIG(tag, "%s%s '%s'", prefix, type, obj->get_name().c_str()); } } @@ -44,7 +44,7 @@ WaterHeaterCall &WaterHeaterCall::set_mode(const char *mode, size_t len) { } else if (len == 3 && ESPHOME_strncasecmp_P(mode, ESPHOME_PSTR("GAS"), 3) == 0) { this->set_mode(WATER_HEATER_MODE_GAS); } else { - ESP_LOGW(TAG, "'%s' - Unrecognized mode %.*s", LOG_STR_ARG(this->parent_->get_log_name()), (int) len, mode); + ESP_LOGW(TAG, "'%s' - Unrecognized mode %.*s", this->parent_->get_name().c_str(), (int) len, mode); } return *this; } @@ -85,7 +85,7 @@ WaterHeaterCall &WaterHeaterCall::set_on(bool on) { } void WaterHeaterCall::perform() { - ESP_LOGV(TAG, "'%s' - Setting", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGV(TAG, "'%s' - Setting", this->parent_->get_name().c_str()); this->validate_(); if (this->mode_.has_value()) { ESP_LOGV(TAG, " Mode: %s", LOG_STR_ARG(water_heater_mode_to_string(*this->mode_))); @@ -113,7 +113,7 @@ void WaterHeaterCall::validate_() { auto traits = this->parent_->get_traits(); if (this->mode_.has_value()) { if (!traits.supports_mode(*this->mode_)) { - ESP_LOGW(TAG, "'%s' - Mode %" PRIu32 " not supported", LOG_STR_ARG(this->parent_->get_log_name()), + ESP_LOGW(TAG, "'%s' - Mode %" PRIu32 " not supported", this->parent_->get_name().c_str(), static_cast(*this->mode_)); this->mode_.reset(); } @@ -121,36 +121,34 @@ void WaterHeaterCall::validate_() { if (!std::isnan(this->target_temperature_)) { if (traits.get_supports_two_point_target_temperature()) { ESP_LOGW(TAG, "'%s' - Cannot set target temperature for device with two-point target temperature", - LOG_STR_ARG(this->parent_->get_log_name())); + this->parent_->get_name().c_str()); this->target_temperature_ = NAN; } else if (this->target_temperature_ < traits.get_min_temperature() || this->target_temperature_ > traits.get_max_temperature()) { - ESP_LOGW(TAG, "'%s' - Target temperature %.1f is out of range [%.1f - %.1f]", - LOG_STR_ARG(this->parent_->get_log_name()), this->target_temperature_, traits.get_min_temperature(), - traits.get_max_temperature()); + ESP_LOGW(TAG, "'%s' - Target temperature %.1f is out of range [%.1f - %.1f]", this->parent_->get_name().c_str(), + this->target_temperature_, traits.get_min_temperature(), traits.get_max_temperature()); this->target_temperature_ = std::max(traits.get_min_temperature(), std::min(this->target_temperature_, traits.get_max_temperature())); } } if (!std::isnan(this->target_temperature_low_) || !std::isnan(this->target_temperature_high_)) { if (!traits.get_supports_two_point_target_temperature()) { - ESP_LOGW(TAG, "'%s' - Cannot set low/high target temperature", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGW(TAG, "'%s' - Cannot set low/high target temperature", this->parent_->get_name().c_str()); this->target_temperature_low_ = NAN; this->target_temperature_high_ = NAN; } } if (!std::isnan(this->target_temperature_low_) && !std::isnan(this->target_temperature_high_)) { if (this->target_temperature_low_ > this->target_temperature_high_) { - ESP_LOGW(TAG, "'%s' - Target temperature low %.2f must be less than high %.2f", - LOG_STR_ARG(this->parent_->get_log_name()), this->target_temperature_low_, - this->target_temperature_high_); + ESP_LOGW(TAG, "'%s' - Target temperature low %.2f must be less than high %.2f", this->parent_->get_name().c_str(), + this->target_temperature_low_, this->target_temperature_high_); this->target_temperature_low_ = NAN; this->target_temperature_high_ = NAN; } } if (!traits.get_supports_away_mode()) { if (this->state_ & WATER_HEATER_STATE_AWAY) { - ESP_LOGW(TAG, "'%s' - Away mode not supported", LOG_STR_ARG(this->parent_->get_log_name())); + ESP_LOGW(TAG, "'%s' - Away mode not supported", this->parent_->get_name().c_str()); } this->state_ &= ~WATER_HEATER_STATE_AWAY; this->state_mask_ &= ~WATER_HEATER_STATE_AWAY; @@ -168,7 +166,7 @@ void WaterHeater::publish_state() { ESP_LOGV(TAG, "'%s' >>\n" " Mode: %s", - LOG_STR_ARG(this->get_log_name()), LOG_STR_ARG(water_heater_mode_to_string(this->mode_))); + this->name_.c_str(), LOG_STR_ARG(water_heater_mode_to_string(this->mode_))); if (!std::isnan(this->current_temperature_)) { ESP_LOGV(TAG, " Current Temperature: %.2f°C", this->current_temperature_); } diff --git a/esphome/components/web_server/web_server.cpp b/esphome/components/web_server/web_server.cpp index 4877fda5d41..b0da010561e 100644 --- a/esphome/components/web_server/web_server.cpp +++ b/esphome/components/web_server/web_server.cpp @@ -218,7 +218,7 @@ EntityMatchResult UrlMatch::match_entity(EntityBase *entity) const { #endif // Match by entity name - if (entity->name_equals(this->id)) { + if (this->id == entity->get_name()) { result.matched = true; } @@ -651,7 +651,9 @@ void WebServer::handle_js_request(AsyncWebServerRequest *request) { // Build unique id as: {domain}/{device_name}/{entity_name} or {domain}/{entity_name} // Uses names (not object_id) to avoid UTF-8 collision issues static void set_json_id(JsonObject root, EntityBase *obj, const char *prefix, JsonDetail start_config) { + const StringRef &name = obj->get_name(); size_t prefix_len = strlen(prefix); + size_t name_len = name.size(); #ifdef USE_DEVICES Device *device = obj->get_device(); @@ -681,13 +683,13 @@ static void set_json_id(JsonObject root, EntityBase *obj, const char *prefix, Js *p++ = '/'; } #endif - const char *name = p; - obj->write_name_to(p, id_buf + ID_BUF_SIZE - p); + memcpy(p, name.c_str(), name_len); + p[name_len] = '\0'; root[ESPHOME_F("id")] = static_cast(id_buf); if (start_config == DETAIL_ALL) { root[ESPHOME_F("domain")] = linked(prefix, prefix_len); - root[ESPHOME_F("name")] = name; // in id_buf on the stack, so copied + root[ESPHOME_F("name")] = linked(name); #ifdef USE_DEVICES if (device_name) { root[ESPHOME_F("device")] = linked(device_name, device_len); diff --git a/esphome/components/web_server/web_server_v1.cpp b/esphome/components/web_server/web_server_v1.cpp index e49cb76ffa2..08654e353a9 100644 --- a/esphome/components/web_server/web_server_v1.cpp +++ b/esphome/components/web_server/web_server_v1.cpp @@ -42,10 +42,8 @@ void write_row(AsyncResponseStream *stream, EntityBase *obj, const std::string & // Add data attributes for hierarchical URL support stream->print("\" data-domain=\""); stream->print(klass.c_str()); - char name_buf[ENTITY_NAME_BUF_SIZE]; - const char *name = obj->get_name_to(name_buf).c_str(); stream->print("\" data-name=\""); - write_html_escaped(stream, name); + write_html_escaped(stream, obj->get_name().c_str()); #ifdef USE_DEVICES Device *device = obj->get_device(); if (device != nullptr) { @@ -61,7 +59,7 @@ void write_row(AsyncResponseStream *stream, EntityBase *obj, const std::string & stream->print("] "); } #endif - write_html_escaped(stream, name); + write_html_escaped(stream, obj->get_name().c_str()); stream->print(""); stream->print(action.c_str()); if (action_func) { diff --git a/esphome/components/xiaomi_mccgq02hl/xiaomi_mccgq02hl.cpp b/esphome/components/xiaomi_mccgq02hl/xiaomi_mccgq02hl.cpp index 84e406a7ab0..519358270d3 100644 --- a/esphome/components/xiaomi_mccgq02hl/xiaomi_mccgq02hl.cpp +++ b/esphome/components/xiaomi_mccgq02hl/xiaomi_mccgq02hl.cpp @@ -60,7 +60,7 @@ bool XiaomiMCCGQ02HL::parse_device(const ble_device_base::ESPBTDevice &device) { if (!this->parse_service_data_(service_data.data, reading)) continue; - ESP_LOGD(TAG, "%s: open=%s light=%s battery=%s", LOG_STR_ARG(this->get_log_name()), + ESP_LOGD(TAG, "%s: open=%s light=%s battery=%s", this->get_name().c_str(), reading.open.has_value() ? (*reading.open ? LOG_STR_LITERAL("yes") : LOG_STR_LITERAL("no")) : LOG_STR_LITERAL("-"), reading.light.has_value() ? (*reading.light ? LOG_STR_LITERAL("yes") : LOG_STR_LITERAL("no")) diff --git a/esphome/core/entity_base.cpp b/esphome/core/entity_base.cpp index 45d11e68a3c..1e1c523ad3b 100644 --- a/esphome/core/entity_base.cpp +++ b/esphome/core/entity_base.cpp @@ -25,7 +25,7 @@ uint32_t fnv1_hash_object_id_progmem(const char *str, size_t len) { return hash; } -// RAM copies made by the deprecated get_name(), only for entities whose name is asked for. Remove before 2027.5.0 +// RAM copies made by get_name(), only for entities whose name is asked for struct NameCopy { NameCopy *next; const char *key; diff --git a/esphome/core/entity_base.h b/esphome/core/entity_base.h index 3e241dc2f9c..48c7083851b 100644 --- a/esphome/core/entity_base.h +++ b/esphome/core/entity_base.h @@ -74,16 +74,12 @@ class EntityBase { public: #ifdef USE_ESP8266 /// The name is in flash here; the first call makes a RAM copy that is kept for the life of the device. - // Remove before 2027.5.0 - ESPDEPRECATED("Use get_name_to() or get_log_name() instead. Will be removed in ESPHome 2027.5.0", "2026.11.0") const StringRef &get_name() const; /// Get the name of this Entity, copied out of flash into buffer. StringRef get_name_to(std::span buffer) const { return StringRef(buffer.data(), this->write_name_to(buffer.data(), buffer.size())); } #else - // Remove before 2027.5.0 - ESPDEPRECATED("Use get_name_to() or get_log_name() instead. Will be removed in ESPHome 2027.5.0", "2026.11.0") const StringRef &get_name() const { return this->name_.ram_ref(); } const StringRef &get_name_to(std::span /*buffer*/) const { return this->name_.ram_ref(); } #endif diff --git a/tests/components/light/common.yaml b/tests/components/light/common.yaml index 3ac1e4194ee..c1e58c673f6 100644 --- a/tests/components/light/common.yaml +++ b/tests/components/light/common.yaml @@ -294,7 +294,7 @@ light: if (state == 4) state = 0; if (initial_run) { - ESP_LOGD("custom_effect", "Effect %s started", LOG_STR_ARG(it.get_log_name())); + ESP_LOGD("custom_effect", "Effect %s started", it.get_name().c_str()); } - pulse: transition_length: 10s