github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-05 18:41:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

PID Climate - deadband and output sampling (#3254)

Browse Source
This commit is contained in:
Patrick Collins
2022-11-30 10:58:43 +13:00
committed by GitHub
parent d706f40ce1
commit 3669320398
6 changed files with 278 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files
esphome/components/pid/pid_climate.cpp
+14 -4
View File
@@ -61,7 +61,17 @@ climate::ClimateTraits PIDClimate::traits() {
void PIDClimate::dump_config() {
LOG_CLIMATE("", "PID Climate", this);
ESP_LOGCONFIG(TAG, " Control Parameters:");
ESP_LOGCONFIG(TAG, " kp: %.5f, ki: %.5f, kd: %.5f", controller_.kp, controller_.ki, controller_.kd);
ESP_LOGCONFIG(TAG, " kp: %.5f, ki: %.5f, kd: %.5f, output samples: %d", controller_.kp_, controller_.ki_,
controller_.kd_, controller_.output_samples_);
if (controller_.threshold_low_ == 0 && controller_.threshold_high_ == 0) {
ESP_LOGCONFIG(TAG, " Deadband disabled.");
} else {
ESP_LOGCONFIG(TAG, " Deadband Parameters:");
ESP_LOGCONFIG(TAG, " threshold: %0.5f to %0.5f, multipliers(kp: %.5f, ki: %.5f, kd: %.5f), output samples: %d",
controller_.threshold_low_, controller_.threshold_high_, controller_.kp_multiplier_,
controller_.ki_multiplier_, controller_.kd_multiplier_, controller_.deadband_output_samples_);
}
if (this->autotuner_ != nullptr) {
this->autotuner_->dump_config();
@@ -114,9 +124,9 @@ void PIDClimate::update_pid_() {
if (this->autotuner_ != nullptr && !this->autotuner_->is_finished()) {
auto res = this->autotuner_->update(this->target_temperature, this->current_temperature);
if (res.result_params.has_value()) {
this->controller_.kp = res.result_params->kp;
this->controller_.ki = res.result_params->ki;
this->controller_.kd = res.result_params->kd;
this->controller_.kp_ = res.result_params->kp;
this->controller_.ki_ = res.result_params->ki;
this->controller_.kd_ = res.result_params->kd;
// keep autotuner instance so that subsequent dump_configs will print the long result message.
} else {
value = res.output;