github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-03 17:55:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Deduplicate resolved endpoints before sizing the attempt budget"

Browse Source 
This reverts commit 077041e072.
This commit is contained in:
J. Nick Koston
2026-08-12 20:47:43 -05:00
parent 077041e072
commit 3465ee3ca9
2 changed files with 0 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/test_espota2.py
-19
View File
@@ -851,25 +851,6 @@ def test_run_ota_impl_multiple_addresses_cycle(
assert mock_sleep.call_count == 2
@pytest.mark.usefixtures("mock_socket_constructor")
def test_run_ota_impl_duplicate_addresses_deduplicated(
mock_socket: Mock, firmware_file: Path, mock_resolve_ip: Mock, mock_sleep: Mock
) -> None:
"""Test duplicate resolved endpoints do not inflate the attempt budget."""
entry = (socket.AF_INET, socket.SOCK_STREAM, 0, "", ("192.168.1.100", 3232))
mock_resolve_ip.return_value = [entry, entry]
mock_socket.connect.side_effect = OSError("Connection refused")
result_code, result_host = espota2.run_ota_impl_(
"test.local", 3232, "password", str(firmware_file)
)
assert result_code == 1
assert result_host is None
# The duplicate collapses to one endpoint, so the budget is 1 + EXTRA
assert mock_socket.connect.call_count == espota2.EXTRA_UPLOAD_ATTEMPTS + 1
@pytest.mark.usefixtures("mock_socket_constructor", "mock_resolve_ip_dual")
def test_run_ota_impl_second_address_succeeds_without_delay(
mock_socket: Mock,