From 2e809c3626dd485b667328ed6b13772a03dfec64 Mon Sep 17 00:00:00 2001
From: "J. Nick Koston" <nick@koston.org>
Date: Wed, 23 Sep 2026 23:13:44 +0100
Subject: [PATCH] [pulse_counter] Use register_apply_action for
 pulse_counter.set_total_pulses (#19532)

---
 esphome/components/pulse_counter/automation.h | 21 -----------------
 esphome/components/pulse_counter/sensor.py    | 23 +++----------------
 tests/components/pulse_counter/common.yaml    |  8 +++++++
 3 files changed, 11 insertions(+), 41 deletions(-)
 delete mode 100644 esphome/components/pulse_counter/automation.h

diff --git a/esphome/components/pulse_counter/automation.h b/esphome/components/pulse_counter/automation.h
deleted file mode 100644
index 380ef02304..0000000000
--- a/esphome/components/pulse_counter/automation.h
+++ /dev/null
@@ -1,21 +0,0 @@
-#pragma once
-
-#include "esphome/core/component.h"
-#include "esphome/core/automation.h"
-#include "esphome/components/pulse_counter/pulse_counter_sensor.h"
-
-namespace esphome::pulse_counter {
-
-template<typename... Ts> class SetTotalPulsesAction final : public Action<Ts...> {
- public:
-  SetTotalPulsesAction(PulseCounterSensor *pulse_counter) : pulse_counter_(pulse_counter) {}
-
-  TEMPLATABLE_VALUE(uint32_t, total_pulses)
-
-  void play(const Ts &...x) override { this->pulse_counter_->set_total_pulses(this->total_pulses_.value(x...)); }
-
- protected:
-  PulseCounterSensor *pulse_counter_;
-};
-
-}  // namespace esphome::pulse_counter
diff --git a/esphome/components/pulse_counter/sensor.py b/esphome/components/pulse_counter/sensor.py
index 7c5a0590d7..677cfb6a5e 100644
--- a/esphome/components/pulse_counter/sensor.py
+++ b/esphome/components/pulse_counter/sensor.py
@@ -21,8 +21,7 @@ from esphome.const import (
     UNIT_PULSES,
     UNIT_PULSES_PER_MINUTE,
 )
-from esphome.core import CORE, ID
-from esphome.cpp_generator import MockObj, TemplateArgsType
+from esphome.core import CORE
 from esphome.types import ConfigType
 
 CONF_USE_PCNT = "use_pcnt"
@@ -41,10 +40,6 @@ PulseCounterSensor = pulse_counter_ns.class_(
     "PulseCounterSensor", sensor.Sensor, cg.PollingComponent
 )
 
-SetTotalPulsesAction = pulse_counter_ns.class_(
-    "SetTotalPulsesAction", automation.Action
-)
-
 
 def validate_internal_filter(value: ConfigType) -> ConfigType:
     use_pcnt = value.get(CONF_USE_PCNT)
@@ -150,25 +145,13 @@ async def to_code(config: ConfigType) -> None:
         cg.add(var.set_total_sensor(sens))
 
 
-@automation.register_action(
+automation.register_apply_action(
     "pulse_counter.set_total_pulses",
-    SetTotalPulsesAction,
     cv.Schema(
         {
             cv.Required(CONF_ID): cv.use_id(PulseCounterSensor),
             cv.Required(CONF_VALUE): cv.templatable(cv.uint32_t),
         }
     ),
-    synchronous=True,
+    automation.ApplyField(CONF_VALUE, "set_total_pulses", cg.uint32),
 )
-async def set_total_action_to_code(
-    config: ConfigType,
-    action_id: ID,
-    template_arg: cg.TemplateArguments,
-    args: TemplateArgsType,
-) -> MockObj:
-    paren = await cg.get_variable(config[CONF_ID])
-    var = cg.new_Pvariable(action_id, template_arg, paren)
-    template_ = await cg.templatable(config[CONF_VALUE], args, cg.uint32)
-    cg.add(var.set_total_pulses(template_))
-    return var
diff --git a/tests/components/pulse_counter/common.yaml b/tests/components/pulse_counter/common.yaml
index 556b43ee6f..2b27d5467b 100644
--- a/tests/components/pulse_counter/common.yaml
+++ b/tests/components/pulse_counter/common.yaml
@@ -1,5 +1,6 @@
 sensor:
   - platform: pulse_counter
+    id: pulse_counter_sensor
     name: Pulse Counter
     pin: 4
     count_mode:
@@ -7,3 +8,10 @@ sensor:
       falling_edge: DECREMENT
     internal_filter: 13us
     update_interval: 15s
+    on_value:
+      - pulse_counter.set_total_pulses:
+          id: pulse_counter_sensor
+          value: 12345
+      - pulse_counter.set_total_pulses:
+          id: pulse_counter_sensor
+          value: !lambda return (uint32_t) x;