github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-22 05:46:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

[packet_interface] Route broadcasts to the broadcast port, and keep a join

Browse Source 
A broadcast from a device with its own port went to that port, whose
layers drop it, so a broadcast port could not reach reliable peers. It now
goes to the broadcast port when there is one.

Fragmentation allocates its buffers with RAMAllocator and fails setup when
they cannot be allocated. A fragment from another source no longer drops
the packet being joined.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
clydebarrow
2026-10-20 08:41:59 +11:00
co-authored by Claude Opus 5.5
parent 869f5ab144
commit 28c32cf1f6
7 changed files with 87 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/packet_interface/basic_addressing.cpp
+18
View File
@@ -143,6 +143,24 @@ TEST(BasicAddressingTest, PeersHaveSeparateStacks) {
EXPECT_TRUE(d.port().received.empty());
}
TEST(BasicAddressingTest, BroadcastFromPeerReachesBroadcastPort) {
Device hub(1, {2, BROADCAST}), b(2, {1, BROADCAST});
hub.port(1).send({0x10}); // a state every device needs
hub.port(0).send({0x11}); // point to point
hub.deliver({&b});
EXPECT_EQ(b.port(0).received, std::vector<Packet>{{0x11}});
EXPECT_EQ(b.port(1).received, std::vector<Packet>{{0x10}});
EXPECT_EQ(b.port(1).sources, std::vector<uint16_t>{1});
}
TEST(BasicAddressingTest, WithoutBroadcastPortPeerBroadcastReachesItsPort) {
Device hub(1, {2, 3}), b(2, BROADCAST);
b.port().send({0x20});
b.deliver({&hub});
EXPECT_EQ(hub.port(0).received, std::vector<Packet>{{0x20}});
EXPECT_TRUE(hub.port(1).received.empty());
}
TEST(BasicAddressingTest, WithoutBroadcastPortUnknownDevicesDropped) {
Device hub(1, {2, 3}), d(4);
d.port().send({0x04});