From 256677a46786f8c595005c2eee3a867d6fdb4827 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 30 Sep 2026 11:47:54 +0200 Subject: [PATCH] [ci] Keep the venv ninja on PATH, only cmake is missing in a real install --- .github/workflows/cmake-windows.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cmake-windows.yml b/.github/workflows/cmake-windows.yml index c89c49aa8c..3410cfcb4e 100644 --- a/.github/workflows/cmake-windows.yml +++ b/.github/workflows/cmake-windows.yml @@ -30,13 +30,14 @@ jobs: call venv\Scripts\activate.bat pip install -r requirements.txt pip install -e . - # The runner image has cmake and ninja preinstalled on PATH, which - # would mask the bug: users of the builder install see neither. Strip + # The runner image has cmake preinstalled on PATH, which would mask + # the bug: users of the builder install have no host cmake. Strip # PATH to the interpreter, git and the system dirs, then prove it. - - name: Compile without cmake or ninja on the host PATH + # ninja stays reachable through the venv, as in a real install: the + # pip ninja package from requirements.txt puts it in Scripts. + - name: Compile without cmake on the host PATH shell: cmd run: | set "PATH=%CD%\venv\Scripts;%pythonLocation%;%pythonLocation%\Scripts;C:\Program Files\Git\cmd;%SystemRoot%\system32;%SystemRoot%" where cmake && echo cmake still on PATH, test is invalid && exit /b 1 - where ninja && echo ninja still on PATH, test is invalid && exit /b 1 esphome compile .github/cmake_windows/idf.yaml