github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-03 09:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Name the CLI data timeout, pin it in a test, word the device comment as observed not proven

Browse Source
This commit is contained in:
J. Nick Koston
2026-09-08 15:51:17 +02:00
parent e9f25a55b0
commit 24ec7ca3a7
3 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit_tests/test_espota2.py
+6 -2
View File
@@ -754,8 +754,12 @@ def test_run_ota_impl_successful(
assert result_code == 0
assert result_host == "192.168.1.100"
# Verify socket was configured correctly
mock_socket.settimeout.assert_called_with(20.0)
# Verify socket was configured correctly: connect timeout first, then the
# data phase timeout, which must outlast the device's 105 s data timeout
timeouts = [c.args[0] for c in mock_socket.settimeout.call_args_list]
assert timeouts[0] == 20.0
assert espota2.DATA_PHASE_TIMEOUT in timeouts
assert espota2.DATA_PHASE_TIMEOUT > 105.0
mock_socket.connect.assert_called_once_with(("192.168.1.100", 3232))
mock_socket.close.assert_called_once()