Gate the zero-test guard behind a flag, keep the upload path import-free, verify all artifacts, regenerate a stale compile DB

tests/script/test_test_build_components.py

@@ -238,10 +238,36 @@ def test_run_grouped_test_closes_group_when_subprocess_raises(
     assert "::endgroup::" in capsys.readouterr().out
 
 
-def test_components_empty_match_fails(capsys: pytest.CaptureFixture[str]) -> None:
-    """A real component filtered to a platform with no matching test file
-    must not pass CI as a green zero-component compile. (An unknown
-    component name instead builds the reference baseline.)"""
-    rc = tbc.test_components(["logger"], "zz-none", "compile", False)
+def test_components_empty_match_fails_with_flag(
+    capsys: pytest.CaptureFixture[str],
+) -> None:
+    """Under --fail-on-no-tests, a real component filtered to a platform
+    with no matching test file must not pass CI as a green zero-component
+    compile."""
+    rc = tbc.test_components(
+        ["logger"], "zz-none", "compile", False, fail_on_no_tests=True
+    )
     assert rc == 1
     assert "No tests matched" in capsys.readouterr().out
+
+
+def test_components_empty_match_tolerated_without_flag() -> None:
+    """The esp32-ard smoke leg deliberately builds only the subset with a
+    matching fixture; without the flag an empty match stays green."""
+    assert tbc.test_components(["logger"], "zz-none", "compile", False) == 0
+
+
+def test_components_unknown_component_fails_with_flag(
+    capsys: pytest.CaptureFixture[str],
+) -> None:
+    """A renamed smoke-test component must shrink coverage loudly, not fall
+    into the reference-baseline build."""
+    rc = tbc.test_components(
+        ["no_such_component_xyz"],
+        "esp8266-ard",
+        "compile",
+        False,
+        fail_on_no_tests=True,
+    )
+    assert rc == 1
+    assert "No tests found for requested component(s)" in capsys.readouterr().out

tests/unit_tests/test_arduino8266_toolchain.py

@@ -42,8 +42,13 @@ def _setup_core(tmp_path: Path) -> None:
     # that "produced" them (tests for the guard delete them again)
     build_dir = CORE.relative_pioenvs_path("test8266")
     build_dir.mkdir(parents=True, exist_ok=True)
-    (build_dir / "firmware.elf").write_bytes(b"")
-    (build_dir / "firmware.bin").write_bytes(b"")
+    for artifact in (
+        "firmware.elf",
+        "firmware.bin",
+        "firmware.factory.bin",
+        "firmware.ota.bin",
+    ):
+        (build_dir / artifact).write_bytes(b"")
 
 
 def _paths(tmp_path: Path) -> framework.InstalledPaths:
@@ -139,6 +144,36 @@ def test_run_compile_noop_skips_the_build_spawn(tmp_path: Path) -> None:
     assert ninja_calls[0][0][0][-1] == "-n"
 
 
+def test_run_compile_regenerates_stale_compdb(tmp_path: Path) -> None:
+    """An interrupted run can leave build.ninja newer than the compile DB;
+    mere existence must not skip regeneration."""
+    import os
+
+    build_dir = toolchain.get_build_dir()
+    build_dir.mkdir(parents=True, exist_ok=True)
+    (build_dir / "build.ninja").write_text("")
+    compdb = build_dir / "compile_commands.json"
+    compdb.write_text("[]")
+    os.utime(compdb, ((build_dir / "build.ninja").stat().st_mtime - 5,) * 2)
+    with (
+        patch.object(framework, "check_and_install", return_value=_paths(tmp_path)),
+        patch.object(framework, "get_build_env", return_value={}),
+        patch("esphome.build_gen.arduino8266.write_project", return_value=False),
+        patch.object(
+            toolchain.subprocess,
+            "run",
+            return_value=MagicMock(
+                returncode=0, stdout="ninja: no work to do.\n", stderr=""
+            ),
+        ),
+        patch.object(toolchain, "_write_compile_commands") as mock_compdb,
+        patch.object(toolchain, "_print_size_summary"),
+        patch.object(toolchain, "get_idedata"),
+    ):
+        assert toolchain.run_compile({CONF_ESPHOME: {}}, verbose=False) == 0
+    mock_compdb.assert_called_once()
+
+
 def test_run_compile_surfaces_probe_diagnostics(
     tmp_path: Path, caplog: pytest.LogCaptureFixture
 ) -> None: