From 0e3bcafdb3bf052c8541a90b01775212dbd801e7 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Tue, 7 Apr 2026 15:07:33 -1000 Subject: [PATCH] touch ups --- esphome/components/max6956/max6956.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/esphome/components/max6956/max6956.cpp b/esphome/components/max6956/max6956.cpp index 8e6ca7ac22..30efd8ef76 100644 --- a/esphome/components/max6956/max6956.cpp +++ b/esphome/components/max6956/max6956.cpp @@ -54,7 +54,7 @@ bool MAX6956::digital_read_hw(uint8_t pin) { // Calculate bank index based on the base class view (no offset adjustment) uint8_t bank_index = pin / MAX6956_BANK_SIZE; - static const uint8_t BANK_REGS[4] = { + static constexpr uint8_t BANK_REGS[4] = { MAX6956_4PORTS_4_7, // Bank 0: 4 ports 4-7 (bits D0-D3, D4-D7 read as 0) MAX6956_8PORTS_8_15, // Bank 1: 8 ports 8-15 (bits D0-D7) MAX6956_8PORTS_16_23, // Bank 2: 8 ports 16-23 (bits D0-D7) @@ -80,15 +80,8 @@ bool MAX6956::digital_read_hw(uint8_t pin) { } bool MAX6956::digital_read_cache(uint8_t pin) { - // MAX6956 pins start at MAX6956_MIN - if (pin < MAX6956_MIN || pin > MAX6956_MAX) { - return false; - } - - // Use the base class's view of banks (no offset adjustment) uint8_t bank_index = pin / MAX6956_BANK_SIZE; uint8_t bit_position = pin % MAX6956_BANK_SIZE; - return (this->input_banks_[bank_index] & (1 << bit_position)) != 0; }