github/esphome
2
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-10-06 19:06:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

[climate_ir] Only advertise HEAT_COOL when heat and cool are both supported (#19483)

Browse Source
This commit is contained in:
Leonardo Rivera
2026-09-23 11:14:57 +01:00
committed by GitHub
parent e8d3c06b60
commit 00fa63ea19
17 changed files with 262 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/climate_ir/climate_ir_test.cpp
+56
View File
@@ -0,0 +1,56 @@
#include <gtest/gtest.h>
#include "esphome/components/climate_ir/climate_ir.h"
namespace esphome::climate_ir::testing {
class TestClimateIR : public ClimateIR {
public:
TestClimateIR() : ClimateIR(16.0f, 30.0f) {}
using ClimateIR::traits;
protected:
void transmit_state() override {}
};
// The HEAT_COOL default is covered in tests/component_tests/climate_ir.
TEST(ClimateIRTest, HeatCoolAdvertisedWhenSupported) {
TestClimateIR climate;
climate.set_supports_heat(true);
climate.set_supports_cool(true);
climate.set_supports_heat_cool(true);
EXPECT_TRUE(climate.traits().supports_mode(climate::CLIMATE_MODE_HEAT_COOL));
}
TEST(ClimateIRTest, HeatCoolNotAdvertisedWhenUnsupported) {
TestClimateIR climate;
climate.set_supports_heat(true);
climate.set_supports_cool(true);
climate.set_supports_heat_cool(false);
EXPECT_FALSE(climate.traits().supports_mode(climate::CLIMATE_MODE_HEAT_COOL));
}
TEST(ClimateIRTest, HeatCoolAdvertisedForCoolOnlyDeviceThatSupportsIt) {
TestClimateIR climate;
climate.set_supports_heat(false);
climate.set_supports_cool(true);
climate.set_supports_heat_cool(true);
auto traits = climate.traits();
EXPECT_TRUE(traits.supports_mode(climate::CLIMATE_MODE_HEAT_COOL));
EXPECT_FALSE(traits.supports_mode(climate::CLIMATE_MODE_HEAT));
}
TEST(ClimateIRTest, HeatAndCoolModesFollowTheirOwnFlags) {
TestClimateIR climate;
climate.set_supports_heat(false);
climate.set_supports_cool(true);
climate.set_supports_heat_cool(false);
auto traits = climate.traits();
EXPECT_TRUE(traits.supports_mode(climate::CLIMATE_MODE_COOL));
EXPECT_FALSE(traits.supports_mode(climate::CLIMATE_MODE_HEAT));
EXPECT_FALSE(traits.supports_mode(climate::CLIMATE_MODE_HEAT_COOL));
EXPECT_TRUE(traits.supports_mode(climate::CLIMATE_MODE_OFF));
}
} // namespace esphome::climate_ir::testing